René's URL Explorer Experiment


Title: gh-154675: Avoid importing inspect when creating a slotted dataclass by aisk · Pull Request #156841 · python/cpython · GitHub

Open Graph Title: gh-154675: Avoid importing inspect when creating a slotted dataclass by aisk · Pull Request #156841 · python/cpython

X Title: gh-154675: Avoid importing inspect when creating a slotted dataclass by aisk · Pull Request #156841 · python/cpython

Description: Using @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import, so dataclasses can too. Perhaps in the future unwrap() could move into a small private module that inspect and all these copies import, so the implementations do not drift apart. Importing a module that defines one slotted dataclass, best of 30 runs. $ cat app.py from dataclasses import dataclass @dataclass(slots=True) class Point: x: int = 0 y: int = 0 $ ./python -c 'import time; t = time.perf_counter(); import app; print(time.perf_counter() - t)' 0.022856871997646522 # before 0.010011243997723795 # after About 2.3x faster. Issue: gh-154675

Open Graph Description: Using @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import...

X Description: Using @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import...

Opengraph URL: https://github.com/python/cpython/pull/156841

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:260f8703-4c39-5476-2cf1-0ac65860fc50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7E4:E9D16:34F2802:432A1AF:6B02147F
html-safe-nonce9f83907c4474f7f9e2bf2d36d95f012eae3bc1024c6628395476d3ee4f461827
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0U0OkU5RDE2OjM0RjI4MDI6NDMyQTFBRjo2QjAyMTQ3RiIsInZpc2l0b3JfaWQiOiIzMjAyNDYyMDYzMDU0MTY1MTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac31b4aa439313ec5231caacff215c8bedaf15087f9629ff8abe23f538e343b55e
hovercard-subject-tagpull_request:4424541827
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156841/files
twitter:imagehttps://avatars.githubusercontent.com/u/699636?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/699636?s=400&v=4
og:image:altUsing @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156841/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156841%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156841%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156841/files
Reloadhttps://github.com/python/cpython/pull/156841/files
Reloadhttps://github.com/python/cpython/pull/156841/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
aiskhttps://github.com/aisk
python:mainhttps://github.com/python/cpython/tree/main
aisk:dataclasses-inline-unwraphttps://github.com/aisk/cpython/tree/dataclasses-inline-unwrap
Conversation 4 https://github.com/python/cpython/pull/156841
Commits 6 https://github.com/python/cpython/pull/156841/commits
Checks 47 https://github.com/python/cpython/pull/156841/checks
Files changed 3 https://github.com/python/cpython/pull/156841/files
gh-154675: Avoid importing inspect when creating a slotted dataclass https://github.com/python/cpython/pull/156841/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/156841/files
d86a8ef gh-154675: Avoid importing inspect when creating a slotted dataclass aisk Sep 2, 2026 https://github.com/python/cpython/pull/156841/commits/d86a8efb30e5c9c58054948c96037bcc4dc9af66
2b98d01 Use ensure_lazy_imports in the regression test aisk Sep 2, 2026 https://github.com/python/cpython/pull/156841/commits/2b98d017bbd117efb0f67a2e13de072e53a1c747
0aa2387 Create the slotted class before generating methods aisk Sep 14, 2026 https://github.com/python/cpython/pull/156841/commits/0aa2387c44c17ce78ee5ba092f5cfb21adad4997
436ffbc Update NEWS entry aisk Sep 14, 2026 https://github.com/python/cpython/pull/156841/commits/436ffbc0e3677a136400a078dc3386acf9d9a746
f0ca027 Merge branch 'main' into dataclasses-inline-unwrap aisk Sep 14, 2026 https://github.com/python/cpython/pull/156841/commits/f0ca027a6a0956b63aea8695b1eeaf245e73160f
a0ccb79 Add a regression test aisk Sep 17, 2026 https://github.com/python/cpython/pull/156841/commits/a0ccb7951b8a76124d26edbdce4ca1066bb28fd4
Clear filters https://github.com/python/cpython/pull/156841/files
Please reload this pagehttps://github.com/python/cpython/pull/156841/files
Please reload this pagehttps://github.com/python/cpython/pull/156841/files
dataclasses.py https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
__init__.py https://github.com/python/cpython/pull/156841/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
2026-09-03-00-42-32.gh-issue-154675.NX8eYm.rst https://github.com/python/cpython/pull/156841/files#diff-45daa01f3fb3b28c282da7ede3b998ff54d383aa6eaa8eac7f2b77e5075d9c97
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L422
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/python/cpython/blob/a0ccb7951b8a76124d26edbdce4ca1066bb28fd4/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156841/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/156841/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L423
Lib/test/test_dataclasses/__init__.pyhttps://github.com/python/cpython/pull/156841/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
View file https://github.com/python/cpython/blob/a0ccb7951b8a76124d26edbdce4ca1066bb28fd4/Lib/test/test_dataclasses/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156841/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156841/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/156841/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/156841/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/156841/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
Misc/NEWS.d/next/Library/2026-09-03-00-42-32.gh-issue-154675.NX8eYm.rsthttps://github.com/python/cpython/pull/156841/files#diff-45daa01f3fb3b28c282da7ede3b998ff54d383aa6eaa8eac7f2b77e5075d9c97
View file https://github.com/python/cpython/blob/a0ccb7951b8a76124d26edbdce4ca1066bb28fd4/Misc/NEWS.d/next/Library/2026-09-03-00-42-32.gh-issue-154675.NX8eYm.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156841/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/156841/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.