René's URL Explorer Experiment


Title: gh-154675: Avoid importing inspect when creating a slotted dataclass by aisk · Pull Request #156841 · python/cpython · GitHub

Open Graph Title: gh-154675: Avoid importing inspect when creating a slotted dataclass by aisk · Pull Request #156841 · python/cpython

X Title: gh-154675: Avoid importing inspect when creating a slotted dataclass by aisk · Pull Request #156841 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Using @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import...

X Description: Using @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import...

Opengraph URL: https://github.com/python/cpython/pull/156841

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:69fa1c0b-116f-1303-ba30-2c3809bf6ce2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF76:29AEE8:35DDACC:47B9335:6B020589
html-safe-nonce812c9fe5d81246740e3c597a722e1fc3ca3168fa91bdab3fc721f7d01aa1120e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjc2OjI5QUVFODozNUREQUNDOjQ3QjkzMzU6NkIwMjA1ODkiLCJ2aXNpdG9yX2lkIjoiODgwNDU3MDU1MDcxMTIyMzY4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac25a115eb928edc3422e93ae526722e40fe45c2a2dd60b6f9d32e1e9e32ed4cb9
hovercard-subject-tagpull_request:4424541827
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/156841/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/83f008ad9ebd57b091625ae07ab0784b44c46eb357fc2ede8f3aab0474885c47/python/cpython/pull/156841
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/83f008ad9ebd57b091625ae07ab0784b44c46eb357fc2ede8f3aab0474885c47/python/cpython/pull/156841
og:image:altUsing @dataclass(slots=True) always imports inspect, just for the single inspect.unwrap() call in _add_slots(). typing and annotationlib already inline the same __wrapped__ walk to avoid the import...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaisk
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/156841#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156841
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156841
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156841
Reloadhttps://github.com/python/cpython/pull/156841
Reloadhttps://github.com/python/cpython/pull/156841
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
aiskhttps://github.com/aisk
python:mainhttps://github.com/python/cpython/tree/main
aisk:dataclasses-inline-unwraphttps://github.com/aisk/cpython/tree/dataclasses-inline-unwrap
Conversationhttps://github.com/python/cpython/pull/156841
Commits6 (6)https://github.com/python/cpython/pull/156841/commits
Checkshttps://github.com/python/cpython/pull/156841/checks
Files changedhttps://github.com/python/cpython/pull/156841/files
gh-154675: Avoid importing inspect when creating a slotted dataclasshttps://github.com/python/cpython/pull/156841#top
aiskhttps://github.com/aisk
python:mainhttps://github.com/python/cpython/tree/main
aisk:dataclasses-inline-unwraphttps://github.com/aisk/cpython/tree/dataclasses-inline-unwrap
https://github.com/aisk
aiskhttps://github.com/aisk
Sep 2, 2026https://github.com/python/cpython/pull/156841#issue-5326703870
Please reload this pagehttps://github.com/python/cpython/pull/156841
typinghttps://github.com/python/cpython/blob/2271fbb369a78fcd3ac00c526ca6711140144e43/Lib/typing.py#L2494-L2499
annotationlibhttps://github.com/python/cpython/blob/2271fbb369a78fcd3ac00c526ca6711140144e43/Lib/annotationlib.py#L1042-L1059
Improve import time of various stdlib modules #154675https://github.com/python/cpython/issues/154675
Please reload this pagehttps://github.com/python/cpython/pull/156841
https://github.com/aisk
pythongh-154675https://github.com/python/cpython/issues/154675
: Avoid importing inspect when creating a slotted data…https://github.com/python/cpython/pull/156841/commits/d86a8efb30e5c9c58054948c96037bcc4dc9af66
d86a8efhttps://github.com/python/cpython/pull/156841/commits/d86a8efb30e5c9c58054948c96037bcc4dc9af66
https://github.com/aisk
aiskhttps://github.com/aisk
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/d7f107a767e5768da4c7f9f5c4e112b12be101b1/.github/CODEOWNERS#L417
September 2, 2026 16:48https://github.com/python/cpython/pull/156841#event-30430954220
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 2, 2026 https://github.com/python/cpython/pull/156841#ref-issue-4974527438
Improve import time of various stdlib modules #154675 https://github.com/python/cpython/issues/154675
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 2, 2026https://github.com/python/cpython/pull/156841#event-30430963482
https://github.com/aisk
Use ensure_lazy_imports in the regression testhttps://github.com/python/cpython/pull/156841/commits/2b98d017bbd117efb0f67a2e13de072e53a1c747
2b98d01https://github.com/python/cpython/pull/156841/commits/2b98d017bbd117efb0f67a2e13de072e53a1c747
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Sep 9, 2026https://github.com/python/cpython/pull/156841#issuecomment-5601068519
typinghttps://github.com/python/cpython/blob/2271fbb369a78fcd3ac00c526ca6711140144e43/Lib/typing.py#L2494-L2499
annotationlibhttps://github.com/python/cpython/blob/2271fbb369a78fcd3ac00c526ca6711140144e43/Lib/annotationlib.py#L1042-L1059
Please reload this pagehttps://github.com/python/cpython/pull/156841
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
Sep 11, 2026https://github.com/python/cpython/pull/156841#issuecomment-5635762753
Please reload this pagehttps://github.com/python/cpython/pull/156841
aiskhttps://github.com/aisk
September 15, 2026 00:07https://github.com/python/cpython/pull/156841#commits-pushed-0aa2387
https://github.com/aisk
Create the slotted class before generating methodshttps://github.com/python/cpython/pull/156841/commits/0aa2387c44c17ce78ee5ba092f5cfb21adad4997
0aa2387https://github.com/python/cpython/pull/156841/commits/0aa2387c44c17ce78ee5ba092f5cfb21adad4997
https://github.com/aisk
Update NEWS entryhttps://github.com/python/cpython/pull/156841/commits/436ffbc0e3677a136400a078dc3386acf9d9a746
436ffbchttps://github.com/python/cpython/pull/156841/commits/436ffbc0e3677a136400a078dc3386acf9d9a746
https://github.com/aisk
aiskhttps://github.com/aisk
Sep 14, 2026https://github.com/python/cpython/pull/156841#issuecomment-5666264607
@DavidCEllishttps://github.com/DavidCEllis
Please reload this pagehttps://github.com/python/cpython/pull/156841
https://github.com/aisk
Merge branch 'main' into dataclasses-inline-unwraphttps://github.com/python/cpython/pull/156841/commits/f0ca027a6a0956b63aea8695b1eeaf245e73160f
f0ca027https://github.com/python/cpython/pull/156841/commits/f0ca027a6a0956b63aea8695b1eeaf245e73160f
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Sep 15, 2026https://github.com/python/cpython/pull/156841#issuecomment-5687924117
Please reload this pagehttps://github.com/python/cpython/pull/156841
https://github.com/aisk
Add a regression testhttps://github.com/python/cpython/pull/156841/commits/a0ccb7951b8a76124d26edbdce4ca1066bb28fd4
a0ccb79https://github.com/python/cpython/pull/156841/commits/a0ccb7951b8a76124d26edbdce4ca1066bb28fd4
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
Sep 18, 2026 https://github.com/python/cpython/pull/156841#ref-issue-5424547633
Add public functions to dataclasses to correctly identify methods and features #157314 https://github.com/python/cpython/issues/157314
https://github.com/ambv
ambvhttps://github.com/ambv
Oct 20, 2026 https://github.com/python/cpython/pull/156841#ref-pullrequest-4246038300
gh-154675: Improve import performance of tkinter library with lazy imports #148409 https://github.com/python/cpython/pull/148409
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156841
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/156841
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/156841
https://github.com/aisk
https://github.com/eendebakpt
https://github.com/DavidCEllis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.