| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:39c22f8f-7830-34b9-154d-302ac21c2e56 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E060:26ECEB:432FA04:5553672:6B021742 |
| html-safe-nonce | 219d06b4ab44bbea1677a4be5f910195ed55cbc63b19349613b4628aa6adc8e4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDYwOjI2RUNFQjo0MzJGQTA0OjU1NTM2NzI6NkIwMjE3NDIiLCJ2aXNpdG9yX2lkIjoiOTE0MDk1MjQwMjIxODg1MDExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6dcd294933aec2be1ff6862308324e5360e776ac0464de60ad957b88f2e61b2a |
| hovercard-subject-tag | pull_request:4420779108 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/156813/files |
| twitter:image | https://avatars.githubusercontent.com/u/23011166?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/23011166?s=400&v=4 |
| og:image:alt | Comment.writexml raises ValueError for -- in comment data (illegal inside an XML comment) but not for data ending in -, which fuses with the closing --> into ---> — so minidom silently serial... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/156813/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156813%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156813%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/156813/files |
| Reload | https://github.com/python/cpython/pull/156813/files |
| Reload | https://github.com/python/cpython/pull/156813/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| tonghuaroot | https://github.com/tonghuaroot |
| python:main | https://github.com/python/cpython/tree/main |
| tonghuaroot:gh-156812-minidom-comment-hyphen | https://github.com/tonghuaroot/cpython/tree/gh-156812-minidom-comment-hyphen |
|
Conversation
0
| https://github.com/python/cpython/pull/156813 |
|
Commits
1
| https://github.com/python/cpython/pull/156813/commits |
|
Checks
52
| https://github.com/python/cpython/pull/156813/checks |
|
Files changed
3
| https://github.com/python/cpython/pull/156813/files |
|
gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom comment
| https://github.com/python/cpython/pull/156813/files#top |
|
Show all changes
1 commit
| https://github.com/python/cpython/pull/156813/files |
|
b1a6902
gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom …
tonghuaroot Sep 2, 2026
| https://github.com/python/cpython/pull/156813/commits/b1a6902566a54d8b418280977387b9a1db5fead6 |
|
Clear filters
| https://github.com/python/cpython/pull/156813/files |
| Please reload this page | https://github.com/python/cpython/pull/156813/files |
| Please reload this page | https://github.com/python/cpython/pull/156813/files |
|
test_minidom.py
| https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003 |
|
minidom.py
| https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42 |
|
2026-09-02-17-35-20.gh-issue-156812.mdCmt1.rst
| https://github.com/python/cpython/pull/156813/files#diff-ea467093b2b6c17c7b204344baf3a1ffde3a19f855734336d2463ce277d8521c |
| Lib/test/test_minidom.py | https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003 |
|
View file
| https://github.com/python/cpython/blob/b1a6902566a54d8b418280977387b9a1db5fead6/Lib/test/test_minidom.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156813/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003 |
|
| https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003 |
| Lib/xml/dom/minidom.py | https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42 |
|
View file
| https://github.com/python/cpython/blob/b1a6902566a54d8b418280977387b9a1db5fead6/Lib/xml/dom/minidom.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156813/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42 |
|
| https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42 |
| Misc/NEWS.d/next/Library/2026-09-02-17-35-20.gh-issue-156812.mdCmt1.rst | https://github.com/python/cpython/pull/156813/files#diff-ea467093b2b6c17c7b204344baf3a1ffde3a19f855734336d2463ce277d8521c |
|
View file
| https://github.com/python/cpython/blob/b1a6902566a54d8b418280977387b9a1db5fead6/Misc/NEWS.d/next/Library/2026-09-02-17-35-20.gh-issue-156812.mdCmt1.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156813/{{ revealButtonHref }} |
| Please reload this page | https://github.com/python/cpython/pull/156813/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |