René's URL Explorer Experiment


Title: gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom comment by tonghuaroot · Pull Request #156813 · python/cpython · GitHub

Open Graph Title: gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom comment by tonghuaroot · Pull Request #156813 · python/cpython

X Title: gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom comment by tonghuaroot · Pull Request #156813 · python/cpython

Description: Comment.writexml raises ValueError for -- in comment data (illegal inside an XML comment) but not for data ending in -, which fuses with the closing --> into ---> — so minidom silently serialized a comment it could not reparse. Extend the existing guard to also reject a trailing -. The added test fails without the fix; test_minidom passes. Issue: gh-156812

Open Graph Description: Comment.writexml raises ValueError for -- in comment data (illegal inside an XML comment) but not for data ending in -, which fuses with the closing --> into ---> — so minidom silently serial...

X Description: Comment.writexml raises ValueError for -- in comment data (illegal inside an XML comment) but not for data ending in -, which fuses with the closing --> into ---> — so minidom silentl...

Opengraph URL: https://github.com/python/cpython/pull/156813

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:39c22f8f-7830-34b9-154d-302ac21c2e56
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE060:26ECEB:432FA04:5553672:6B021742
html-safe-nonce219d06b4ab44bbea1677a4be5f910195ed55cbc63b19349613b4628aa6adc8e4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDYwOjI2RUNFQjo0MzJGQTA0OjU1NTM2NzI6NkIwMjE3NDIiLCJ2aXNpdG9yX2lkIjoiOTE0MDk1MjQwMjIxODg1MDExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6dcd294933aec2be1ff6862308324e5360e776ac0464de60ad957b88f2e61b2a
hovercard-subject-tagpull_request:4420779108
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156813/files
twitter:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
og:image:altComment.writexml raises ValueError for -- in comment data (illegal inside an XML comment) but not for data ending in -, which fuses with the closing --> into ---> — so minidom silently serial...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156813/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156813%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156813%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156813/files
Reloadhttps://github.com/python/cpython/pull/156813/files
Reloadhttps://github.com/python/cpython/pull/156813/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tonghuaroothttps://github.com/tonghuaroot
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:gh-156812-minidom-comment-hyphenhttps://github.com/tonghuaroot/cpython/tree/gh-156812-minidom-comment-hyphen
Conversation 0 https://github.com/python/cpython/pull/156813
Commits 1 https://github.com/python/cpython/pull/156813/commits
Checks 52 https://github.com/python/cpython/pull/156813/checks
Files changed 3 https://github.com/python/cpython/pull/156813/files
gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom comment https://github.com/python/cpython/pull/156813/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/156813/files
b1a6902 gh-156812: Reject a trailing '-' when serializing an xml.dom.minidom … tonghuaroot Sep 2, 2026 https://github.com/python/cpython/pull/156813/commits/b1a6902566a54d8b418280977387b9a1db5fead6
Clear filters https://github.com/python/cpython/pull/156813/files
Please reload this pagehttps://github.com/python/cpython/pull/156813/files
Please reload this pagehttps://github.com/python/cpython/pull/156813/files
test_minidom.py https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003
minidom.py https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42
2026-09-02-17-35-20.gh-issue-156812.mdCmt1.rst https://github.com/python/cpython/pull/156813/files#diff-ea467093b2b6c17c7b204344baf3a1ffde3a19f855734336d2463ce277d8521c
Lib/test/test_minidom.pyhttps://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003
View file https://github.com/python/cpython/blob/b1a6902566a54d8b418280977387b9a1db5fead6/Lib/test/test_minidom.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156813/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003
https://github.com/python/cpython/pull/156813/files#diff-f73c8c572aa3351079f3e594b5c0f1c34e20e9e1e7dd8f5474cbe745dfd9f003
Lib/xml/dom/minidom.pyhttps://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42
View file https://github.com/python/cpython/blob/b1a6902566a54d8b418280977387b9a1db5fead6/Lib/xml/dom/minidom.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156813/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42
https://github.com/python/cpython/pull/156813/files#diff-365c30899ded02b18a2d8f92de47af6ca213eefe7883064c8723598da600ea42
Misc/NEWS.d/next/Library/2026-09-02-17-35-20.gh-issue-156812.mdCmt1.rsthttps://github.com/python/cpython/pull/156813/files#diff-ea467093b2b6c17c7b204344baf3a1ffde3a19f855734336d2463ce277d8521c
View file https://github.com/python/cpython/blob/b1a6902566a54d8b418280977387b9a1db5fead6/Misc/NEWS.d/next/Library/2026-09-02-17-35-20.gh-issue-156812.mdCmt1.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156813/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/156813/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.