René's URL Explorer Experiment


Title: gh-156777: Optimize import overhead in the logging package by brittanyrey · Pull Request #156778 · python/cpython · GitHub

Open Graph Title: gh-156777: Optimize import overhead in the logging package by brittanyrey · Pull Request #156778 · python/cpython

X Title: gh-156777: Optimize import overhead in the logging package by brittanyrey · Pull Request #156778 · python/cpython

Description: summary Lift the function-level imports in logging/handlers.py and logging/config.py to module scope as lazy imports, and mark other cold-path imports lazy. Imports reachable from interpreter finalization stay eager and are now commented as such. The Windows-only (_winapi, winreg) and optional third-party (win32evtlogutil) imports stay function-level on purpose: as module-level lazy imports they would break inspect.getmembers() and pydoc on non-Windows. perf Import before after delta import logging.config 24.91 ms 18.11 ms −27.3% import logging.handlers 21.97 ms 17.79 ms −19.0% import logging 17.10 ms 17.11 ms neutral Issue: gh-156777

Open Graph Description: summary Lift the function-level imports in logging/handlers.py and logging/config.py to module scope as lazy imports, and mark other cold-path imports lazy. Imports reachable from interpreter fina...

X Description: summary Lift the function-level imports in logging/handlers.py and logging/config.py to module scope as lazy imports, and mark other cold-path imports lazy. Imports reachable from interpreter fina...

Opengraph URL: https://github.com/python/cpython/pull/156778

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7f32099e-db60-2cd0-414d-ff29745d8474
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEC4:1CCECA:17622B2:1F0E2DF:6B0217B6
html-safe-nonced9b3ee6b60f52d2d2ab6e9c937b676ab5caa5362fd762116d9f0784a3f8b0c38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUM0OjFDQ0VDQToxNzYyMkIyOjFGMEUyREY6NkIwMjE3QjYiLCJ2aXNpdG9yX2lkIjoiNzMxNTcwMzI2MjYyNjMyMjM1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8380fbe084dd0d2b210fbef617989d8260c615bd406824f22d99407dac7c4ad1
hovercard-subject-tagpull_request:4413095353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156778/files
twitter:imagehttps://avatars.githubusercontent.com/u/5497668?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5497668?s=400&v=4
og:image:altsummary Lift the function-level imports in logging/handlers.py and logging/config.py to module scope as lazy imports, and mark other cold-path imports lazy. Imports reachable from interpreter fina...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156778/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156778%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156778%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156778/files
Reloadhttps://github.com/python/cpython/pull/156778/files
Reloadhttps://github.com/python/cpython/pull/156778/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brittanyreyhttps://github.com/brittanyrey
python:mainhttps://github.com/python/cpython/tree/main
brittanyrey:b-perf-logging-lazy-importshttps://github.com/brittanyrey/cpython/tree/b-perf-logging-lazy-imports
Conversation 21 https://github.com/python/cpython/pull/156778
Commits 10 https://github.com/python/cpython/pull/156778/commits
Checks 52 https://github.com/python/cpython/pull/156778/checks
Files changed https://github.com/python/cpython/pull/156778/files
Please reload this pagehttps://github.com/python/cpython/pull/156778/files
gh-156777: Optimize import overhead in the logging package https://github.com/python/cpython/pull/156778/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/156778/files
7805580 gh-999999: Defer rarely-used imports in the logging package brittanyrey Aug 31, 2026 https://github.com/python/cpython/pull/156778/commits/7805580ede5e4811e10b91545e09bf9aed87e36d
61de034 Update blurb + clean up comments brittanyrey Sep 1, 2026 https://github.com/python/cpython/pull/156778/commits/61de034c7321c8ccfcf488dbda25410ba15e782a
29608ca Address comments on PR brittanyrey Sep 1, 2026 https://github.com/python/cpython/pull/156778/commits/29608cae2feab18e3c270d95107dd3460c02cfb3
d73d223 Sort imports isort-style; bind logging.handlers without reifying it brittanyrey Sep 1, 2026 https://github.com/python/cpython/pull/156778/commits/d73d223a3e524a381f1ed054cae12800c737af8d
bafee5d Address review: keep optional imports nested, keep shutdown ones eager brittanyrey Sep 23, 2026 https://github.com/python/cpython/pull/156778/commits/bafee5d17ff41ee2c43f42a187288db8c9870c4c
c42e9d7 Resolve SocketHandler's imports at construction, not eagerly brittanyrey Sep 23, 2026 https://github.com/python/cpython/pull/156778/commits/c42e9d77a29c365754884cb53065de3eeca455d7
f68adec Keep logging.handlers eager in config.py brittanyrey Sep 23, 2026 https://github.com/python/cpython/pull/156778/commits/f68adec6bd150fdea23a0a19e0a4f4cf5753edff
a5838b5 Defer logging.handlers with a plain lazy import in config.py brittanyrey Sep 23, 2026 https://github.com/python/cpython/pull/156778/commits/a5838b5dd3e85e4d1dd32dc3f229e5d4534d93ae
e6a0ef2 Merge branch 'main' into b-perf-logging-lazy-imports hugovk Sep 24, 2026 https://github.com/python/cpython/pull/156778/commits/e6a0ef2bd31f23a8eb188fc397a8b435da8c3911
1888e03 Keep copy eager and note why the dotted lazy import matters brittanyrey Sep 26, 2026 https://github.com/python/cpython/pull/156778/commits/1888e035ee48431cbd51f4c98a3f4b2bfb55034f
Clear filters https://github.com/python/cpython/pull/156778/files
Please reload this pagehttps://github.com/python/cpython/pull/156778/files
Please reload this pagehttps://github.com/python/cpython/pull/156778/files
__init__.py https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
config.py https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
handlers.py https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
test_logging.py https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
2026-08-31-08-20-00.gh-issue-156777.La7yLg.rst https://github.com/python/cpython/pull/156778/files#diff-78618f7c87b699f1a9f6ec0ee7c2b0ba9290012b020da21ff88ba8780b4c4c13
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L536
Lib/logging/__init__.pyhttps://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
View file https://github.com/python/cpython/blob/1888e035ee48431cbd51f4c98a3f4b2bfb55034f/Lib/logging/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156778/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/156778/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L536
Lib/logging/config.pyhttps://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
View file https://github.com/python/cpython/blob/1888e035ee48431cbd51f4c98a3f4b2bfb55034f/Lib/logging/config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156778/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
Please reload this pagehttps://github.com/python/cpython/pull/156778/files
Please reload this pagehttps://github.com/python/cpython/pull/156778/files
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/pull/156778/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L536
Lib/logging/handlers.pyhttps://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
View file https://github.com/python/cpython/blob/1888e035ee48431cbd51f4c98a3f4b2bfb55034f/Lib/logging/handlers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156778/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/156778/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L537
Lib/test/test_logging.pyhttps://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
View file https://github.com/python/cpython/blob/1888e035ee48431cbd51f4c98a3f4b2bfb55034f/Lib/test/test_logging.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156778/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/156778/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
Misc/NEWS.d/next/Library/2026-08-31-08-20-00.gh-issue-156777.La7yLg.rsthttps://github.com/python/cpython/pull/156778/files#diff-78618f7c87b699f1a9f6ec0ee7c2b0ba9290012b020da21ff88ba8780b4c4c13
View file https://github.com/python/cpython/blob/1888e035ee48431cbd51f4c98a3f4b2bfb55034f/Misc/NEWS.d/next/Library/2026-08-31-08-20-00.gh-issue-156777.La7yLg.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156778/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/156778/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.