René's URL Explorer Experiment


Title: gh-150922: Fix test_cmd libedit assertion in test_bang_completion_without_do_shell by iamsharduld · Pull Request #156623 · python/cpython · GitHub

Open Graph Title: gh-150922: Fix test_cmd libedit assertion in test_bang_completion_without_do_shell by iamsharduld · Pull Request #156623 · python/cpython

X Title: gh-150922: Fix test_cmd libedit assertion in test_bang_completion_without_do_shell by iamsharduld · Pull Request #156623 · python/cpython

Description: Fixes #150922 test_bang_completion_without_do_shell asserted that the raw PTY transcript contains the literal bytes b'hello' after tab-completing !h. That only holds for GNU readline, which retypes the whole completed word. libedit instead redraws via a cursor-forward escape sequence and only re-emits the untyped suffix (e.g. \x1b[9Cello), so the assertion fails on libedit-linked builds (default on macOS/BSD, and used on some Linux distros) even though completion works correctly. This switches the assertion to check for b'ello', the suffix common to both backends' output, so the test no longer depends on backend-specific echo/redraw formatting. The existing tab completion success assertion right below it still verifies the functional outcome of the completion. Test-only change; no behavior change in Lib/cmd.py, so no Misc/NEWS.d entry per the devguide's test-change exemption. Issue: gh-150922

Open Graph Description: Fixes #150922 test_bang_completion_without_do_shell asserted that the raw PTY transcript contains the literal bytes b'hello' after tab-completing !h<TAB>. That only holds for GNU read...

X Description: Fixes #150922 test_bang_completion_without_do_shell asserted that the raw PTY transcript contains the literal bytes b&#39;hello&#39; after tab-completing !h&lt;TAB&gt;. That only ho...

Opengraph URL: https://github.com/python/cpython/pull/156623

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:77dcc10f-e396-efe8-4413-feef2c737961
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB370:EA06E:3F4F6F0:50640F1:6B01FC34
html-safe-nonce268662fd29173ed2a5153e3bb4c7e81f1f4be8c4f3806f5d408e6c08445289c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzcwOkVBMDZFOjNGNEY2RjA6NTA2NDBGMTo2QjAxRkMzNCIsInZpc2l0b3JfaWQiOiI4NTgzODQ2MjI0MjUwMTQxNzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace07807a7fa2098c41600f1a606a6410eb3d5a0f813ab778c193949ff3bd76de6
hovercard-subject-tagpull_request:4394588154
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156623/files
twitter:imagehttps://avatars.githubusercontent.com/u/8417988?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8417988?s=400&v=4
og:image:altFixes #150922 test_bang_completion_without_do_shell asserted that the raw PTY transcript contains the literal bytes b'hello' after tab-completing !h<TAB>. That only holds for GNU read...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156623/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156623%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156623%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156623/files
Reloadhttps://github.com/python/cpython/pull/156623/files
Reloadhttps://github.com/python/cpython/pull/156623/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
iamsharduld:gh-150922-libedit-test-cmdhttps://github.com/iamsharduld/cpython/tree/gh-150922-libedit-test-cmd
Conversation 5 https://github.com/python/cpython/pull/156623
Commits 1 https://github.com/python/cpython/pull/156623/commits
Checks 68 https://github.com/python/cpython/pull/156623/checks
Files changed https://github.com/python/cpython/pull/156623/files
Please reload this pagehttps://github.com/python/cpython/pull/156623/files
gh-150922: Fix test_cmd libedit assertion in test_bang_completion_without_do_shell https://github.com/python/cpython/pull/156623/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/156623/files
6712528 gh-150922: Fix test_cmd libedit assertion in test_bang_completion_wit… iamsharduld Aug 30, 2026 https://github.com/python/cpython/pull/156623/commits/67125285e34e0c050a9810b9e4a0bbd9e2273cec
Clear filters https://github.com/python/cpython/pull/156623/files
Please reload this pagehttps://github.com/python/cpython/pull/156623/files
Please reload this pagehttps://github.com/python/cpython/pull/156623/files
Lib/test/test_cmd.pyhttps://github.com/python/cpython/pull/156623/files#diff-0fd9be80a8c07a0985d64c97fa392e4dea76d3ddd91fd71e0f87a7e89fe82833
View file https://github.com/iamsharduld/cpython/blob/67125285e34e0c050a9810b9e4a0bbd9e2273cec/Lib/test/test_cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156623/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156623/files#diff-0fd9be80a8c07a0985d64c97fa392e4dea76d3ddd91fd71e0f87a7e89fe82833
https://github.com/python/cpython/pull/156623/files#diff-0fd9be80a8c07a0985d64c97fa392e4dea76d3ddd91fd71e0f87a7e89fe82833
Please reload this pagehttps://github.com/python/cpython/pull/156623/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.