René's URL Explorer Experiment


Title: gh-156537: Optimize codec.decode by inlining the per-character write in CJK decoders by brittanyrey · Pull Request #156538 · python/cpython · GitHub

Open Graph Title: gh-156537: Optimize codec.decode by inlining the per-character write in CJK decoders by brittanyrey · Pull Request #156538 · python/cpython

X Title: gh-156537: Optimize codec.decode by inlining the per-character write in CJK decoders by brittanyrey · Pull Request #156538 · python/cpython

Description: Every CJK decoder emits output through OUTCHAR(), which called the exported _PyUnicodeWriter_WriteChar(). Since the codecs are shared extension modules, that's a cross boundary call to the exported function for each output character. Swapping to the _PyUnicodeWriter_WriteCharInline() removes the overhead of crossing the boundary speeding up decoding. The single macro applies to all of the codec modules. Benchmark main PR decode 1.8MB shift_jis 6.87 ms 2.55 ms: 2.70x faster decode 1.8MB euc_kr 6.34 ms 2.50 ms: 2.54x faster decode 1.8MB euc_jp 6.36 ms 2.55 ms: 2.49x faster decode 1.8MB big5 6.27 ms 2.56 ms: 2.45x faster decode 1kB euc_jp 3.97 us 1.82 us: 2.18x faster decode 1.8MB euc_jp kana 3.86 ms 3.07 ms: 1.26x faster Benchmark script """CJK decoder throughput (Modules/cjkcodecs).""" import pyperf ASCII = ('abc' * 30 + '\n') KANA = ('あいう' * 10 + '\n') def dec(d, e): d.decode(e) if __name__ == "__main__": r = pyperf.Runner() for enc in ("euc_jp", "shift_jis", "big5", "euc_kr"): r.bench_func("decode 1.8MB %s" % enc, dec, (ASCII * 20000).encode(enc), enc) r.bench_func("decode 1.8MB euc_jp kana", dec, (KANA * 20000).encode("euc_jp"), "euc_jp") r.bench_func("decode 1kB euc_jp", dec, (ASCII * 11).encode("euc_jp"), "euc_jp") Issue: gh-156537

Open Graph Description: Every CJK decoder emits output through OUTCHAR(), which called the exported _PyUnicodeWriter_WriteChar(). Since the codecs are shared extension modules, that's a cross boundary call to the exp...

X Description: Every CJK decoder emits output through OUTCHAR(), which called the exported _PyUnicodeWriter_WriteChar(). Since the codecs are shared extension modules, that's a cross boundary call to the...

Opengraph URL: https://github.com/python/cpython/pull/156538

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:74e4ed63-b939-4085-238a-3b142758be50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA320:36A3E:316B562:41EE1CA:6B01F282
html-safe-noncec2f1b5efd50f00492cfeb3e6ee13762a73ef9c8701063defbeea0c06b1dcd20b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzIwOjM2QTNFOjMxNkI1NjI6NDFFRTFDQTo2QjAxRjI4MiIsInZpc2l0b3JfaWQiOiI4NjI0NTEwNjg1ODIzNTk2ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97cb2e5717bb5f433a94a4a8283f60149c12acd0df3a04e024c4847e2dac2133
hovercard-subject-tagpull_request:4388064385
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156538/files
twitter:imagehttps://avatars.githubusercontent.com/u/5497668?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5497668?s=400&v=4
og:image:altEvery CJK decoder emits output through OUTCHAR(), which called the exported _PyUnicodeWriter_WriteChar(). Since the codecs are shared extension modules, that's a cross boundary call to the exp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156538/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156538%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156538%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156538/files
Reloadhttps://github.com/python/cpython/pull/156538/files
Reloadhttps://github.com/python/cpython/pull/156538/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
corona10https://github.com/corona10
python:mainhttps://github.com/python/cpython/tree/main
brittanyrey:perf-cjk-inline-outcharhttps://github.com/brittanyrey/cpython/tree/perf-cjk-inline-outchar
Conversation 1 https://github.com/python/cpython/pull/156538
Commits 4 https://github.com/python/cpython/pull/156538/commits
Checks 56 https://github.com/python/cpython/pull/156538/checks
Files changed https://github.com/python/cpython/pull/156538/files
Please reload this pagehttps://github.com/python/cpython/pull/156538/files
gh-156537: Optimize codec.decode by inlining the per-character write in CJK decoders https://github.com/python/cpython/pull/156538/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/156538/files
0bbb0f7 Inline the per-character write in the CJK decoders brittanyrey Aug 26, 2026 https://github.com/python/cpython/pull/156538/commits/0bbb0f7b299673e5af9f5a95979896d23192bef8
6a35e93 📜🤖 Added by blurb_it. blurb-it[bot] Aug 28, 2026 https://github.com/python/cpython/pull/156538/commits/6a35e934372829df68bb789c59270ed2cedb868f
94dc90c The comment is probably not needed brittanyrey Aug 28, 2026 https://github.com/python/cpython/pull/156538/commits/94dc90cc84ae51a0f52f390b22a3d42cb4d5c9ab
0e120a8 Delete Misc/NEWS.d/next/Library/2026-08-28-21-08-58.gh-issue-156537.a… corona10 Aug 29, 2026 https://github.com/python/cpython/pull/156538/commits/0e120a81c659713eca7a5898c6a491c5f6b896c1
Clear filters https://github.com/python/cpython/pull/156538/files
Please reload this pagehttps://github.com/python/cpython/pull/156538/files
Please reload this pagehttps://github.com/python/cpython/pull/156538/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L401
Modules/cjkcodecs/cjkcodecs.hhttps://github.com/python/cpython/pull/156538/files#diff-15c123a721b956855846cc0e5919a81f89e244bffbba326b33f8d3e08d82ba43
View file https://github.com/brittanyrey/cpython/blob/0e120a81c659713eca7a5898c6a491c5f6b896c1/Modules/cjkcodecs/cjkcodecs.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156538/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156538/files#diff-15c123a721b956855846cc0e5919a81f89e244bffbba326b33f8d3e08d82ba43
https://github.com/python/cpython/pull/156538/files#diff-15c123a721b956855846cc0e5919a81f89e244bffbba326b33f8d3e08d82ba43
Please reload this pagehttps://github.com/python/cpython/pull/156538/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.