René's URL Explorer Experiment


Title: gh-153569: centralize formatted-string state and source spans by pablogsal · Pull Request #156484 · python/cpython · GitHub

Open Graph Title: gh-153569: centralize formatted-string state and source spans by pablogsal · Pull Request #156484 · python/cpython

X Title: gh-153569: centralize formatted-string state and source spans by pablogsal · Pull Request #156484 · python/cpython

Description: Store formatted-string expressions and comments as source spans. Keep active f/t-string frames with explicit transitions between text, expressions, and format specifications, and derive token locations and failure status from scanner state. This PR just moves code around and removes the old state. Part of gh-153569. First PR in the stack for gh-153569. Next: #156654.

Open Graph Description: Store formatted-string expressions and comments as source spans. Keep active f/t-string frames with explicit transitions between text, expressions, and format specifications, and derive token locat...

X Description: Store formatted-string expressions and comments as source spans. Keep active f/t-string frames with explicit transitions between text, expressions, and format specifications, and derive token locat...

Opengraph URL: https://github.com/python/cpython/pull/156484

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1ae75525-757f-e4eb-2ac1-902f34c00021
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF00:21AC3F:4357E3F:552E37D:6B020A76
html-safe-nonce9f232ff3f41a46d518c7927a43fe8a5d2e2e914df4cdc42a47c380cd7f57ffba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjAwOjIxQUMzRjo0MzU3RTNGOjU1MkUzN0Q6NkIwMjBBNzYiLCJ2aXNpdG9yX2lkIjoiMTMwNDA4OTk2Mjc4NTkzMzk0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2fdadfb5b38e1e3c841b606e3fd40a6039bf2b02e9a762ebb27081ca2bc3e358
hovercard-subject-tagpull_request:4378023408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156484/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altStore formatted-string expressions and comments as source spans. Keep active f/t-string frames with explicit transitions between text, expressions, and format specifications, and derive token locat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156484/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156484%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156484%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156484/files
Reloadhttps://github.com/python/cpython/pull/156484/files
Reloadhttps://github.com/python/cpython/pull/156484/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:gh-153569-tokenizer-validation-tools-cleanhttps://github.com/pablogsal/cpython/tree/gh-153569-tokenizer-validation-tools-clean
Conversation 3 https://github.com/python/cpython/pull/156484
Commits 4 https://github.com/python/cpython/pull/156484/commits
Checks 51 https://github.com/python/cpython/pull/156484/checks
Files changed https://github.com/python/cpython/pull/156484/files
Please reload this pagehttps://github.com/python/cpython/pull/156484/files
gh-153569: centralize formatted-string state and source spans https://github.com/python/cpython/pull/156484/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/156484/files
55da4dd gh-153569: store formatted-string text as source spans pablogsal Aug 30, 2026 https://github.com/python/cpython/pull/156484/commits/55da4dd79fc9c8a429ed15104c6ff0dc413fbd19
4c8ba41 gh-153569: derive tokenizer locations and failures from scanner state pablogsal Sep 6, 2026 https://github.com/python/cpython/pull/156484/commits/4c8ba41af8620b469da49c744dce08fbcf4b7851
9e645ae gh-153569: keep active formatted-string frames pablogsal Sep 6, 2026 https://github.com/python/cpython/pull/156484/commits/9e645ae4a93090fdc51f1986ca5471322d090e95
c0ee295 gh-153569: centralize formatted-string transitions pablogsal Sep 6, 2026 https://github.com/python/cpython/pull/156484/commits/c0ee2951076ed363dbdeaebba283b4d093b97086
Clear filters https://github.com/python/cpython/pull/156484/files
Please reload this pagehttps://github.com/python/cpython/pull/156484/files
Please reload this pagehttps://github.com/python/cpython/pull/156484/files
test_fstring.py https://github.com/python/cpython/pull/156484/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
test_syntax.py https://github.com/python/cpython/pull/156484/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
test_tokenize.py https://github.com/python/cpython/pull/156484/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
test_tstring.py https://github.com/python/cpython/pull/156484/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
action_helpers.c https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
buffer.c https://github.com/python/cpython/pull/156484/files#diff-b4dbec3be58c399219891041d458bb2d24e9fd7d283e03ed09027e8484a56c32
buffer.h https://github.com/python/cpython/pull/156484/files#diff-19981875a12620209e5d2bd5f421e7dd5bcd5d2f9d880255b2f3ed65f242f463
lexer.c https://github.com/python/cpython/pull/156484/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
lexer.h https://github.com/python/cpython/pull/156484/files#diff-4c8d59cfb542d6b3e63561140f56a78e991cd0b8019f7de332deba771863735b
lexer_internal.h https://github.com/python/cpython/pull/156484/files#diff-8b0f5e75070e787646998b2177e239a0048aa5adce6e2068ad6bbfca1dc46eda
state.c https://github.com/python/cpython/pull/156484/files#diff-d320456c1594700fd4ea3c33fbfc5f7fd74d4fd45fd225354ea8db7135c04045
state.h https://github.com/python/cpython/pull/156484/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
string.c https://github.com/python/cpython/pull/156484/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
pegen.c https://github.com/python/cpython/pull/156484/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7
pegen.h https://github.com/python/cpython/pull/156484/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
pegen_errors.c https://github.com/python/cpython/pull/156484/files#diff-f15d7b3d0bc84baf512dd165bea4e2e1dddb1fe33f836ee08b811621df3260cb
helpers.h https://github.com/python/cpython/pull/156484/files#diff-7f7d9ba2dceb9ccf35b4d482f2d2ffc257e2d04abc4b1062e162d86287595b44
reader.c https://github.com/python/cpython/pull/156484/files#diff-ee1ccf9c461ad2982f27a89c79c7ea2e5868fef86dbd8d8d1d873e1624208590
Python-tokenize.c https://github.com/python/cpython/pull/156484/files#diff-68d96c581022a408dbcf0f48df1126c3a43154ed2dd20b166aa5269ab27f3dcb
Lib/test/test_fstring.pyhttps://github.com/python/cpython/pull/156484/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Lib/test/test_fstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
https://github.com/python/cpython/pull/156484/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
https://github.com/python/cpython/pull/156484/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
Lib/test/test_syntax.pyhttps://github.com/python/cpython/pull/156484/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Lib/test/test_syntax.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/pull/156484/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Lib/test/test_tokenize.pyhttps://github.com/python/cpython/pull/156484/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Lib/test/test_tokenize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
https://github.com/python/cpython/pull/156484/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L349
Lib/test/test_tstring.pyhttps://github.com/python/cpython/pull/156484/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Lib/test/test_tstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/pull/156484/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/pull/156484/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/action_helpers.chttps://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Parser/action_helpers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/156484/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/buffer.chttps://github.com/python/cpython/pull/156484/files#diff-b4dbec3be58c399219891041d458bb2d24e9fd7d283e03ed09027e8484a56c32
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Parser/lexer/buffer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-b4dbec3be58c399219891041d458bb2d24e9fd7d283e03ed09027e8484a56c32
https://github.com/python/cpython/pull/156484/files#diff-b4dbec3be58c399219891041d458bb2d24e9fd7d283e03ed09027e8484a56c32
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/buffer.hhttps://github.com/python/cpython/pull/156484/files#diff-19981875a12620209e5d2bd5f421e7dd5bcd5d2f9d880255b2f3ed65f242f463
View file https://github.com/pablogsal/cpython/blob/c0ee2951076ed363dbdeaebba283b4d093b97086/Parser/lexer/buffer.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156484/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156484/files#diff-19981875a12620209e5d2bd5f421e7dd5bcd5d2f9d880255b2f3ed65f242f463
https://github.com/python/cpython/pull/156484/files#diff-19981875a12620209e5d2bd5f421e7dd5bcd5d2f9d880255b2f3ed65f242f463
Please reload this pagehttps://github.com/python/cpython/pull/156484/files
Please reload this pagehttps://github.com/python/cpython/pull/156484/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.