| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3fac2bbb-ace6-f34a-0557-ee37c7dfa6a3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0F6:21DF5A:29BA9B1:3A3F94D:6A54AE22 |
| html-safe-nonce | ce4cb5114fdc7b57f5401277b3093d2f4c51e287b45a728e8cb19e39031265b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEY2OjIxREY1QToyOUJBOUIxOjNBM0Y5NEQ6NkE1NEFFMjIiLCJ2aXNpdG9yX2lkIjoiMzcyOTQ3ODE4NTQ2NzAzMTA3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8fcfcb6d885bdfeef88261d8a1cd39007ee50988aa3203656375fc1695fa0516 |
| hovercard-subject-tag | pull_request:313228840 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/15641/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8006ab96fe5f8e429b1a3ede3c333084baf42b185c2007672f645e4db8e8178e/python/cpython/pull/15641 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8006ab96fe5f8e429b1a3ede3c333084baf42b185c2007672f645e4db8e8178e/python/cpython/pull/15641 |
| og:image:alt | weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure. Modify the implementation to avoid the closure.
http... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vstinner |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8cfff6384f62259baea531c7f58bc7040f8dd92 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/15641#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15641 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15641 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/15641 |
| Reload | https://github.com/python/cpython/pull/15641 |
| Reload | https://github.com/python/cpython/pull/15641 |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| vstinner | https://github.com/vstinner |
| python:master | https://github.com/python/cpython/tree/master |
| Conversation | https://github.com/python/cpython/pull/15641 |
| Commits2 (2) | https://github.com/python/cpython/pull/15641/commits |
| Checks | https://github.com/python/cpython/pull/15641/checks |
| Files changed | https://github.com/python/cpython/pull/15641/files |
| bpo-38006: Avoid closure in weakref.WeakValueDictionary | https://github.com/python/cpython/pull/15641#top |
| vstinner | https://github.com/vstinner |
| python:master | https://github.com/python/cpython/tree/master |
|
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Sep 2, 2019 | https://github.com/python/cpython/pull/15641#issue-488145864 |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://bugs.python.org/issue38006 | https://bugs.python.org/issue38006 |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
|
| https://github.com/vstinner |
| bpo-38006 | https://bugs.python.org/issue?@action=redirect&bpo=38006 |
| : Avoid closure in weakref.WeakValueDictionary | https://github.com/python/cpython/pull/15641/commits/36af58ae540892236a0458889e6e8db72e56f908 |
| 36af58a | https://github.com/python/cpython/pull/15641/commits/36af58ae540892236a0458889e6e8db72e56f908 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Sep 2, 2019 | https://github.com/python/cpython/pull/15641#event-2600840497 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 2, 2019 | https://github.com/python/cpython/pull/15641#event-2600840555 |
|
| https://github.com/vstinner |
| Add an unit test | https://github.com/python/cpython/pull/15641/commits/1c87046eb902efc00abe1c9be330c1254840a6dc |
| 1c87046 | https://github.com/python/cpython/pull/15641/commits/1c87046eb902efc00abe1c9be330c1254840a6dc |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Sep 2, 2019 | https://github.com/python/cpython/pull/15641#event-2600915490 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
|
Sep 2, 2019
| https://github.com/python/cpython/pull/15641#pullrequestreview-282559446 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15641/files/1c87046eb902efc00abe1c9be330c1254840a6dc |
| tiran | https://github.com/tiran |
| https://github.com/python/cpython/pull/15641#pullrequestreview-282559446 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 2, 2019 | https://github.com/python/cpython/pull/15641#event-2600917357 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| a2af05a | https://github.com/python/cpython/commit/a2af05a0d3f0da06b8d432f52efa3ecf29038532 |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#event-2619019197 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| September 9, 2019 14:56 | https://github.com/python/cpython/pull/15641#event-2619019311 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#issuecomment-529515999 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#event-2619019503 |
| miss-islington | https://github.com/miss-islington |
|
Sep 9, 2019
| https://github.com/python/cpython/pull/15641#ref-commit-3762eaa |
|
| https://github.com/vstinner |
|
| https://github.com/miss-islington |
| bpo-38006: Avoid closure in weakref.WeakValueDictionary ( | https://github.com/miss-islington/cpython/commit/3762eaae89da47d5178b6b75a6125b62b200177f |
| pythonGH-15641 | https://github.com/python/cpython/pull/15641 |
| ) | https://github.com/miss-islington/cpython/commit/3762eaae89da47d5178b6b75a6125b62b200177f |
| 3762eaa | https://github.com/miss-islington/cpython/commit/3762eaae89da47d5178b6b75a6125b62b200177f |
| a2af05a | https://github.com/miss-islington/cpython/commit/a2af05a0d3f0da06b8d432f52efa3ecf29038532 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#issuecomment-529516087 |
| GH-15787 | https://github.com/python/cpython/pull/15787 |
| 3.8 branch | https://github.com/python/cpython/tree/3.8 |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#event-2619020361 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#event-2619027314 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#issuecomment-529516872 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#issuecomment-529516892 |
| @vstinner | https://github.com/vstinner |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| vstinner | https://github.com/vstinner |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#event-2619027770 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#issuecomment-529518128 |
| GH-15789 | https://github.com/python/cpython/pull/15789 |
| 3.7 branch | https://github.com/python/cpython/tree/3.7 |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15641#event-2619038003 |
| miss-islington | https://github.com/miss-islington |
|
Sep 9, 2019
| https://github.com/python/cpython/pull/15641#ref-commit-78d15fa |
|
| https://github.com/miss-islington |
|
| https://github.com/vstinner |
| bpo-38006 | https://bugs.python.org/issue?@action=redirect&bpo=38006 |
| : Avoid closure in weakref.WeakValueDictionary ( | https://github.com/python/cpython/commit/78d15faf6c522619098e94be3e7f6d88a9e61123 |
| GH-15641 | https://github.com/python/cpython/pull/15641 |
| ) | https://github.com/python/cpython/commit/78d15faf6c522619098e94be3e7f6d88a9e61123 |
| 78d15fa | https://github.com/python/cpython/commit/78d15faf6c522619098e94be3e7f6d88a9e61123 |
| a2af05a | https://github.com/python/cpython/commit/a2af05a0d3f0da06b8d432f52efa3ecf29038532 |
| vstinner | https://github.com/vstinner |
|
Sep 9, 2019
| https://github.com/python/cpython/pull/15641#ref-commit-2366933 |
|
| https://github.com/vstinner |
| bpo-38006 | https://bugs.python.org/issue?@action=redirect&bpo=38006 |
| : Avoid closure in weakref.WeakValueDictionary ( | https://github.com/python/cpython/commit/23669330b7d0d5ad1a9aac40315ba4c2e765f9dd |
| GH-15641 | https://github.com/python/cpython/pull/15641 |
| ) ( | https://github.com/python/cpython/commit/23669330b7d0d5ad1a9aac40315ba4c2e765f9dd |
| G… | https://github.com/python/cpython/pull/15789 |
| 2366933 | https://github.com/python/cpython/commit/23669330b7d0d5ad1a9aac40315ba4c2e765f9dd |
| …H-15789 | https://github.com/python/cpython/pull/15789 |
| a2af05a | https://github.com/python/cpython/commit/a2af05a0d3f0da06b8d432f52efa3ecf29038532 |
| websurfer5 | https://github.com/websurfer5 |
|
Jul 20, 2020
| https://github.com/python/cpython/pull/15641#ref-commit-81249d5 |
|
| https://github.com/vstinner |
|
| https://github.com/websurfer5 |
| bpo-38006: Avoid closure in weakref.WeakValueDictionary ( | https://github.com/websurfer5/cpython/commit/81249d55066600121cbfd0506b8a62d86533d6d7 |
| pythonGH-15641 | https://github.com/python/cpython/pull/15641 |
| ) | https://github.com/websurfer5/cpython/commit/81249d55066600121cbfd0506b8a62d86533d6d7 |
| 81249d5 | https://github.com/websurfer5/cpython/commit/81249d55066600121cbfd0506b8a62d86533d6d7 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15641 |
|
| https://github.com/tiran |
|
tiran
| https://github.com/tiran |
|
| https://github.com/python/cpython/pull/15641/files/1c87046eb902efc00abe1c9be330c1254840a6dc |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/15641 |
|
| https://github.com/vstinner |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/tiran |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |