René's URL Explorer Experiment


Title: [3.13] gh-155648: Fix IDLE tests that cannot fail (GH-156257) by miss-islington · Pull Request #156317 · python/cpython · GitHub

Open Graph Title: [3.13] gh-155648: Fix IDLE tests that cannot fail (GH-156257) by miss-islington · Pull Request #156317 · python/cpython

X Title: [3.13] gh-155648: Fix IDLE tests that cannot fail (GH-156257) by miss-islington · Pull Request #156317 · python/cpython

Description: test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression using slice instead of startswith. Change line 242 to match. test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now. PR-GH-156260 add real tests. template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing setUpClass and tearDownClass to run and be verified. Remove duplicate and confusing fetch_completions call. (cherry picked from commit ee1da7e) Co-authored-by: Terry Jan Reedy tjreedy@udel.edu Issue: gh-155648

Open Graph Description: test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter ...

X Description: test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter ...

Opengraph URL: https://github.com/python/cpython/pull/156317

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63e94e6d-b0b2-6920-c9d9-6c51f7aafa3e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB956:B1B84:2F24CB7:3BFEA09:6B01FB9D
html-safe-nonce09a411c32f5bc43a84200f450fe3aa2632f73f7ce5305dfcf7fd883d87100963
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTU2OkIxQjg0OjJGMjRDQjc6M0JGRUEwOTo2QjAxRkI5RCIsInZpc2l0b3JfaWQiOiIyMDQ4NTE2ODk1OTQxOTgzMTMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac899ce12e2e88cd0794b39b57888a61125f983e066d28506d61f92311710458d4
hovercard-subject-tagpull_request:4349354675
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156317/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:alttest_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156317/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156317%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156317%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156317/files
Reloadhttps://github.com/python/cpython/pull/156317/files
Reloadhttps://github.com/python/cpython/pull/156317/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terryjreedyhttps://github.com/terryjreedy
python:3.13https://github.com/python/cpython/tree/3.13
miss-islington:backport-ee1da7e-3.13https://github.com/miss-islington/cpython/tree/backport-ee1da7e-3.13
Conversation 0 https://github.com/python/cpython/pull/156317
Commits 1 https://github.com/python/cpython/pull/156317/commits
Checks 40 https://github.com/python/cpython/pull/156317/checks
Files changed https://github.com/python/cpython/pull/156317/files
Please reload this pagehttps://github.com/python/cpython/pull/156317/files
[3.13] gh-155648: Fix IDLE tests that cannot fail (GH-156257) https://github.com/python/cpython/pull/156317/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/156317/files
0973d99 gh-155648: Fix IDLE tests that cannot fail (GH-156257) terryjreedy Aug 24, 2026 https://github.com/python/cpython/pull/156317/commits/0973d9932ada5cd7942944c5667a88f5307fbc34
Clear filters https://github.com/python/cpython/pull/156317/files
Please reload this pagehttps://github.com/python/cpython/pull/156317/files
Please reload this pagehttps://github.com/python/cpython/pull/156317/files
template.py https://github.com/python/cpython/pull/156317/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
test_autocomplete.py https://github.com/python/cpython/pull/156317/files#diff-410abd2830619992f001ce7e0aa731d528ee3d207d1e0453314aafbd561bfe85
test_configdialog.py https://github.com/python/cpython/pull/156317/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
test_editor.py https://github.com/python/cpython/pull/156317/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L211
Lib/idlelib/idle_test/template.pyhttps://github.com/python/cpython/pull/156317/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
View file https://github.com/miss-islington/cpython/blob/0973d9932ada5cd7942944c5667a88f5307fbc34/Lib/idlelib/idle_test/template.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156317/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156317/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
https://github.com/python/cpython/pull/156317/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L211
Lib/idlelib/idle_test/test_autocomplete.pyhttps://github.com/python/cpython/pull/156317/files#diff-410abd2830619992f001ce7e0aa731d528ee3d207d1e0453314aafbd561bfe85
View file https://github.com/miss-islington/cpython/blob/0973d9932ada5cd7942944c5667a88f5307fbc34/Lib/idlelib/idle_test/test_autocomplete.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156317/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156317/files#diff-410abd2830619992f001ce7e0aa731d528ee3d207d1e0453314aafbd561bfe85
https://github.com/python/cpython/pull/156317/files#diff-410abd2830619992f001ce7e0aa731d528ee3d207d1e0453314aafbd561bfe85
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L211
Lib/idlelib/idle_test/test_configdialog.pyhttps://github.com/python/cpython/pull/156317/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
View file https://github.com/miss-islington/cpython/blob/0973d9932ada5cd7942944c5667a88f5307fbc34/Lib/idlelib/idle_test/test_configdialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156317/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156317/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/pull/156317/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L211
Lib/idlelib/idle_test/test_editor.pyhttps://github.com/python/cpython/pull/156317/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
View file https://github.com/miss-islington/cpython/blob/0973d9932ada5cd7942944c5667a88f5307fbc34/Lib/idlelib/idle_test/test_editor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156317/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156317/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
https://github.com/python/cpython/pull/156317/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
Please reload this pagehttps://github.com/python/cpython/pull/156317/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.