René's URL Explorer Experiment


Title: gh-156310: Make the iter() sequence fallback iterator safe in free-threaded build by akx · Pull Request #156311 · python/cpython · GitHub

Open Graph Title: gh-156310: Make the iter() sequence fallback iterator safe in free-threaded build by akx · Pull Request #156311 · python/cpython

X Title: gh-156310: Make the iter() sequence fallback iterator safe in free-threaded build by akx · Pull Request #156311 · python/cpython

Description: Sharing a single PySeqIter between threads could double-DECREF the underlying sequence on the exhaustion path and use the sequence after free while another thread was inside PySequence_GetItem. (See #156310.) This applies the same approach used for listiter, tupleiter and reversed (gh-120608, #120971). it_index is accessed with FT_ATOMIC_LOAD/STORE_SSIZE_RELAXED and -1 becomes the exhaustion sentinel. In the free-threaded build the iterator keeps its strong reference to the sequence until it is deallocated, so no next() call can free the sequence while another thread is using it. __length_hint__, __reduce__ and __setstate__ now key off the index sentinel so that an exhausted iterator behaves the same in both builds, matching what reversed does since #120971). An exhausted iterator keeps the sequence alive until the iterator itself is collected, like listiter/tupleiter/reversed. Concurrent iteration may still see duplicate or missing items; this change only removes the memory unsafety. New test in Lib/test/test_free_threading/test_iteration.py. It uses a small sequence and many rounds so that many threads reach the racy exhaustion path simultaneously, and asserts the sequence's refcount is intact afterwards — the double-DECREF does not always crash, but it reliably shows up as a sagging refcount. On 53d2e14 (main) the test segfaults a free-threaded build. Notecallable_iterator (backing iter(callable, sentinel)) has the same defect but no index field to reuse as a sentinel. Should also be fixed, but didn't feel like it's in-scope here. Issue: gh-156310

Open Graph Description: Sharing a single PySeqIter between threads could double-DECREF the underlying sequence on the exhaustion path and use the sequence after free while another thread was inside PySequence_GetItem. (Se...

X Description: Sharing a single PySeqIter between threads could double-DECREF the underlying sequence on the exhaustion path and use the sequence after free while another thread was inside PySequence_GetItem. (Se...

Opengraph URL: https://github.com/python/cpython/pull/156311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6e2ad565-8b25-dca8-1e94-f85f92c06d04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB352:4BB79:3CDC8B6:4DAEEED:6B021897
html-safe-nonce7e77a9a915d475b6f01eccc87fda82c733d2d39316e60174e8f11c86f55bfd13
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzUyOjRCQjc5OjNDREM4QjY6NERBRUVFRDo2QjAyMTg5NyIsInZpc2l0b3JfaWQiOiI2MTIxNzM4OTc3NTI0NDU1NTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac81f7f6f4e3630fd512e3a7a81332b7d77b5586222f6d77437610894852bf6dd8
hovercard-subject-tagpull_request:4347115593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156311/files
twitter:imagehttps://avatars.githubusercontent.com/u/58669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58669?s=400&v=4
og:image:altSharing a single PySeqIter between threads could double-DECREF the underlying sequence on the exhaustion path and use the sequence after free while another thread was inside PySequence_GetItem. (Se...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156311/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156311%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156311%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156311/files
Reloadhttps://github.com/python/cpython/pull/156311/files
Reloadhttps://github.com/python/cpython/pull/156311/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
akx:gh-156310-seqiter-fthttps://github.com/akx/cpython/tree/gh-156310-seqiter-ft
Conversation 4 https://github.com/python/cpython/pull/156311
Commits 2 https://github.com/python/cpython/pull/156311/commits
Checks 58 https://github.com/python/cpython/pull/156311/checks
Files changed https://github.com/python/cpython/pull/156311/files
Please reload this pagehttps://github.com/python/cpython/pull/156311/files
gh-156310: Make the iter() sequence fallback iterator safe in free-threaded build https://github.com/python/cpython/pull/156311/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/156311/files
6f4e7b2 gh-156310: Make the iter() sequence fallback iterator safe in free-th… akx Aug 24, 2026 https://github.com/python/cpython/pull/156311/commits/6f4e7b2eaf5dc92edf4d39c36db62b07c6b14f50
4c5a7a7 Additional fixes and hardening. nascheme Sep 2, 2026 https://github.com/python/cpython/pull/156311/commits/4c5a7a7eb835afb48f5a2b1591ee63f18af009c9
Clear filters https://github.com/python/cpython/pull/156311/files
Please reload this pagehttps://github.com/python/cpython/pull/156311/files
Please reload this pagehttps://github.com/python/cpython/pull/156311/files
test_iteration.py https://github.com/python/cpython/pull/156311/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
test_iter.py https://github.com/python/cpython/pull/156311/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
2026-08-24-12-00-00.gh-issue-156310.pSqIter.rst https://github.com/python/cpython/pull/156311/files#diff-ddb9dc07508662adae00676030c29606664608a41d4916b5d5af75b7404b22c5
iterobject.c https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
Lib/test/test_free_threading/test_iteration.pyhttps://github.com/python/cpython/pull/156311/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
View file https://github.com/akx/cpython/blob/4c5a7a7eb835afb48f5a2b1591ee63f18af009c9/Lib/test/test_free_threading/test_iteration.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156311/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156311/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
https://github.com/python/cpython/pull/156311/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
https://github.com/python/cpython/pull/156311/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
Lib/test/test_iter.pyhttps://github.com/python/cpython/pull/156311/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
View file https://github.com/akx/cpython/blob/4c5a7a7eb835afb48f5a2b1591ee63f18af009c9/Lib/test/test_iter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156311/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156311/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
https://github.com/python/cpython/pull/156311/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
https://github.com/python/cpython/pull/156311/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
https://github.com/python/cpython/pull/156311/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
Misc/NEWS.d/next/Core_and_Builtins/2026-08-24-12-00-00.gh-issue-156310.pSqIter.rsthttps://github.com/python/cpython/pull/156311/files#diff-ddb9dc07508662adae00676030c29606664608a41d4916b5d5af75b7404b22c5
View file https://github.com/akx/cpython/blob/4c5a7a7eb835afb48f5a2b1591ee63f18af009c9/Misc/NEWS.d/next/Core_and_Builtins/2026-08-24-12-00-00.gh-issue-156310.pSqIter.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156311/{{ revealButtonHref }}
Objects/iterobject.chttps://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
View file https://github.com/akx/cpython/blob/4c5a7a7eb835afb48f5a2b1591ee63f18af009c9/Objects/iterobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156311/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/156311/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
Please reload this pagehttps://github.com/python/cpython/pull/156311/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.