René's URL Explorer Experiment


Title: gh-126253: Ignore unknown Windows file attribute bits in scandir test by Wanbinyu · Pull Request #156305 · python/cpython · GitHub

Open Graph Title: gh-126253: Ignore unknown Windows file attribute bits in scandir test by Wanbinyu · Pull Request #156305 · python/cpython

X Title: gh-126253: Ignore unknown Windows file attribute bits in scandir test by Wanbinyu · Pull Request #156305 · python/cpython

Description: For #126253. os.scandir().stat() and os.stat() can return different values for st_file_attributes when NTFS reports bits that are not exposed by Python's stat module. Limit the scandir test comparison to the public stat.FILE_ATTRIBUTE_* bits, while continuing to compare every public bit strictly. The regression test constructs os.stat_result values with the reported 0x10000000 bit so the behavior is covered even on Windows builds where the filesystem does not naturally return it. It also verifies that a difference in FILE_ATTRIBUTE_READONLY still fails the comparison. Tests: PCbuild\amd64\python_d.exe -m test test_os.test_os -m "*attributes*" -v PCbuild\amd64\python_d.exe -m test -v test_os PCbuild\amd64\python_d.exe Tools\patchcheck\patchcheck.py This contribution was prepared with assistance from OpenAI Codex. I reviewed and tested the resulting changes. Issue: gh-126253

Open Graph Description: For #126253. os.scandir().stat() and os.stat() can return different values for st_file_attributes when NTFS reports bits that are not exposed by Python's stat module. Limit the scandir test com...

X Description: For #126253. os.scandir().stat() and os.stat() can return different values for st_file_attributes when NTFS reports bits that are not exposed by Python's stat module. Limit the scandir test...

Opengraph URL: https://github.com/python/cpython/pull/156305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:82853c6c-c0d6-af34-fa0f-9e3de21a3865
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBCA:23E48:475D3F:599B83:6B0210CE
html-safe-nonce6320ebcc9c3878b1f57c6cb988eb7b76163d69ea230581420bfadacd74f0721c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkNBOjIzRTQ4OjQ3NUQzRjo1OTlCODM6NkIwMjEwQ0UiLCJ2aXNpdG9yX2lkIjoiMjYxOTA5Mjc5NTcyNTU4MjU0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3294c041b6f25b5e751883ea75634a3c290f34289f242f0e46708db1f60fadf1
hovercard-subject-tagpull_request:4345435609
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156305/files
twitter:imagehttps://avatars.githubusercontent.com/u/302325619?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302325619?s=400&v=4
og:image:altFor #126253. os.scandir().stat() and os.stat() can return different values for st_file_attributes when NTFS reports bits that are not exposed by Python's stat module. Limit the scandir test com...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156305/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156305%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156305%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156305/files
Reloadhttps://github.com/python/cpython/pull/156305/files
Reloadhttps://github.com/python/cpython/pull/156305/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
Wanbinyu:gh-126253-test-os-file-attributeshttps://github.com/Wanbinyu/cpython/tree/gh-126253-test-os-file-attributes
Conversation 29 https://github.com/python/cpython/pull/156305
Commits 8 https://github.com/python/cpython/pull/156305/commits
Checks 68 https://github.com/python/cpython/pull/156305/checks
Files changed https://github.com/python/cpython/pull/156305/files
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
gh-126253: Ignore unknown Windows file attribute bits in scandir test https://github.com/python/cpython/pull/156305/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/156305/files
fca5112 gh-126253: Ignore unknown Windows file attribute bits in scandir test Wanbinyu Aug 24, 2026 https://github.com/python/cpython/pull/156305/commits/fca5112f17f1fda9206e0d3b313c6f8b5a23ee9f
4fcb07e gh-126253: Add a Tests NEWS entry Wanbinyu Sep 16, 2026 https://github.com/python/cpython/pull/156305/commits/4fcb07ecc7a646831073e429c0291e6dbd4db022
744f998 Merge branch 'main' into gh-126253-test-os-file-attributes hugovk Nov 4, 2026 https://github.com/python/cpython/pull/156305/commits/744f99854b3eb88b225b6c9bc5bdc72d38939e63
f15f1d1 Rename _FILE_ATTRIBUTE_MASK to FILE_ATTRIBUTE_MASK, add comment, trim… hugovk Nov 12, 2026 https://github.com/python/cpython/pull/156305/commits/f15f1d1cfeac3f47bc58359ba6a31655b92859a5
e29f458 Remove redundant assert_stat_equal hugovk Nov 12, 2026 https://github.com/python/cpython/pull/156305/commits/e29f4587568758ab63b82d770184730cf116107c
946a09c Revert "Remove redundant assert_stat_equal" hugovk Nov 12, 2026 https://github.com/python/cpython/pull/156305/commits/946a09ca6abb68b625c2f552b8943118eceb18e7
6928e67 Remove redundant test_attributes_unknown_bits hugovk Nov 12, 2026 https://github.com/python/cpython/pull/156305/commits/6928e672b6832518573533c5d6d39fed5249df10
8cf64a2 Apply suggestion from @vstinner vstinner Nov 12, 2026 https://github.com/python/cpython/pull/156305/commits/8cf64a2c5668e84f53d2f047d8472ee826352752
Clear filters https://github.com/python/cpython/pull/156305/files
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
test_os.py https://github.com/python/cpython/pull/156305/files#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
2026-09-16-14-37-28.gh-issue-126253.9FOKPp.rst https://github.com/python/cpython/pull/156305/files#diff-19fcdb8d5f8bfa9756a837f6e942c0aa42cd148c691243345e8c1f6ce8983fed
Lib/test/test_os/test_os.pyhttps://github.com/python/cpython/pull/156305/files#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
View file https://github.com/Wanbinyu/cpython/blob/8cf64a2c5668e84f53d2f047d8472ee826352752/Lib/test/test_os/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156305/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156305/files#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
https://github.com/python/cpython/pull/156305/files#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
https://github.com/python/cpython/pull/156305/files#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
https://github.com/python/cpython/pull/156305/files#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
Misc/NEWS.d/next/Tests/2026-09-16-14-37-28.gh-issue-126253.9FOKPp.rsthttps://github.com/python/cpython/pull/156305/files#diff-19fcdb8d5f8bfa9756a837f6e942c0aa42cd148c691243345e8c1f6ce8983fed
View file https://github.com/Wanbinyu/cpython/blob/8cf64a2c5668e84f53d2f047d8472ee826352752/Misc/NEWS.d/next/Tests/2026-09-16-14-37-28.gh-issue-126253.9FOKPp.rst
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156305/{{ revealButtonHref }}
zwarehttps://github.com/zware
Nov 12, 2026https://github.com/python/cpython/pull/156305/files#r4554492480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
vstinnerhttps://github.com/vstinner
Nov 12, 2026https://github.com/python/cpython/pull/156305/files#r4554616682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#126253https://github.com/python/cpython/issues/126253
way longerhttps://github.com/python/cpython/pull/156305/changes/4fcb07ecc7a646831073e429c0291e6dbd4db022
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
hugovkhttps://github.com/hugovk
Nov 12, 2026https://github.com/python/cpython/pull/156305/files#r4554739379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
Please reload this pagehttps://github.com/python/cpython/pull/156305/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.