René's URL Explorer Experiment


Title: gh-155648: Write the empty and placeholder IDLE tests by serhiy-storchaka · Pull Request #156260 · python/cpython · GitHub

Open Graph Title: gh-155648: Write the empty and placeholder IDLE tests by serhiy-storchaka · Pull Request #156260 · python/cpython

X Title: gh-155648: Write the empty and placeholder IDLE tests by serhiy-storchaka · Pull Request #156260 · python/cpython

Description: Several tests in idlelib/idle_test are empty stubs or placeholders that cannot fail. Write them instead of removing them. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking inside a selection, with the note that an automated test should follow. Its DummyRMenu class is used now to test right_menu_event(), together with the rmenu_check_*() methods that supply the menu entry states. test_configdialog.ConfigDialogTest was left with two empty stubs in GH-3592, named after the two ConfigDialog methods which the button tests only check to be called. They are tested with a fake parent whose instance dictionary contains an autospecced EditorWindow. test_configdialog.ExtPageTest was added empty, with a commented out "Nothing here yet TODO" skip, when ExtPage was factored out in GH-26618. The extensions page is the only configuration page without tests. test_grep.Default_commandTest was left empty in 2013 because GrepDialog.default_command() imports OutputWindow when called. The import cannot be moved to the top of the module due to an import loop, but the imported class can be replaced with a mock. test_config.ChangesTest.test_save_default never called save_all(), so it tested nothing. The test for the Save() calls asked for by the following TODO comment is added too. test_config.IdleConfTest.test_get_current_keyset only tested the non-darwin branch, because the default key sets no longer contain Alt keys. An extension binding with an Alt key is added, so that its replacement with Option can be tested. template.py lost the from idlelib import zzdummy line in GH-151478 as an unused import, but idle_test/README.txt instructs the user to replace zzdummy with the name of the module under test. A Ruff per-file ignore keeps it now. Each new test was checked to fail when the corresponding code is broken. The first two items are an alternative to the now merged #156257, which skipped these two stubs as empty. Its skips are removed here, because the tests are written. Its other changes, the vacuous assertion in test_autocomplete and the skipped dummy test in template.py, are left as they are. Issue: gh-155648

Open Graph Description: Several tests in idlelib/idle_test are empty stubs or placeholders that cannot fail. Write them instead of removing them. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking i...

X Description: Several tests in idlelib/idle_test are empty stubs or placeholders that cannot fail. Write them instead of removing them. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking i...

Opengraph URL: https://github.com/python/cpython/pull/156260

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c0f5d06-ff76-6cd5-c1cf-70364cf8d66e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA802:1FE434:15A9D47:1C96BFB:6B01FC32
html-safe-nonce568c05fc8aaa98a4de4978d0724dc19143a9322a4243ff8acf1b04a572cd7228
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODAyOjFGRTQzNDoxNUE5RDQ3OjFDOTZCRkI6NkIwMUZDMzIiLCJ2aXNpdG9yX2lkIjoiNzUyMzg1Mjg0ODI2MjY3NTUwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8497ed994cfde7f128e2fc347c5e6983803ef85c9eb774575c87ce1f80528803
hovercard-subject-tagpull_request:4341290526
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156260/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altSeveral tests in idlelib/idle_test are empty stubs or placeholders that cannot fail. Write them instead of removing them. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156260/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156260%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156260%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156260/files
Reloadhttps://github.com/python/cpython/pull/156260/files
Reloadhttps://github.com/python/cpython/pull/156260/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terryjreedyhttps://github.com/terryjreedy
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:idle-test-placeholdershttps://github.com/serhiy-storchaka/cpython/tree/idle-test-placeholders
Conversation 28 https://github.com/python/cpython/pull/156260
Commits 11 https://github.com/python/cpython/pull/156260/commits
Checks 56 https://github.com/python/cpython/pull/156260/checks
Files changed https://github.com/python/cpython/pull/156260/files
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
gh-155648: Write the empty and placeholder IDLE tests https://github.com/python/cpython/pull/156260/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/156260/files
ca34830 Restore the placeholder import in idlelib/idle_test/template.py serhiy-storchaka Aug 23, 2026 https://github.com/python/cpython/pull/156260/commits/ca34830e643fd358c1c64459ea725b70dc86f07b
6acbb16 gh-155648: Write the empty IDLE tests instead of commenting them out serhiy-storchaka Aug 23, 2026 https://github.com/python/cpython/pull/156260/commits/6acbb16903e5f3ae6f23355ee13a6ccc84f4a33c
200a88f Write the placeholder tests in the IDLE test suite serhiy-storchaka Aug 23, 2026 https://github.com/python/cpython/pull/156260/commits/200a88f6ad7031948498af3f96ffb1aeae3caf46
7789adb Do not depend on the text geometry in RMenuTest serhiy-storchaka Aug 23, 2026 https://github.com/python/cpython/pull/156260/commits/7789adb70c9c8026e4bce6aff19bd1ab2f40b2cc
cae2685 Merge branch 'main' into idle-test-placeholders serhiy-storchaka Aug 24, 2026 https://github.com/python/cpython/pull/156260/commits/cae268555f93b27b2990e64cb78da28ed1cba6e1
3b3ae5b Remove the skips added for the empty tests serhiy-storchaka Aug 24, 2026 https://github.com/python/cpython/pull/156260/commits/3b3ae5b0c916e61b7a0872d6c0b5d64748dfaa05
7d801b3 Apply suggestion from @hugovk serhiy-storchaka Aug 28, 2026 https://github.com/python/cpython/pull/156260/commits/7d801b34e04b082853bb9c886b7d8456aef2b12f
b9170ba Explain the placeholder import in template.py serhiy-storchaka Aug 28, 2026 https://github.com/python/cpython/pull/156260/commits/b9170ba495f045234f7af61dd432bdffe4856f2d
6d8e62b Apply review comments serhiy-storchaka Sep 7, 2026 https://github.com/python/cpython/pull/156260/commits/6d8e62b98edf39baf44bdc6aa533d0eb823b6f23
3b3f69d Apply review comments serhiy-storchaka Sep 8, 2026 https://github.com/python/cpython/pull/156260/commits/3b3f69d7386dc164981ed0cf3518ada7bc52ecf7
def5adb Update Lib/idlelib/idle_test/test_editor.py serhiy-storchaka Sep 8, 2026 https://github.com/python/cpython/pull/156260/commits/def5adb0b1fca45e9cee0d6c59d2522a363cdb52
Clear filters https://github.com/python/cpython/pull/156260/files
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
.ruff.toml https://github.com/python/cpython/pull/156260/files#diff-cf20df6617294637667fe885c4ccce9944bafe1f040fb26bb6e09f25fbd010b2
README.txt https://github.com/python/cpython/pull/156260/files#diff-bd76da1189319b8faa78356c13ff52da2ceb59051aa160068d4c2a5569e6e5b6
template.py https://github.com/python/cpython/pull/156260/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
test_config.py https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
test_configdialog.py https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
test_editor.py https://github.com/python/cpython/pull/156260/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
test_grep.py https://github.com/python/cpython/pull/156260/files#diff-0201c50a6402355668c94c844ed63dc144c3df080d2092bd1fe6b2b4aa17d95b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L73
Lib/.ruff.tomlhttps://github.com/python/cpython/pull/156260/files#diff-cf20df6617294637667fe885c4ccce9944bafe1f040fb26bb6e09f25fbd010b2
View file https://github.com/serhiy-storchaka/cpython/blob/def5adb0b1fca45e9cee0d6c59d2522a363cdb52/Lib/.ruff.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156260/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156260/files#diff-cf20df6617294637667fe885c4ccce9944bafe1f040fb26bb6e09f25fbd010b2
https://github.com/python/cpython/pull/156260/files#diff-cf20df6617294637667fe885c4ccce9944bafe1f040fb26bb6e09f25fbd010b2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/README.txthttps://github.com/python/cpython/pull/156260/files#diff-bd76da1189319b8faa78356c13ff52da2ceb59051aa160068d4c2a5569e6e5b6
View file https://github.com/serhiy-storchaka/cpython/blob/def5adb0b1fca45e9cee0d6c59d2522a363cdb52/Lib/idlelib/idle_test/README.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156260/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156260/files#diff-bd76da1189319b8faa78356c13ff52da2ceb59051aa160068d4c2a5569e6e5b6
https://github.com/python/cpython/pull/156260/files#diff-bd76da1189319b8faa78356c13ff52da2ceb59051aa160068d4c2a5569e6e5b6
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/template.pyhttps://github.com/python/cpython/pull/156260/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
View file https://github.com/serhiy-storchaka/cpython/blob/def5adb0b1fca45e9cee0d6c59d2522a363cdb52/Lib/idlelib/idle_test/template.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156260/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156260/files#diff-83a052994749cb9470bc4d774718bad7a88a16a1fed0b045c2aaab1e44bc1ae2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/test_config.pyhttps://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
View file https://github.com/serhiy-storchaka/cpython/blob/def5adb0b1fca45e9cee0d6c59d2522a363cdb52/Lib/idlelib/idle_test/test_config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156260/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
https://github.com/python/cpython/pull/156260/files#diff-f618accd1d1ecc310b21f04786f0cba469b31e2df636a9a9245a1efb3053f1fa
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/test_configdialog.pyhttps://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
View file https://github.com/serhiy-storchaka/cpython/blob/def5adb0b1fca45e9cee0d6c59d2522a363cdb52/Lib/idlelib/idle_test/test_configdialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156260/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/pull/156260/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/test_editor.pyhttps://github.com/python/cpython/pull/156260/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
View file https://github.com/serhiy-storchaka/cpython/blob/def5adb0b1fca45e9cee0d6c59d2522a363cdb52/Lib/idlelib/idle_test/test_editor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156260/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156260/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
https://github.com/python/cpython/pull/156260/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
https://github.com/python/cpython/pull/156260/files#diff-bac2e14f6c7aadf914b40304552d8e0689317d8ff639a9a497cff07f3972392a
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
Please reload this pagehttps://github.com/python/cpython/pull/156260/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.