René's URL Explorer Experiment


Title: gh-156250: Speed up inherited mapping assignment slot calls by koxudaxi · Pull Request #156258 · python/cpython · GitHub

Open Graph Title: gh-156250: Speed up inherited mapping assignment slot calls by koxudaxi · Pull Request #156258 · python/cpython

X Title: gh-156250: Speed up inherited mapping assignment slot calls by koxudaxi · Pull Request #156258 · python/cpython

Description: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C type overrides only one of them, the inherited operation is still dispatched through slot_mp_ass_subscript() and called through a wrapper_descriptor. When lookup returns the expected unbound wrapper descriptor, slot_mp_ass_subscript() now calls the wrapped C slot directly. Python overrides and other descriptors continue through the generic call path. Benchmark I found this while profiling Counter-heavy code in a private project. Counter overrides __delitem__ but inherits dict.__setitem__, so several Counter operations go through this path. I compared the feature commit 8ca6cd042b1e1fe91e2751c5abf3204631c749c0 with its direct parent b062727097e997bcb900e11503d3248daac903da. Both were release builds on macOS 15.7.1 arm64 with the same PGO/LTO configuration. Operation Improvement c[key] = value 49.9% c[key] += 1 39.0% c.update(mapping) 41.2% c.subtract(mapping) 37.7% a + b 28.7% a | b 28.2% Counter(iterable) and Counter.update(iterable) are not affected. They already use the _count_elements() C fast path. I also checked larger workloads with the same two builds. NetworkX nx.triangles() was 5.1% to 9.0% faster across four graph shapes. The BPE benchmark in pyperformance was 6% to 8% faster in repeated runs. The same one sided __setitem__ / __delitem__ pattern also exists outside Counter, but most of the other workloads I checked showed little or no end to end difference. Given these results, I think this optimization is worth the extra complexity in slot_mp_ass_subscript(). The affected pattern is fairly narrow, but the improvement shows up in normal Counter operations and in larger workloads. (Updated on August 26, 2026 with additional Counter and real world benchmark results.) Tests Tests cover asymmetric dict subclasses, inherited slice deletion on a list subclass, and fallback for custom or incompatible descriptors. The targeted tests pass on regular and free-threaded debug builds. Fixes #156250 Issue: gh-156250

Open Graph Description: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C type overrides only one of them, the inherited operation is still dispatched through slot_mp_ass_subscript()...

X Description: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C type overrides only one of them, the inherited operation is still dispatched through slot_mp_ass_subscript()...

Opengraph URL: https://github.com/python/cpython/pull/156258

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99e97ec5-8ea2-57b3-64bd-5ebf05800e98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD454:2AF0D8:2C9246:377D1B:6B01F68E
html-safe-nonceb6dae107e951cf27739d0dc6757962c27d827d65b4af79f7a3a58bd9fad639ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDU0OjJBRjBEODoyQzkyNDY6Mzc3RDFCOjZCMDFGNjhFIiwidmlzaXRvcl9pZCI6Ijc0MDQyODUwMzg5NjA5NjUyNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbbc95610356e1f857ae1642ed70d5e991f9816b6b4eda61a546abbdd98437485
hovercard-subject-tagpull_request:4341083033
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156258/files
twitter:imagehttps://avatars.githubusercontent.com/u/630670?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/630670?s=400&v=4
og:image:alt__setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C type overrides only one of them, the inherited operation is still dispatched through slot_mp_ass_subscript()...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156258/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156258%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156258%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156258/files
Reloadhttps://github.com/python/cpython/pull/156258/files
Reloadhttps://github.com/python/cpython/pull/156258/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
koxudaxihttps://github.com/koxudaxi
python:mainhttps://github.com/python/cpython/tree/main
koxudaxi:perf/gh-156250-mapping-assignment-slothttps://github.com/koxudaxi/cpython/tree/perf/gh-156250-mapping-assignment-slot
Conversation 2 https://github.com/python/cpython/pull/156258
Commits 2 https://github.com/python/cpython/pull/156258/commits
Checks 50 https://github.com/python/cpython/pull/156258/checks
Files changed https://github.com/python/cpython/pull/156258/files
Please reload this pagehttps://github.com/python/cpython/pull/156258/files
gh-156250: Speed up inherited mapping assignment slot calls https://github.com/python/cpython/pull/156258/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/156258/files
8ca6cd0 gh-156250: Speed up inherited mapping assignment slot calls koxudaxi Aug 23, 2026 https://github.com/python/cpython/pull/156258/commits/8ca6cd042b1e1fe91e2751c5abf3204631c749c0
70245eb Merge branch 'main' into perf/gh-156250-mapping-assignment-slot koxudaxi Aug 23, 2026 https://github.com/python/cpython/pull/156258/commits/70245ebdb80e9cc0a7670e7a45f883f614d10e07
Clear filters https://github.com/python/cpython/pull/156258/files
Please reload this pagehttps://github.com/python/cpython/pull/156258/files
Please reload this pagehttps://github.com/python/cpython/pull/156258/files
test_descr.py https://github.com/python/cpython/pull/156258/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
2026-08-23-13-19-43.gh-issue-156250.xJMn6W.rst https://github.com/python/cpython/pull/156258/files#diff-92699175d02ac299bc4c20db68b7430f005e956e875e81fd54ab3a9cfeed5dfd
typeobject.c https://github.com/python/cpython/pull/156258/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Lib/test/test_descr.pyhttps://github.com/python/cpython/pull/156258/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
View file https://github.com/python/cpython/blob/70245ebdb80e9cc0a7670e7a45f883f614d10e07/Lib/test/test_descr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156258/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156258/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
https://github.com/python/cpython/pull/156258/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
Misc/NEWS.d/next/Core_and_Builtins/2026-08-23-13-19-43.gh-issue-156250.xJMn6W.rsthttps://github.com/python/cpython/pull/156258/files#diff-92699175d02ac299bc4c20db68b7430f005e956e875e81fd54ab3a9cfeed5dfd
View file https://github.com/python/cpython/blob/70245ebdb80e9cc0a7670e7a45f883f614d10e07/Misc/NEWS.d/next/Core_and_Builtins/2026-08-23-13-19-43.gh-issue-156250.xJMn6W.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156258/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L217
Objects/typeobject.chttps://github.com/python/cpython/pull/156258/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/python/cpython/blob/70245ebdb80e9cc0a7670e7a45f883f614d10e07/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156258/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156258/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/156258/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/156258/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/156258/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/156258/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.