René's URL Explorer Experiment


Title: gh-150942: Speed up Py_BuildValue dict construction by tkim602 · Pull Request #156199 · python/cpython · GitHub

Open Graph Title: gh-150942: Speed up Py_BuildValue dict construction by tkim602 · Pull Request #156199 · python/cpython

X Title: gh-150942: Speed up Py_BuildValue dict construction by tkim602 · Pull Request #156199 · python/cpython

Description: Speed up Py_BuildValue() dictionary construction by using _PyDict_SetItem_Take2() in do_mkdict(). Both the key and value returned by do_mkvalue() are owned references. Transferring them directly to the dictionary avoids the INCREF/DECREF round trips performed by PyDict_SetItem() for each pair. The v == NULL path remains separate so that insertion is only attempted after both objects have been created successfully. Microbenchmarks pyperf 2.10.0 on macOS x86_64, Intel Core i7-1068NG7, Apple Clang 17. Reverse-order runs were also performed. Benchmark Baseline Patched Result Reverse integer dict, 3 pairs 461 ns 439 ns 1.05x faster 1.02x faster integer dict, 5 pairs 624 ns 615 ns 1.01x faster 1.02x faster existing objects, 3 pairs 326 ns 321 ns 1.01x faster 1.02x faster existing objects, 5 pairs 420 ns 409 ns 1.03x faster 1.01x faster duplicate key, 3 pairs 317 ns 311 ns 1.02x faster 1.01x faster The gains are small but repeatable across the tested Py_BuildValue() dictionary workloads. Validation test_capi and test_dict debug refleak runs with -R 3:3 success, insertion-failure, and replacement-path ownership stress tests make patchcheck git diff --check Issue: gh-150942

Open Graph Description: Speed up Py_BuildValue() dictionary construction by using _PyDict_SetItem_Take2() in do_mkdict(). Both the key and value returned by do_mkvalue() are owned references. Transferring them directly to...

X Description: Speed up Py_BuildValue() dictionary construction by using _PyDict_SetItem_Take2() in do_mkdict(). Both the key and value returned by do_mkvalue() are owned references. Transferring them directly to...

Opengraph URL: https://github.com/python/cpython/pull/156199

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:25d303b9-1efc-70c0-67b4-fa8cf677136c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC208:380435:69182B:849DB5:6B020BAF
html-safe-nonce04ca2b9a36d0149e0fe18a7336d77a9e9decc4897675b2c7362df4cbca1938e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjA4OjM4MDQzNTo2OTE4MkI6ODQ5REI1OjZCMDIwQkFGIiwidmlzaXRvcl9pZCI6IjE5OTcyMTAyOTg5NTU3Mjk4MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace1349a590afb94528e8708c22f3ead89d20f6d4dea38e7037f01784212810026
hovercard-subject-tagpull_request:4333657849
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156199/files
twitter:imagehttps://avatars.githubusercontent.com/u/157748120?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/157748120?s=400&v=4
og:image:altSpeed up Py_BuildValue() dictionary construction by using _PyDict_SetItem_Take2() in do_mkdict(). Both the key and value returned by do_mkvalue() are owned references. Transferring them directly to...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156199/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156199%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156199%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156199/files
Reloadhttps://github.com/python/cpython/pull/156199/files
Reloadhttps://github.com/python/cpython/pull/156199/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tkim602https://github.com/tkim602
python:mainhttps://github.com/python/cpython/tree/main
tkim602:modsupport-mkdict-take2https://github.com/tkim602/cpython/tree/modsupport-mkdict-take2
Conversation 6 https://github.com/python/cpython/pull/156199
Commits 1 https://github.com/python/cpython/pull/156199/commits
Checks 49 https://github.com/python/cpython/pull/156199/checks
Files changed https://github.com/python/cpython/pull/156199/files
Please reload this pagehttps://github.com/python/cpython/pull/156199/files
gh-150942: Speed up Py_BuildValue dict construction https://github.com/python/cpython/pull/156199/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/156199/files
9b108fb gh-150942: Speed up Py_BuildValue dict construction tkim602 Aug 21, 2026 https://github.com/python/cpython/pull/156199/commits/9b108fbfe294369cdccb3069afa1661442ef22a4
Clear filters https://github.com/python/cpython/pull/156199/files
Please reload this pagehttps://github.com/python/cpython/pull/156199/files
Please reload this pagehttps://github.com/python/cpython/pull/156199/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L265
Python/modsupport.chttps://github.com/python/cpython/pull/156199/files#diff-1f0aec603b2223fac76a4d9959b8deedd3e5fe3bf2e8a8e7602a3bfbd921f827
View file https://github.com/python/cpython/blob/9b108fbfe294369cdccb3069afa1661442ef22a4/Python/modsupport.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156199/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156199/files#diff-1f0aec603b2223fac76a4d9959b8deedd3e5fe3bf2e8a8e7602a3bfbd921f827
https://github.com/python/cpython/pull/156199/files#diff-1f0aec603b2223fac76a4d9959b8deedd3e5fe3bf2e8a8e7602a3bfbd921f827
https://github.com/python/cpython/pull/156199/files#diff-1f0aec603b2223fac76a4d9959b8deedd3e5fe3bf2e8a8e7602a3bfbd921f827
https://github.com/python/cpython/pull/156199/files#diff-1f0aec603b2223fac76a4d9959b8deedd3e5fe3bf2e8a8e7602a3bfbd921f827
Please reload this pagehttps://github.com/python/cpython/pull/156199/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.