| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a962a42c-0e54-5257-e72e-8a93026b8bd3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDDA:2BBD61:AD7728:EB8E35:696ABC14 |
| html-safe-nonce | 38908161259ac678936aa994da579f67dcffc39c85b007ae2bf90d98bd0e2f19 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRERBOjJCQkQ2MTpBRDc3Mjg6RUI4RTM1OjY5NkFCQzE0IiwidmlzaXRvcl9pZCI6IjY1NTg4NTU2OTYzNDA0MDExNzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5c8b46298939df6afdb19b08abec5f9bde65a2c9a38d80cc7c937d2c5991888d |
| hovercard-subject-tag | pull_request:312511549 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/15604/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4feab32bb747c4a86332c263c12256b2a449077bbe0d4e5d72129193aa4cbcb6/python/cpython/pull/15604 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4feab32bb747c4a86332c263c12256b2a449077bbe0d4e5d72129193aa4cbcb6/python/cpython/pull/15604 |
| og:image:alt | -""" over '''
-no blank line either before or after the docstring.
-place the closing quotes on a line by themselves
Automerge-Triggered-By: @gvanrossum |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alanyee |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/15604#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15604 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15604 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/15604 |
| Reload | https://github.com/python/cpython/pull/15604 |
| Reload | https://github.com/python/cpython/pull/15604 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/15604#issue-comment-box |
| miss-islington | https://github.com/miss-islington |
| python:master | https://github.com/python/cpython/tree/master |
|
Enforce PEP 257 conventions in ftplib.py
| https://github.com/python/cpython/pull/15604#top |
| miss-islington | https://github.com/miss-islington |
| python:master | https://github.com/python/cpython/tree/master |
|
Conversation
35
| https://github.com/python/cpython/pull/15604 |
|
Commits
5
| https://github.com/python/cpython/pull/15604/commits |
|
Checks
0
| https://github.com/python/cpython/pull/15604/checks |
|
Files changed
| https://github.com/python/cpython/pull/15604/files |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/alanyee |
| alanyee | https://github.com/alanyee |
| Aug 29, 2019 | https://github.com/python/cpython/pull/15604#issue-487196872 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
|
| https://github.com/alanyee |
| Update ftplib.py | https://github.com/python/cpython/pull/15604/commits/16a19267cfe24ba2ecd9256e41c5f79289db3980 |
| 16a1926 | https://github.com/python/cpython/pull/15604/commits/16a19267cfe24ba2ecd9256e41c5f79289db3980 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
| Aug 29, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526380168 |
| PSF contributor agreement | https://www.python.org/psf/contrib/contrib-form/ |
| bugs.python.org | https://bugs.python.org/ |
| the steps outlined in the CPython devguide | https://devguide.python.org/pullrequest/#licensing |
| check yourself | https://check-python-cla.herokuapp.com/ |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Aug 29, 2019 | https://github.com/python/cpython/pull/15604#event-2595470524 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 29, 2019 | https://github.com/python/cpython/pull/15604#event-2595470561 |
| https://github.com/eamanu |
| eamanu | https://github.com/eamanu |
|
Aug 30, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-281793334 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/16a19267cfe24ba2ecd9256e41c5f79289db3980 |
| eamanu | https://github.com/eamanu |
| https://github.com/python/cpython/pull/15604#pullrequestreview-281793334 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alanyee | https://github.com/alanyee |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#event-2595744932 |
| https://github.com/eamanu |
| eamanu | https://github.com/eamanu |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526419671 |
| @alanyee | https://github.com/alanyee |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/alanyee |
| alanyee | https://github.com/alanyee |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526448263 |
| @eamanu | https://github.com/eamanu |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
Aug 30, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-281890676 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/16a19267cfe24ba2ecd9256e41c5f79289db3980 |
| aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/python/cpython/pull/15604#pullrequestreview-281890676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alanyee | https://github.com/alanyee |
| devguide | https://devguide.python.org/pullrequest/#patchcheck |
| https://bugs.python.org | https://bugs.python.org |
| CLA heroku app | https://check-python-cla.herokuapp.com/ |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
skip issue
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#event-2596387813 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526511112 |
| @eamanu | https://github.com/eamanu |
| @alanyee | https://github.com/alanyee |
| @eamanu | https://github.com/eamanu |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/tirkarthi |
| tirkarthi | https://github.com/tirkarthi |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526551786 |
| @eamanu | https://github.com/eamanu |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526566812 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| @tirkarthi | https://github.com/tirkarthi |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/eamanu |
| eamanu | https://github.com/eamanu |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526647799 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#event-2597772239 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526744733 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| #14069 | https://github.com/python/cpython/pull/14069 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
Aug 30, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282258056 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/16a19267cfe24ba2ecd9256e41c5f79289db3980 |
| aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/python/cpython/pull/15604#pullrequestreview-282258056 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| PEP 257 | https://www.python.org/dev/peps/pep-0257/#what-is-a-docstring |
| documentation for ftplib | https://docs.python.org/3/library/ftplib.html?highlight=ftplib#module-ftplib |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526771301 |
| https://github.com/goodger | https://github.com/goodger |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526773111 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#event-2598482099 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526774728 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526775769 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Aug 30, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526780039 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| @gvanrossum | https://github.com/gvanrossum |
| @python | https://github.com/python |
| @alanyee | https://github.com/alanyee |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/alanyee |
| alanyee | https://github.com/alanyee |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526842846 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
|
| https://github.com/alanyee |
| Update according to feedback | https://github.com/python/cpython/pull/15604/commits/737a260b98c6cd8435125a1f34922b539a442549 |
| 737a260 | https://github.com/python/cpython/pull/15604/commits/737a260b98c6cd8435125a1f34922b539a442549 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-526860383 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#event-2599002119 |
| https://github.com/corona10 |
| corona10 | https://github.com/corona10 |
|
Aug 31, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282319353 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| corona10 | https://github.com/corona10 |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319735922 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.python.org/dev/peps/pep-0008/#maximum-line-length | https://www.python.org/dev/peps/pep-0008/#maximum-line-length |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| corona10 | https://github.com/corona10 |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319736885 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alanyee | https://github.com/alanyee |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/corona10 |
| corona10 | https://github.com/corona10 |
|
Aug 31, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282319368 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| corona10 | https://github.com/corona10 |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319735931 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/corona10 |
| corona10 | https://github.com/corona10 |
|
Aug 31, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282319404 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549 |
| corona10 | https://github.com/corona10 |
| https://github.com/python/cpython/pull/15604#pullrequestreview-282319404 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
Aug 31, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282319913 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549 |
| aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/python/cpython/pull/15604#pullrequestreview-282319913 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alanyee | https://github.com/alanyee |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| aeros | https://github.com/aeros |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319736427 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| aeros | https://github.com/aeros |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319736438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| aeros | https://github.com/aeros |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319736459 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| aeros | https://github.com/aeros |
| Aug 31, 2019 | https://github.com/python/cpython/pull/15604#discussion_r319736560 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
|
| https://github.com/alanyee |
| Revert exclusive format changes | https://github.com/python/cpython/pull/15604/commits/d97616c49a55457efb81b79bb3c116c157d96403 |
| d97616c | https://github.com/python/cpython/pull/15604/commits/d97616c49a55457efb81b79bb3c116c157d96403 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
Sep 2, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282388120 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/d97616c49a55457efb81b79bb3c116c157d96403 |
| aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/python/cpython/pull/15604#pullrequestreview-282388120 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alanyee | https://github.com/alanyee |
| PEP 257 | https://www.python.org/dev/peps/pep-0257/ |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/d97616c49a55457efb81b79bb3c116c157d96403#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| Lib/ftplib.py | https://github.com/python/cpython/pull/15604/files/d97616c49a55457efb81b79bb3c116c157d96403#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| alanyee | https://github.com/alanyee |
| September 2, 2019 12:38 | https://github.com/python/cpython/pull/15604#commits-pushed-fee51e0 |
|
| https://github.com/alanyee |
|
| https://github.com/aeros |
| Update Lib/ftplib.py | https://github.com/python/cpython/pull/15604/commits/fee51e06b4560668a2f554d17c926f82bed503ea |
| fee51e0 | https://github.com/python/cpython/pull/15604/commits/fee51e06b4560668a2f554d17c926f82bed503ea |
|
| https://github.com/alanyee |
|
| https://github.com/aeros |
| Update Lib/ftplib.py | https://github.com/python/cpython/pull/15604/commits/d71f89d253b78409ecb4118c48f9a4a388417515 |
| d71f89d | https://github.com/python/cpython/pull/15604/commits/d71f89d253b78409ecb4118c48f9a4a388417515 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 2, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282695699 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/d71f89d253b78409ecb4118c48f9a4a388417515 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/cpython/pull/15604#pullrequestreview-282695699 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 2, 2019 | https://github.com/python/cpython/pull/15604#event-2601760507 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
Sep 2, 2019
| https://github.com/python/cpython/pull/15604#pullrequestreview-282708136 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15604/files/d71f89d253b78409ecb4118c48f9a4a388417515 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
🤖 automerge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22 |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#event-2602203175 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-527298201 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| efa3b51 | https://github.com/python/cpython/commit/efa3b51fd060352cc6220b27a1026e4d4d5401bd |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#event-2602203226 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-527298207 |
| @alanyee | https://github.com/alanyee |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-527298208 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#event-2602203252 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 3, 2019 | https://github.com/python/cpython/pull/15604#issuecomment-527298354 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
| lisroach | https://github.com/lisroach |
|
Sep 10, 2019
| https://github.com/python/cpython/pull/15604#ref-commit-f284fdc |
|
| https://github.com/alanyee |
|
| https://github.com/lisroach |
| Enforce PEP 257 conventions in ftplib.py ( | https://github.com/lisroach/cpython/commit/f284fdc8c2e32cb0f0f92035f2714985d88c706b |
| pythonGH-15604 | https://github.com/python/cpython/pull/15604 |
| ) | https://github.com/lisroach/cpython/commit/f284fdc8c2e32cb0f0f92035f2714985d88c706b |
| f284fdc | https://github.com/lisroach/cpython/commit/f284fdc8c2e32cb0f0f92035f2714985d88c706b |
| https://github.com/alanyee |
| alanyee | https://github.com/alanyee |
| October 17, 2019 18:05 | https://github.com/python/cpython/pull/15604#event-2722250684 |
| DinoV | https://github.com/DinoV |
|
Jan 14, 2020
| https://github.com/python/cpython/pull/15604#ref-commit-f6dd5af |
|
| https://github.com/alanyee |
|
| https://github.com/DinoV |
| Enforce PEP 257 conventions in ftplib.py ( | https://github.com/DinoV/cpython/commit/f6dd5af1cb999b83432b91e66b96f5e69952a4de |
| pythonGH-15604 | https://github.com/python/cpython/pull/15604 |
| ) | https://github.com/DinoV/cpython/commit/f6dd5af1cb999b83432b91e66b96f5e69952a4de |
| f6dd5af | https://github.com/DinoV/cpython/commit/f6dd5af1cb999b83432b91e66b96f5e69952a4de |
| websurfer5 | https://github.com/websurfer5 |
|
Jul 20, 2020
| https://github.com/python/cpython/pull/15604#ref-commit-961e916 |
|
| https://github.com/alanyee |
|
| https://github.com/websurfer5 |
| Enforce PEP 257 conventions in ftplib.py ( | https://github.com/websurfer5/cpython/commit/961e916532ca5c9f73885fb1cbc717cfb1fe2fb3 |
| pythonGH-15604 | https://github.com/python/cpython/pull/15604 |
| ) | https://github.com/websurfer5/cpython/commit/961e916532ca5c9f73885fb1cbc717cfb1fe2fb3 |
| 961e916 | https://github.com/websurfer5/cpython/commit/961e916532ca5c9f73885fb1cbc717cfb1fe2fb3 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15604 |
|
| https://github.com/corona10 |
|
corona10
| https://github.com/corona10 |
|
| https://github.com/python/cpython/pull/15604/files/737a260b98c6cd8435125a1f34922b539a442549 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/cpython/pull/15604/files/d71f89d253b78409ecb4118c48f9a4a388417515 |
|
| https://github.com/eamanu |
|
eamanu
| https://github.com/eamanu |
|
| https://github.com/python/cpython/pull/15604/files/16a19267cfe24ba2ecd9256e41c5f79289db3980 |
|
| https://github.com/aeros |
|
aeros
| https://github.com/aeros |
|
| https://github.com/python/cpython/pull/15604/files/d71f89d253b78409ecb4118c48f9a4a388417515 |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
|
skip issue
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/15604 |
|
| https://github.com/alanyee |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/eamanu |
|
| https://github.com/aeros |
|
| https://github.com/tirkarthi |
|
| https://github.com/gvanrossum |
|
| https://github.com/miss-islington |
|
| https://github.com/corona10 |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |