René's URL Explorer Experiment


Title: gh-155966: Correct handling of `math.tanpi` poles by jepler · Pull Request #155980 · python/cpython · GitHub

Open Graph Title: gh-155966: Correct handling of `math.tanpi` poles by jepler · Pull Request #155980 · python/cpython

X Title: gh-155966: Correct handling of `math.tanpi` poles by jepler · Pull Request #155980 · python/cpython

Description: As pointed out in #155966, the exceptional half-integer (0.5, 1.5, etc) inputs of tanpi were not handled properly. Now, these raise ValueError and this is tested by test.test_math through its list of test cases. In the process of working on this, I noticed that I had incorrectly added duplicate test ids and that this was not treated as an error by the test harness. I have corrected this and made it part of the test. Issue: gh-155966

Open Graph Description: As pointed out in #155966, the exceptional half-integer (0.5, 1.5, etc) inputs of tanpi were not handled properly. Now, these raise ValueError and this is tested by test.test_math through its list ...

X Description: As pointed out in #155966, the exceptional half-integer (0.5, 1.5, etc) inputs of tanpi were not handled properly. Now, these raise ValueError and this is tested by test.test_math through its list ...

Opengraph URL: https://github.com/python/cpython/pull/155980

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4981d410-0854-1d17-d1e7-e879a8c8ad0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2AC:1F87:6395C7:7CDA14:6B0216D6
html-safe-noncec71450074bd4a1dbd0bbbde34fdfbc4e1eeb07c249165d1877771b30557150b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkFDOjFGODc6NjM5NUM3OjdDREExNDo2QjAyMTZENiIsInZpc2l0b3JfaWQiOiIxODk5MDcwMjIzMjI3Njg4NjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace41c454f4143822aab6c8dc5f9cd2ac0dbfdbda328e2fff8533239c745e8674f
hovercard-subject-tagpull_request:4299735497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155980/files
twitter:imagehttps://avatars.githubusercontent.com/u/1517291?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1517291?s=400&v=4
og:image:altAs pointed out in #155966, the exceptional half-integer (0.5, 1.5, etc) inputs of tanpi were not handled properly. Now, these raise ValueError and this is tested by test.test_math through its list ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155980/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155980%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155980%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155980/files
Reloadhttps://github.com/python/cpython/pull/155980/files
Reloadhttps://github.com/python/cpython/pull/155980/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
jepler:issue-155966https://github.com/jepler/cpython/tree/issue-155966
Conversation 22 https://github.com/python/cpython/pull/155980
Commits 10 https://github.com/python/cpython/pull/155980/commits
Checks 56 https://github.com/python/cpython/pull/155980/checks
Files changed https://github.com/python/cpython/pull/155980/files
Please reload this pagehttps://github.com/python/cpython/pull/155980/files
gh-155966: Correct handling of math.tanpi poles https://github.com/python/cpython/pull/155980/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/155980/files
886d4ac gh-155966: Correct handling of tanpi(0.5) (#155966) jepler Aug 17, 2026 https://github.com/python/cpython/pull/155980/commits/886d4ac099b95d2c269387f00b9e4493ebeefbf6
faa1799 math_testcases: Fix duplicate test ids jepler Aug 17, 2026 https://github.com/python/cpython/pull/155980/commits/faa179949c4649a2c2ae863756fc34bcccf04a0a
198937d test_math: Treat duplicate test ids as failure. jepler Aug 17, 2026 https://github.com/python/cpython/pull/155980/commits/198937d95e8844c36cbc8169c35b122afcecbe9e
5bd16b9 Add news entry jepler Aug 17, 2026 https://github.com/python/cpython/pull/155980/commits/5bd16b90e311304ed579e64dbe8a9f6dccd7d68f
e59375b Update Misc/NEWS.d/next/Library/2026-08-17-17-39-41.gh-issue-155966.0… jepler Aug 18, 2026 https://github.com/python/cpython/pull/155980/commits/e59375bdc26a430bc38ddb0e5e67a189b35840f0
9dff17a fix sign of infinity in test cases jepler Aug 18, 2026 https://github.com/python/cpython/pull/155980/commits/9dff17a389c8c6de7c1568228cf4c930c96ddf33
b4b4484 Revert "math_testcases: Fix duplicate test ids" jepler Aug 18, 2026 https://github.com/python/cpython/pull/155980/commits/b4b4484d9d01961d0fb80915d35be935f8160340
38f4d61 fix only minimal set of testcase IDs jepler Aug 18, 2026 https://github.com/python/cpython/pull/155980/commits/38f4d61bca9d99eab6b93e886d1b8767e16b70e9
216f1da Apply suggestion from @skirpichev skirpichev Aug 18, 2026 https://github.com/python/cpython/pull/155980/commits/216f1dab8fed702a547d1c118bfc7ba2d67b9e9e
f7a4d0a Merge branch 'main' into issue-155966 skirpichev Aug 19, 2026 https://github.com/python/cpython/pull/155980/commits/f7a4d0af8f864c0759b2aa0e403448bc0e91f4ae
Clear filters https://github.com/python/cpython/pull/155980/files
Please reload this pagehttps://github.com/python/cpython/pull/155980/files
Please reload this pagehttps://github.com/python/cpython/pull/155980/files
math_testcases.txt https://github.com/python/cpython/pull/155980/files#diff-944c900284c68b688cb7b3cfe9a43f9cb4c8a97d9c772ee6b815441d5dac89e1
test_math.py https://github.com/python/cpython/pull/155980/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
2026-08-17-17-39-41.gh-issue-155966.0YOADY.rst https://github.com/python/cpython/pull/155980/files#diff-e636969bd0800ac7122430628bf94e16e4d6981b00db3f705f36e402afc73171
mathmodule.c https://github.com/python/cpython/pull/155980/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Lib/test/mathdata/math_testcases.txthttps://github.com/python/cpython/pull/155980/files#diff-944c900284c68b688cb7b3cfe9a43f9cb4c8a97d9c772ee6b815441d5dac89e1
View file https://github.com/jepler/cpython/blob/f7a4d0af8f864c0759b2aa0e403448bc0e91f4ae/Lib/test/mathdata/math_testcases.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155980/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155980/files#diff-944c900284c68b688cb7b3cfe9a43f9cb4c8a97d9c772ee6b815441d5dac89e1
https://github.com/python/cpython/pull/155980/files#diff-944c900284c68b688cb7b3cfe9a43f9cb4c8a97d9c772ee6b815441d5dac89e1
https://github.com/python/cpython/pull/155980/files#diff-944c900284c68b688cb7b3cfe9a43f9cb4c8a97d9c772ee6b815441d5dac89e1
https://github.com/python/cpython/pull/155980/files#diff-944c900284c68b688cb7b3cfe9a43f9cb4c8a97d9c772ee6b815441d5dac89e1
Lib/test/test_math.pyhttps://github.com/python/cpython/pull/155980/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
View file https://github.com/jepler/cpython/blob/f7a4d0af8f864c0759b2aa0e403448bc0e91f4ae/Lib/test/test_math.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155980/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155980/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
https://github.com/python/cpython/pull/155980/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
Misc/NEWS.d/next/Library/2026-08-17-17-39-41.gh-issue-155966.0YOADY.rsthttps://github.com/python/cpython/pull/155980/files#diff-e636969bd0800ac7122430628bf94e16e4d6981b00db3f705f36e402afc73171
View file https://github.com/jepler/cpython/blob/f7a4d0af8f864c0759b2aa0e403448bc0e91f4ae/Misc/NEWS.d/next/Library/2026-08-17-17-39-41.gh-issue-155966.0YOADY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155980/{{ revealButtonHref }}
Modules/mathmodule.chttps://github.com/python/cpython/pull/155980/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
View file https://github.com/jepler/cpython/blob/f7a4d0af8f864c0759b2aa0e403448bc0e91f4ae/Modules/mathmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155980/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155980/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/155980/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Please reload this pagehttps://github.com/python/cpython/pull/155980/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.