René's URL Explorer Experiment


Title: gh-150942: Speed up re.split result building by snurf198 · Pull Request #155940 · python/cpython · GitHub

Open Graph Title: gh-150942: Speed up re.split result building by snurf198 · Pull Request #155940 · python/cpython

X Title: gh-150942: Speed up re.split result building by snurf198 · Pull Request #155940 · python/cpython

Description: @hugovk @corona10 Append result items to the output list with _PyList_AppendTakeRef instead of PyList_Append followed by Py_DECREF, removing a reference-count round-trip per appended item (and a per-append lock on the free-threaded build). This is the same change gh-150943 made to re.findall and re.sub/subn, applied to the one result-building loop it left behind. The error: label only drops list, and _PyList_AppendTakeRef steals the reference on failure too, so the error path is unchanged. Microbenchmarks Default build Benchmark main this PR speedup re_split 4.54 ms 4.31 ms 1.05× re_split_groups 5.52 ms 5.23 ms 1.06× re_split_ws 4.18 ms 4.03 ms 1.04× re_split_bytes 4.08 ms 3.95 ms 1.03× str_split_control 1.37 ms 1.37 ms 1.00× geomean 1.03× Free-threading build Benchmark main this PR speedup re_split 6.48 ms 5.84 ms 1.11× re_split_groups 8.05 ms 6.81 ms 1.18× re_split_ws 5.74 ms 5.26 ms 1.09× re_split_bytes 6.13 ms 5.39 ms 1.14× str_split_control not significant geomean 1.08× Benchmark script """Microbenchmark re.split (result-list building).""" import re import pyperf WORDS = "the quick brown fox jumps over the lazy dog " * 2000 CSVISH = "field1,field2,field3,field4,field5,field6,field7,field8\n" * 3000 CSVISH_BYTES = CSVISH.encode() split_re = re.compile(r"[,\n]") group_re = re.compile(r"([,\n])") ws_re = re.compile(r"\s+") bytes_re = re.compile(rb"[,\n]") nomatch_re = re.compile(r"[;|]") def b_split(): return split_re.split(CSVISH) def b_split_groups(): return group_re.split(CSVISH) def b_split_ws(): return ws_re.split(WORDS) def b_split_bytes(): return bytes_re.split(CSVISH_BYTES) def b_split_nomatch(): return nomatch_re.split(CSVISH) def b_str_split(): return CSVISH.split(",") if __name__ == "__main__": runner = pyperf.Runner() runner.bench_func("re_split", b_split) runner.bench_func("re_split_groups", b_split_groups) runner.bench_func("re_split_ws", b_split_ws) runner.bench_func("re_split_bytes", b_split_bytes) runner.bench_func("re_split_nomatch", b_split_nomatch) runner.bench_func("str_split_control", b_str_split) Issue: gh-150942

Open Graph Description: @hugovk @corona10 Append result items to the output list with _PyList_AppendTakeRef instead of PyList_Append followed by Py_DECREF, removing a reference-count round-trip per appended item (and a pe...

X Description: @hugovk @corona10 Append result items to the output list with _PyList_AppendTakeRef instead of PyList_Append followed by Py_DECREF, removing a reference-count round-trip per appended item (and a pe...

Opengraph URL: https://github.com/python/cpython/pull/155940

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b93bc70e-8528-c972-9d84-9d696e85cd59
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9F0:3A4875:3863BDB:4B0DBD8:6B0216D5
html-safe-noncec4e66801be8e902d1e55f9a67209babc7929978bf91da16d80e058e6b37e0f32
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUYwOjNBNDg3NTozODYzQkRCOjRCMERCRDg6NkIwMjE2RDUiLCJ2aXNpdG9yX2lkIjoiNjYyMDAyMzY5Mjg4Mzc5MzYyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9b678b050ea37ca2005ca0a74f40b7775bad36068c0905688bdd1806422df0d5
hovercard-subject-tagpull_request:4293927233
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155940/files
twitter:imagehttps://avatars.githubusercontent.com/u/55132820?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55132820?s=400&v=4
og:image:alt@hugovk @corona10 Append result items to the output list with _PyList_AppendTakeRef instead of PyList_Append followed by Py_DECREF, removing a reference-count round-trip per appended item (and a pe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155940/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155940%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155940%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155940/files
Reloadhttps://github.com/python/cpython/pull/155940/files
Reloadhttps://github.com/python/cpython/pull/155940/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
corona10https://github.com/corona10
python:mainhttps://github.com/python/cpython/tree/main
snurf198:gh-150942-re-split-opthttps://github.com/snurf198/cpython/tree/gh-150942-re-split-opt
Conversation 3 https://github.com/python/cpython/pull/155940
Commits 2 https://github.com/python/cpython/pull/155940/commits
Checks 58 https://github.com/python/cpython/pull/155940/checks
Files changed https://github.com/python/cpython/pull/155940/files
Please reload this pagehttps://github.com/python/cpython/pull/155940/files
gh-150942: Speed up re.split result building https://github.com/python/cpython/pull/155940/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/155940/files
bebd549 gh-150942: Optimize :func:`re.split` performance by using reference-s… snurf198 Aug 17, 2026 https://github.com/python/cpython/pull/155940/commits/bebd549330f3a1e5c4d5a96c8b6340639e3355e3
5ffa72a Delete Misc/NEWS.d/next/Library/2026-08-17-14-49-02.gh-issue-150942.y… corona10 Aug 17, 2026 https://github.com/python/cpython/pull/155940/commits/5ffa72ab0db194d7bd202765765c9923c0c82013
Clear filters https://github.com/python/cpython/pull/155940/files
Please reload this pagehttps://github.com/python/cpython/pull/155940/files
Please reload this pagehttps://github.com/python/cpython/pull/155940/files
Modules/_sre/sre.chttps://github.com/python/cpython/pull/155940/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
View file https://github.com/snurf198/cpython/blob/5ffa72ab0db194d7bd202765765c9923c0c82013/Modules/_sre/sre.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155940/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155940/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
https://github.com/python/cpython/pull/155940/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
https://github.com/python/cpython/pull/155940/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
https://github.com/python/cpython/pull/155940/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
Please reload this pagehttps://github.com/python/cpython/pull/155940/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.