René's URL Explorer Experiment


Title: gh-155935: Stop `FileFinder._find_children` retrying a failing directory scan by tobiaspal · Pull Request #155939 · python/cpython · GitHub

Open Graph Title: gh-155935: Stop `FileFinder._find_children` retrying a failing directory scan by tobiaspal · Pull Request #155939 · python/cpython

X Title: gh-155935: Stop `FileFinder._find_children` retrying a failing directory scan by tobiaspal · Pull Request #155939 · python/cpython

Description: Split the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new PathEntryFinder.discover() API proposed in gh-139899) scans a directory in a while True: loop and ignores any OSError without ending the loop. The except OSError: pass covers two different failure sources: next(scan_iterator) and the os.DirEntry methods. For a DirEntry method (is_dir()/is_file() racing a deletion), skipping the entry is correct. But when next(scan_iterator) itself fails persistently (stale NFS handle, disconnected removable volume) every retry raises the same OSError again, StopIteration never arrives, and the loop never terminates. Found via @devdanzin's AI-assisted audit of Lib/; working on it at the PyCon Korea 2026 sprint. Claude Code helped to write the tests and the fix. Issue: gh-155935

Open Graph Description: Split the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new...

X Description: Split the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new...

Opengraph URL: https://github.com/python/cpython/pull/155939

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9a91ecc2-2536-781c-812f-2fabc0b1745b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD25E:23E48:5B2747:725E4D:6B021739
html-safe-nonce04ec2e1f3dbbf2acd15fc8ac1a949fcef411a875ec60ddcc0352b22ea730cdbd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjVFOjIzRTQ4OjVCMjc0Nzo3MjVFNEQ6NkIwMjE3MzkiLCJ2aXNpdG9yX2lkIjoiMjc3NTMyNTk1MDU1OTI2MjUyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc5516146e2f7ba4e515a77c0c93e8d7d40515daa3f325056b9e6198716e778ed
hovercard-subject-tagpull_request:4293875986
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155939/files
twitter:imagehttps://avatars.githubusercontent.com/u/297953?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/297953?s=400&v=4
og:image:altSplit the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155939/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155939%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155939%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155939/files
Reloadhttps://github.com/python/cpython/pull/155939/files
Reloadhttps://github.com/python/cpython/pull/155939/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
FFY00https://github.com/FFY00
python:mainhttps://github.com/python/cpython/tree/main
tobiaspal:gh-155935-find-children-loophttps://github.com/tobiaspal/cpython/tree/gh-155935-find-children-loop
Conversation 4 https://github.com/python/cpython/pull/155939
Commits 1 https://github.com/python/cpython/pull/155939/commits
Checks 61 https://github.com/python/cpython/pull/155939/checks
Files changed https://github.com/python/cpython/pull/155939/files
Please reload this pagehttps://github.com/python/cpython/pull/155939/files
gh-155935: Stop FileFinder._find_children retrying a failing directory scan https://github.com/python/cpython/pull/155939/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/155939/files
929338d gh-155935: Stop `FileFinder._find_children` retrying a failing direct… tobiaspal Aug 17, 2026 https://github.com/python/cpython/pull/155939/commits/929338d28d62551dcf52d9ae646eae1dd79f5cc0
Clear filters https://github.com/python/cpython/pull/155939/files
Please reload this pagehttps://github.com/python/cpython/pull/155939/files
Please reload this pagehttps://github.com/python/cpython/pull/155939/files
_bootstrap_external.py https://github.com/python/cpython/pull/155939/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
test_discover.py https://github.com/python/cpython/pull/155939/files#diff-9d878bbac4e052631a9413934a9d7f74f4e1e34dcb9c062befe58b1af2739484
2026-08-17-06-07-49.gh-issue-155935.lbMPKW.rst https://github.com/python/cpython/pull/155939/files#diff-a95a7c1c1153a25f0c943724ae5167fa4f1e3e5b705be877142fc6e971f4b241
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L261
Lib/importlib/_bootstrap_external.pyhttps://github.com/python/cpython/pull/155939/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
View file https://github.com/tobiaspal/cpython/blob/929338d28d62551dcf52d9ae646eae1dd79f5cc0/Lib/importlib/_bootstrap_external.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155939/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155939/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
picnixzhttps://github.com/picnixz
Aug 17, 2026https://github.com/python/cpython/pull/155939/files#r3795185305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/155939/files
https://github.com/python/cpython/pull/155939/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
https://github.com/python/cpython/pull/155939/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L261
Lib/test/test_importlib/test_discover.pyhttps://github.com/python/cpython/pull/155939/files#diff-9d878bbac4e052631a9413934a9d7f74f4e1e34dcb9c062befe58b1af2739484
View file https://github.com/tobiaspal/cpython/blob/929338d28d62551dcf52d9ae646eae1dd79f5cc0/Lib/test/test_importlib/test_discover.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155939/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155939/files#diff-9d878bbac4e052631a9413934a9d7f74f4e1e34dcb9c062befe58b1af2739484
https://github.com/python/cpython/pull/155939/files#diff-9d878bbac4e052631a9413934a9d7f74f4e1e34dcb9c062befe58b1af2739484
https://github.com/python/cpython/pull/155939/files#diff-9d878bbac4e052631a9413934a9d7f74f4e1e34dcb9c062befe58b1af2739484
Misc/NEWS.d/next/Library/2026-08-17-06-07-49.gh-issue-155935.lbMPKW.rsthttps://github.com/python/cpython/pull/155939/files#diff-a95a7c1c1153a25f0c943724ae5167fa4f1e3e5b705be877142fc6e971f4b241
View file https://github.com/tobiaspal/cpython/blob/929338d28d62551dcf52d9ae646eae1dd79f5cc0/Misc/NEWS.d/next/Library/2026-08-17-06-07-49.gh-issue-155935.lbMPKW.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155939/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/155939/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.