René's URL Explorer Experiment


Title: gh-155935: Stop `FileFinder._find_children` retrying a failing directory scan by tobiaspal · Pull Request #155939 · python/cpython · GitHub

Open Graph Title: gh-155935: Stop `FileFinder._find_children` retrying a failing directory scan by tobiaspal · Pull Request #155939 · python/cpython

X Title: gh-155935: Stop `FileFinder._find_children` retrying a failing directory scan by tobiaspal · Pull Request #155939 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Split the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new...

X Description: Split the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new...

Opengraph URL: https://github.com/python/cpython/pull/155939

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5efbe9cb-e8d7-48b5-5172-6895dc5d8958
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99EA:EAD6D:1B473F:221453:6B0201D6
html-safe-nonce38c15db29d953c84c18a1f762f6f8bdabcc6db88b7d1141b8f62b8e701d96189
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUVBOkVBRDZEOjFCNDczRjoyMjE0NTM6NkIwMjAxRDYiLCJ2aXNpdG9yX2lkIjoiNDIxODYyMzIxMDQzMTg0MDcyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac504a86e69a1fc994cc6d19913b400a0062107a9f0e45830a9b18113d07addb8f
hovercard-subject-tagpull_request:4293875986
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/155939/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/46ab3cc7809eb3a6e9b3ec50600274fe6dfa67ddafca466d7c5e46276b470610/python/cpython/pull/155939
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/46ab3cc7809eb3a6e9b3ec50600274fe6dfa67ddafca466d7c5e46276b470610/python/cpython/pull/155939
og:image:altSplit the OSError handling: an OSError from next() ends the listing, while one from is_dir() or is_file() skips just that entry. FileFinder._find_children() (added by gh-139900 implementing the new...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametobiaspal
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/155939#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155939
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155939
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155939
Reloadhttps://github.com/python/cpython/pull/155939
Reloadhttps://github.com/python/cpython/pull/155939
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
FFY00https://github.com/FFY00
python:mainhttps://github.com/python/cpython/tree/main
tobiaspal:gh-155935-find-children-loophttps://github.com/tobiaspal/cpython/tree/gh-155935-find-children-loop
Conversationhttps://github.com/python/cpython/pull/155939
Commits1 (1)https://github.com/python/cpython/pull/155939/commits
Checkshttps://github.com/python/cpython/pull/155939/checks
Files changedhttps://github.com/python/cpython/pull/155939/files
gh-155935: Stop FileFinder._find_children retrying a failing directory scanhttps://github.com/python/cpython/pull/155939#top
FFY00https://github.com/FFY00
python:mainhttps://github.com/python/cpython/tree/main
tobiaspal:gh-155935-find-children-loophttps://github.com/tobiaspal/cpython/tree/gh-155935-find-children-loop
https://github.com/tobiaspal
tobiaspalhttps://github.com/tobiaspal
Aug 17, 2026https://github.com/python/cpython/pull/155939#issue-5169035690
Please reload this pagehttps://github.com/python/cpython/pull/155939
gh-139900https://github.com/python/cpython/pull/139900
gh-139899https://github.com/python/cpython/issues/139899
@devdanzin's AI-assisted audit of Lib/https://gist.github.com/devdanzin/3198710e3c0128fda5e0a7b4e0768e5f#30-filefinder_find_children-can-loop-forever-on-a-persistently-failing-directory-scan
FileFinder._find_children can loop forever on a persistently failing directory scan #155935https://github.com/python/cpython/issues/155935
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/tobiaspal
pythongh-155935https://github.com/python/cpython/issues/155935
: Stophttps://github.com/python/cpython/pull/155939/commits/929338d28d62551dcf52d9ae646eae1dd79f5cc0
FileFinder._find_childrenhttps://github.com/python/cpython/pull/155939/commits/929338d28d62551dcf52d9ae646eae1dd79f5cc0
retrying a failing …https://github.com/python/cpython/pull/155939/commits/929338d28d62551dcf52d9ae646eae1dd79f5cc0
929338dhttps://github.com/python/cpython/pull/155939/commits/929338d28d62551dcf52d9ae646eae1dd79f5cc0
https://github.com/tobiaspal
tobiaspalhttps://github.com/tobiaspal
FFY00https://github.com/FFY00
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/c3df37cb62e5864f2c7bf654de131d701820f999/.github/CODEOWNERS#L257
August 17, 2026 06:39https://github.com/python/cpython/pull/155939#event-29546545969
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 17, 2026 https://github.com/python/cpython/pull/155939#ref-issue-5168814576
FileFinder._find_children can loop forever on a persistently failing directory scan #155935 https://github.com/python/cpython/issues/155935
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 17, 2026https://github.com/python/cpython/pull/155939#event-29546550902
https://github.com/corona10
corona10https://github.com/corona10
sprint https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Asprint
Aug 17, 2026https://github.com/python/cpython/pull/155939#event-29548125342
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprinthttps://github.com/orgs/python/projects/32
Aug 17, 2026https://github.com/python/cpython/pull/155939#event-29548128759
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprinthttps://github.com/orgs/python/projects/32
Aug 17, 2026https://github.com/python/cpython/pull/155939#event-29548128020
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Aug 17, 2026 https://github.com/python/cpython/pull/155939#pullrequestreview-4950172731
View reviewed changes https://github.com/python/cpython/pull/155939/files/929338d28d62551dcf52d9ae646eae1dd79f5cc0
Lib/importlib/_bootstrap_external.pyhttps://github.com/python/cpython/pull/155939/files/929338d28d62551dcf52d9ae646eae1dd79f5cc0#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
picnixzhttps://github.com/picnixz
Aug 17, 2026https://github.com/python/cpython/pull/155939#discussion_r3795185305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 17, 2026https://github.com/python/cpython/pull/155939#issuecomment-6956587382
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Nov 17, 2026https://github.com/python/cpython/pull/155939#event-36438668063
https://github.com/FFY00
FFY00https://github.com/FFY00
Nov 20, 2026 https://github.com/python/cpython/pull/155939#pullrequestreview-5993397670
View reviewed changes https://github.com/python/cpython/pull/155939/files/929338d28d62551dcf52d9ae646eae1dd79f5cc0
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprinthttps://github.com/orgs/python/projects/32
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772676244
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772678221
https://github.com/FFY00
FFY00https://github.com/FFY00
4d342ebhttps://github.com/python/cpython/commit/4d342eb907bff64ac99825faec95f73584ebf334
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772715948
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772722389
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprinthttps://github.com/orgs/python/projects/32
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772722454
https://github.com/FFY00
FFY00https://github.com/FFY00
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772857050
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 20, 2026https://github.com/python/cpython/pull/155939#issuecomment-7040745919
@tobiaspalhttps://github.com/tobiaspal
@FFY00https://github.com/FFY00
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 20, 2026https://github.com/python/cpython/pull/155939#issuecomment-7040749004
GH-162324https://github.com/python/cpython/pull/162324
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 20, 2026https://github.com/python/cpython/pull/155939#event-36772876814
FFY00https://github.com/FFY00
Nov 20, 2026 https://github.com/python/cpython/pull/155939#ref-commit-ab9e306
https://github.com/miss-islington
https://github.com/tobiaspal
[3.15]https://github.com/python/cpython/commit/ab9e3065c829069c5bd4ce076959a0926b656de6
gh-155935https://github.com/python/cpython/issues/155935
: Stophttps://github.com/python/cpython/commit/ab9e3065c829069c5bd4ce076959a0926b656de6
FileFinder._find_childrenhttps://github.com/python/cpython/commit/ab9e3065c829069c5bd4ce076959a0926b656de6
retrying a failing…https://github.com/python/cpython/commit/ab9e3065c829069c5bd4ce076959a0926b656de6
ab9e306https://github.com/python/cpython/commit/ab9e3065c829069c5bd4ce076959a0926b656de6
GH-155939https://github.com/python/cpython/pull/155939
#162324https://github.com/python/cpython/pull/162324
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155939
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/155939/files/929338d28d62551dcf52d9ae646eae1dd79f5cc0
https://github.com/FFY00
FFY00 https://github.com/FFY00
https://github.com/python/cpython/pull/155939/files/929338d28d62551dcf52d9ae646eae1dd79f5cc0
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
Please reload this pagehttps://github.com/python/cpython/pull/155939
sprint https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Asprint
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Sprint https://github.com/orgs/python/projects/32
Please reload this pagehttps://github.com/python/cpython/pull/155939
https://github.com/tobiaspal
https://github.com/picnixz
https://github.com/FFY00
https://github.com/corona10
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.