René's URL Explorer Experiment


Title: gh-155934: Fix socket leak and silent error for asyncio accepted connections by danielKim614 · Pull Request #155936 · python/cpython · GitHub

Open Graph Title: gh-155934: Fix socket leak and silent error for asyncio accepted connections by danielKim614 · Pull Request #155936 · python/cpython

X Title: gh-155934: Fix socket leak and silent error for asyncio accepted connections by danielKim614 · Pull Request #155936 · python/cpython

Description: When protocol_factory() or transport creation raises for an accepted connection in BaseSelectorEventLoop._accept_connection2(), close the accepted socket (it would otherwise leak until garbage collection) and report the error via the loop exception handler even when debug mode is disabled. Reporting stays debug-only once the transport exists, so await waiter failures such as SSL handshake errors from port scanners are not reported unconditionally. This is the server-side counterpart of gh-153134 (GH-153133). The new tests fail without the fix and pass with it. The full test_asyncio suite passes, including -R 3:3 refleak runs on test_selector_events. cc. Pycon 2026 KR Sprint @hugovk @corona10 Issue: gh-155934

Open Graph Description: When protocol_factory() or transport creation raises for an accepted connection in BaseSelectorEventLoop._accept_connection2(), close the accepted socket (it would otherwise leak until garbage coll...

X Description: When protocol_factory() or transport creation raises for an accepted connection in BaseSelectorEventLoop._accept_connection2(), close the accepted socket (it would otherwise leak until garbage coll...

Opengraph URL: https://github.com/python/cpython/pull/155936

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c02157b-20eb-7320-7370-90b12a817cb3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92AE:E9D16:3C516E6:4C68F10:6B023B93
html-safe-noncefc167c15a82c2acf2271da98779b4c195a89113fd47365f04c714826e6207ef3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkFFOkU5RDE2OjNDNTE2RTY6NEM2OEYxMDo2QjAyM0I5MyIsInZpc2l0b3JfaWQiOiIyOTUyOTA5NTM4MTQ1MjIxNTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac56954e4f99a30f038eb0db9dc79350077fd77cf56bf9bb9b5e86bc2e85988ea4
hovercard-subject-tagpull_request:4293722657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155936/files
twitter:imagehttps://avatars.githubusercontent.com/u/78344167?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/78344167?s=400&v=4
og:image:altWhen protocol_factory() or transport creation raises for an accepted connection in BaseSelectorEventLoop._accept_connection2(), close the accepted socket (it would otherwise leak until garbage coll...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155936/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155936%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155936%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155936/files
Reloadhttps://github.com/python/cpython/pull/155936/files
Reloadhttps://github.com/python/cpython/pull/155936/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
danielKim614:gh-155934-accept-errorhttps://github.com/danielKim614/cpython/tree/gh-155934-accept-error
Conversation 12 https://github.com/python/cpython/pull/155936
Commits 3 https://github.com/python/cpython/pull/155936/commits
Checks 65 https://github.com/python/cpython/pull/155936/checks
Files changed https://github.com/python/cpython/pull/155936/files
Please reload this pagehttps://github.com/python/cpython/pull/155936/files
gh-155934: Fix socket leak and silent error for asyncio accepted connections https://github.com/python/cpython/pull/155936/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/155936/files
51a03c8 gh-155934: Fix socket leak and silent error for asyncio accepted conn… danielKim614 Aug 17, 2026 https://github.com/python/cpython/pull/155936/commits/51a03c8407f5a21493f2bff33a40914f84c01b2b
9ad4b31 Merge branch 'main' into gh-155934-accept-error danielKim614 Aug 22, 2026 https://github.com/python/cpython/pull/155936/commits/9ad4b31ac8874dcd4e50d224b36e6bb8fc249653
9f6dbe5 Merge branch 'main' into gh-155934-accept-error danielKim614 Aug 23, 2026 https://github.com/python/cpython/pull/155936/commits/9f6dbe58d096842ad3dcd17bcebef2bbc534f9d0
Clear filters https://github.com/python/cpython/pull/155936/files
Please reload this pagehttps://github.com/python/cpython/pull/155936/files
Please reload this pagehttps://github.com/python/cpython/pull/155936/files
selector_events.py https://github.com/python/cpython/pull/155936/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
test_selector_events.py https://github.com/python/cpython/pull/155936/files#diff-6e37e524632f0e5f40ac46ea06ed508dc3b08f9ec1e8c07cf97537913f056a6b
2026-08-17-18-00-00.gh-issue-155934.acCept.rst https://github.com/python/cpython/pull/155936/files#diff-eb46b21db52e58f67c8f8fa093578f9b3f32748cc371bbe7ce3149a318850719
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L376
Lib/asyncio/selector_events.pyhttps://github.com/python/cpython/pull/155936/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
View file https://github.com/danielKim614/cpython/blob/9f6dbe58d096842ad3dcd17bcebef2bbc534f9d0/Lib/asyncio/selector_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155936/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155936/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/155936/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L377
Lib/test/test_asyncio/test_selector_events.pyhttps://github.com/python/cpython/pull/155936/files#diff-6e37e524632f0e5f40ac46ea06ed508dc3b08f9ec1e8c07cf97537913f056a6b
View file https://github.com/danielKim614/cpython/blob/9f6dbe58d096842ad3dcd17bcebef2bbc534f9d0/Lib/test/test_asyncio/test_selector_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155936/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155936/files#diff-6e37e524632f0e5f40ac46ea06ed508dc3b08f9ec1e8c07cf97537913f056a6b
https://github.com/python/cpython/pull/155936/files#diff-6e37e524632f0e5f40ac46ea06ed508dc3b08f9ec1e8c07cf97537913f056a6b
Misc/NEWS.d/next/Library/2026-08-17-18-00-00.gh-issue-155934.acCept.rsthttps://github.com/python/cpython/pull/155936/files#diff-eb46b21db52e58f67c8f8fa093578f9b3f32748cc371bbe7ce3149a318850719
View file https://github.com/danielKim614/cpython/blob/9f6dbe58d096842ad3dcd17bcebef2bbc534f9d0/Misc/NEWS.d/next/Library/2026-08-17-18-00-00.gh-issue-155934.acCept.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155936/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/155936/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.