René's URL Explorer Experiment


Title: gh-155811: Add a seqcount to `gc_stats` to prevent torn reads by maurycy · Pull Request #155828 · python/cpython · GitHub

Open Graph Title: gh-155811: Add a seqcount to `gc_stats` to prevent torn reads by maurycy · Pull Request #155828 · python/cpython

X Title: gh-155811: Add a seqcount to `gc_stats` to prevent torn reads by maurycy · Pull Request #155828 · python/cpython

Description: See #155811 for the context. tl;dr get_gc_stats reads the stats without pausing the target (by design), so it can return torn data. The PR adds a seqcount to gc_stats atomically increased by the writer around the stats update on every collection, where odd means it's in progress. gcmon is the main consumer. There's no retry, as per #155811 (comment). It's not needed. gc.collect() does not happen that often: 2026-08-15T10:53:48.504627000+0200 maurycy@gimel /Users/maurycy/work/cpython (gc-mon-seq 1291568?) % sudo ./python.exe gc_seq_collision.py successes=1966598 failures=191 GC stats changed while being read; retry later For: import subprocess import sys import time import _remote_debugging target = """ import gc import os import time print(os.getpid(), flush=True) while True: gc.collect(0) time.sleep(0.01) """ p = subprocess.Popen( [sys.executable, "-c", target], stdout=subprocess.PIPE, text=True, ) try: pid = int(p.stdout.readline()) monitor = _remote_debugging.GCMonitor(pid, debug=True) successes = 0 failures = 0 messages = set() deadline = time.monotonic() + 10.0 while time.monotonic() < deadline: try: monitor.get_gc_stats(all_interpreters=False) successes += 1 except RuntimeError as exc: failures += 1 messages.add(str(exc)) print(f"successes={successes} failures={failures}") for message in sorted(messages): print(message) finally: p.terminate() p.wait() I'm not sure what's optimal non-hacky test. We haven't had one in #152448. To be honest, it's implicitly tested by the current happy-path tests in test_gc_stats. Issue: gh-155811

Open Graph Description: See #155811 for the context. tl;dr get_gc_stats reads the stats without pausing the target (by design), so it can return torn data. The PR adds a seqcount to gc_stats atomically increased by the wr...

X Description: See #155811 for the context. tl;dr get_gc_stats reads the stats without pausing the target (by design), so it can return torn data. The PR adds a seqcount to gc_stats atomically increased by the wr...

Opengraph URL: https://github.com/python/cpython/pull/155828

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7cf5b1e2-7ac3-6c60-9c49-b06dbc0293e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A26:AFBD9:1B50BD7:23F2C87:6B021EA8
html-safe-noncea59e1f5bf2744aa9beaff86cd5f7a644e40fe8bb96ead58c6303d734ecf69255
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTI2OkFGQkQ5OjFCNTBCRDc6MjNGMkM4Nzo2QjAyMUVBOCIsInZpc2l0b3JfaWQiOiIzOTkyNjM0MTI1OTQ0MjMzNjQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac782bfecc5b0195b66521acb5a0935636f00148abaf092eb8512441ddcb5270ac
hovercard-subject-tagpull_request:4285585400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155828/files
twitter:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
og:image:altSee #155811 for the context. tl;dr get_gc_stats reads the stats without pausing the target (by design), so it can return torn data. The PR adds a seqcount to gc_stats atomically increased by the wr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155828/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155828%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155828%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155828/files
Reloadhttps://github.com/python/cpython/pull/155828/files
Reloadhttps://github.com/python/cpython/pull/155828/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
maurycy:gc-mon-seqhttps://github.com/maurycy/cpython/tree/gc-mon-seq
Conversation 22 https://github.com/python/cpython/pull/155828
Commits 4 https://github.com/python/cpython/pull/155828/commits
Checks 61 https://github.com/python/cpython/pull/155828/checks
Files changed https://github.com/python/cpython/pull/155828/files
Please reload this pagehttps://github.com/python/cpython/pull/155828/files
gh-155811: Add a seqcount to gc_stats to prevent torn reads https://github.com/python/cpython/pull/155828/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/155828/files
1291568 update_seq maurycy Aug 15, 2026 https://github.com/python/cpython/pull/155828/commits/12915685610999d7e2c93b296862753425d79978
0cb2510 no need for XCHGL, MOVL is enough? maurycy Aug 15, 2026 https://github.com/python/cpython/pull/155828/commits/0cb2510028c2c87c271ceb2efecfcecfa1986c80
424b95f Merge branch 'main' into gc-mon-seq maurycy Oct 4, 2026 https://github.com/python/cpython/pull/155828/commits/424b95f9a3f6137a7ecefade02bd063dcfa61c7f
577305e gh-155811: Retry an inconsistent GC snapshot once pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/155828/commits/577305e2bc0efc98043b84d7a7da949290a82467
Clear filters https://github.com/python/cpython/pull/155828/files
Please reload this pagehttps://github.com/python/cpython/pull/155828/files
Please reload this pagehttps://github.com/python/cpython/pull/155828/files
pycore_interp_structs.h https://github.com/python/cpython/pull/155828/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
2026-08-15-10-20-40.gh-issue-155811.knP-YB.rst https://github.com/python/cpython/pull/155828/files#diff-49b7a9885046dda47ce57a2fd570df3285bca1aeee3744ade4b6263e631d3bfd
gc_stats.c https://github.com/python/cpython/pull/155828/files#diff-52b890be9f75fe3e9b8842a8e94badb45063f5171c95631af6aa9be01e88fa1a
gc.c https://github.com/python/cpython/pull/155828/files#diff-a848a0ef178aa113a092e72403da0e344f37bd141bb90a7aa65015c77bfe7385
gc_free_threading.c https://github.com/python/cpython/pull/155828/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
Include/internal/pycore_interp_structs.hhttps://github.com/python/cpython/pull/155828/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
View file https://github.com/maurycy/cpython/blob/577305e2bc0efc98043b84d7a7da949290a82467/Include/internal/pycore_interp_structs.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155828/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155828/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
https://github.com/python/cpython/pull/155828/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
Misc/NEWS.d/next/Library/2026-08-15-10-20-40.gh-issue-155811.knP-YB.rsthttps://github.com/python/cpython/pull/155828/files#diff-49b7a9885046dda47ce57a2fd570df3285bca1aeee3744ade4b6263e631d3bfd
View file https://github.com/maurycy/cpython/blob/577305e2bc0efc98043b84d7a7da949290a82467/Misc/NEWS.d/next/Library/2026-08-15-10-20-40.gh-issue-155811.knP-YB.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155828/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/gc_stats.chttps://github.com/python/cpython/pull/155828/files#diff-52b890be9f75fe3e9b8842a8e94badb45063f5171c95631af6aa9be01e88fa1a
View file https://github.com/maurycy/cpython/blob/577305e2bc0efc98043b84d7a7da949290a82467/Modules/_remote_debugging/gc_stats.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155828/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155828/files#diff-52b890be9f75fe3e9b8842a8e94badb45063f5171c95631af6aa9be01e88fa1a
https://github.com/python/cpython/pull/155828/files#diff-52b890be9f75fe3e9b8842a8e94badb45063f5171c95631af6aa9be01e88fa1a
Python/gc.chttps://github.com/python/cpython/pull/155828/files#diff-a848a0ef178aa113a092e72403da0e344f37bd141bb90a7aa65015c77bfe7385
View file https://github.com/maurycy/cpython/blob/577305e2bc0efc98043b84d7a7da949290a82467/Python/gc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155828/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155828/files#diff-a848a0ef178aa113a092e72403da0e344f37bd141bb90a7aa65015c77bfe7385
https://github.com/python/cpython/pull/155828/files#diff-a848a0ef178aa113a092e72403da0e344f37bd141bb90a7aa65015c77bfe7385
https://github.com/python/cpython/pull/155828/files#diff-a848a0ef178aa113a092e72403da0e344f37bd141bb90a7aa65015c77bfe7385
Python/gc_free_threading.chttps://github.com/python/cpython/pull/155828/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
View file https://github.com/maurycy/cpython/blob/577305e2bc0efc98043b84d7a7da949290a82467/Python/gc_free_threading.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155828/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155828/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/155828/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/155828/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
Please reload this pagehttps://github.com/python/cpython/pull/155828/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.