René's URL Explorer Experiment


Title: gh-141174: Test re-stringifying a `ForwardRef` by dr-carlos · Pull Request #155689 · python/cpython · GitHub

Open Graph Title: gh-141174: Test re-stringifying a `ForwardRef` by dr-carlos · Pull Request #155689 · python/cpython

X Title: gh-141174: Test re-stringifying a `ForwardRef` by dr-carlos · Pull Request #155689 · python/cpython

Description: Currently, every ForwardRef.evaluate(format=Format.STRING) test in test_annotationlib is done with an empty __resolved_string_cache__, so there is no test that re-evaluations are correct (or that they actually use the cache). That is to say, the condition self.__resolved_str_cache__ is None is always true: cpython/Lib/annotationlib.py Line 244 in 025e7d2 if self.__resolved_str_cache__ is None: Thus, this PR adds a simple test to re-stringify a stringified fwdref. That said, I'm not 100% on whether the current test is correct: it's testing the behaviour that the cache has to be returned identically - which is the correct behaviour, and this test already tests the content of the cache - but I'm not sure if we want to cement that exact behaviour. So, happy to make it an equality (instead of identity) check if it's preferred.

Open Graph Description: Currently, every ForwardRef.evaluate(format=Format.STRING) test in test_annotationlib is done with an empty __resolved_string_cache__, so there is no test that re-evaluations are correct (or that t...

X Description: Currently, every ForwardRef.evaluate(format=Format.STRING) test in test_annotationlib is done with an empty __resolved_string_cache__, so there is no test that re-evaluations are correct (or that t...

Opengraph URL: https://github.com/python/cpython/pull/155689

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:24f351ba-fb4e-5ddf-5ae6-dcb7257a6364
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF5C:8AE25:1EA6F34:2880389:6B0236A6
html-safe-nonced5de5f3a56d58414d3ee9701e4e93a09398efd6d4d19ac73a4fe5b67ebab4337
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjVDOjhBRTI1OjFFQTZGMzQ6Mjg4MDM4OTo2QjAyMzZBNiIsInZpc2l0b3JfaWQiOiIyMDExNzY3MjA1ODQyMjY5ODYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a1b17e15a14b67ef1a925d234cc137b070792883d4715cd65368c257f575cf7
hovercard-subject-tagpull_request:4270155598
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155689/files
twitter:imagehttps://avatars.githubusercontent.com/u/77367421?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/77367421?s=400&v=4
og:image:altCurrently, every ForwardRef.evaluate(format=Format.STRING) test in test_annotationlib is done with an empty __resolved_string_cache__, so there is no test that re-evaluations are correct (or that t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155689/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155689%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155689%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155689/files
Reloadhttps://github.com/python/cpython/pull/155689/files
Reloadhttps://github.com/python/cpython/pull/155689/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
dr-carlos:annolib-test-re-eval-extra-nameshttps://github.com/dr-carlos/cpython/tree/annolib-test-re-eval-extra-names
Conversation 3 https://github.com/python/cpython/pull/155689
Commits 1 https://github.com/python/cpython/pull/155689/commits
Checks 64 https://github.com/python/cpython/pull/155689/checks
Files changed https://github.com/python/cpython/pull/155689/files
Please reload this pagehttps://github.com/python/cpython/pull/155689/files
gh-141174: Test re-stringifying a ForwardRef https://github.com/python/cpython/pull/155689/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/155689/files
f794565 Test that re-evaluating a `ForwardRef` with `STRING` format uses the … dr-carlos Aug 13, 2026 https://github.com/python/cpython/pull/155689/commits/f794565fe7535b2f4a2c112f7955dac3059cddb4
Clear filters https://github.com/python/cpython/pull/155689/files
Please reload this pagehttps://github.com/python/cpython/pull/155689/files
Please reload this pagehttps://github.com/python/cpython/pull/155689/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L366
Lib/test/test_annotationlib.pyhttps://github.com/python/cpython/pull/155689/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
View file https://github.com/dr-carlos/cpython/blob/f794565fe7535b2f4a2c112f7955dac3059cddb4/Lib/test/test_annotationlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155689/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155689/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/155689/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
Please reload this pagehttps://github.com/python/cpython/pull/155689/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.