René's URL Explorer Experiment


Title: gh-151377: Fix races updating type slots and subclasses by nascheme · Pull Request #155370 · python/cpython · GitHub

Open Graph Title: gh-151377: Fix races updating type slots and subclasses by nascheme · Pull Request #155370 · python/cpython

X Title: gh-151377: Fix races updating type slots and subclasses by nascheme · Pull Request #155370 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Avoid data race in fixup_slot_dispatchers(). Set _Py_TYPE_REVEALED_FLAG before the type is published PyType_FromMetaclass() now uses type_ready()/type_ready_publish() rather than PyType_Ready(), li...

X Description: Avoid data race in fixup_slot_dispatchers(). Set _Py_TYPE_REVEALED_FLAG before the type is published PyType_FromMetaclass() now uses type_ready()/type_ready_publish() rather than PyType_Ready(), li...

Opengraph URL: https://github.com/python/cpython/pull/155370

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c9436b0d-99b6-b03a-ad7a-5002a50e98ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC32:4D9F2:1694DC6:1DFA20C:6B0205F6
html-safe-nonce16a91cfc3779fe106fff41e50f9c16a07af90a75348096a12fe804595fbbd3a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzMyOjREOUYyOjE2OTREQzY6MURGQTIwQzo2QjAyMDVGNiIsInZpc2l0b3JfaWQiOiI3NDQxNTE1OTQxNDkxNTA4NzI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd9e42cf63b873158090c66399795bd7502392e7fd25d64e41e4ebb73ac0347d5
hovercard-subject-tagpull_request:4232313742
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/155370/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a4438079e3d2c78050017a39dbfcba6741d102558d6a62ca716d6d34e82bd5f2/python/cpython/pull/155370
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4438079e3d2c78050017a39dbfcba6741d102558d6a62ca716d6d34e82bd5f2/python/cpython/pull/155370
og:image:altAvoid data race in fixup_slot_dispatchers(). Set _Py_TYPE_REVEALED_FLAG before the type is published PyType_FromMetaclass() now uses type_ready()/type_ready_publish() rather than PyType_Ready(), li...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenascheme
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/155370#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155370
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155370
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155370
Reloadhttps://github.com/python/cpython/pull/155370
Reloadhttps://github.com/python/cpython/pull/155370
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-151377-type-data-racehttps://github.com/nascheme/cpython/tree/gh-151377-type-data-race
Conversationhttps://github.com/python/cpython/pull/155370
Commits7 (7)https://github.com/python/cpython/pull/155370/commits
Checkshttps://github.com/python/cpython/pull/155370/checks
Files changedhttps://github.com/python/cpython/pull/155370/files
gh-151377: Fix races updating type slots and subclasseshttps://github.com/python/cpython/pull/155370#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-151377-type-data-racehttps://github.com/nascheme/cpython/tree/gh-151377-type-data-race
https://github.com/nascheme
naschemehttps://github.com/nascheme
Aug 7, 2026https://github.com/python/cpython/pull/155370#issue-5094779860
Please reload this pagehttps://github.com/python/cpython/pull/155370
Data races on type slots and tp_subclasses between type_setattro and type_new / type_dealloc #151377https://github.com/python/cpython/issues/151377
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/nascheme
naschemehttps://github.com/nascheme
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Aug 7, 2026https://github.com/python/cpython/pull/155370#event-29145427283
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 7, 2026 https://github.com/python/cpython/pull/155370#ref-issue-4643042645
Data races on type slots and tp_subclasses between type_setattro and type_new / type_dealloc #151377 https://github.com/python/cpython/issues/151377
https://github.com/nascheme
https://github.com/lpyu001
pythongh-151377https://github.com/python/cpython/issues/151377
: Fix races updating type slots and subclasseshttps://github.com/python/cpython/pull/155370/commits/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
98bc1d4https://github.com/python/cpython/pull/155370/commits/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
https://github.com/nascheme
naschemehttps://github.com/nascheme
force-pushedhttps://github.com/python/cpython/compare/18ff10ea41f05a152902c767e8e15d8396abee0b..98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
18ff10ehttps://github.com/python/cpython/commit/18ff10ea41f05a152902c767e8e15d8396abee0b
98bc1d4https://github.com/python/cpython/commit/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
Compare https://github.com/python/cpython/compare/18ff10ea41f05a152902c767e8e15d8396abee0b..98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
August 8, 2026 22:50https://github.com/python/cpython/pull/155370#event-29169380634
https://github.com/nascheme
naschemehttps://github.com/nascheme
Aug 9, 2026 https://github.com/python/cpython/pull/155370#ref-pullrequest-5099834988
gh-155400: Fix deadlock with type_lock_prevent_release() #155401 https://github.com/python/cpython/pull/155401
https://github.com/nascheme
naschemehttps://github.com/nascheme
August 10, 2026 05:35https://github.com/python/cpython/pull/155370#event-29204059905
https://github.com/nascheme
naschemehttps://github.com/nascheme
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/87b120fdb58afd8f7cb79daa87122334e295b70c/.github/CODEOWNERS#L213
August 10, 2026 05:35https://github.com/python/cpython/pull/155370#event-29204060183
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 10, 2026https://github.com/python/cpython/pull/155370#event-29204061754
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Aug 12, 2026 https://github.com/python/cpython/pull/155370#pullrequestreview-4916455953
View reviewed changes https://github.com/python/cpython/pull/155370/files/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
Objects/typeobject.chttps://github.com/python/cpython/pull/155370/files/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Aug 12, 2026 https://github.com/python/cpython/pull/155370#pullrequestreview-4916486540
View reviewed changes https://github.com/python/cpython/pull/155370/files/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559
Objects/typeobject.chttps://github.com/python/cpython/pull/155370/files/98bc1d44bc66729d6043c1f90b6c6c0afa5d7559#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
release-blocker https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Arelease-blocker
Aug 12, 2026https://github.com/python/cpython/pull/155370#event-29349746760
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Release and Deferred blockers 🚫https://github.com/orgs/python/projects/2
Aug 12, 2026https://github.com/python/cpython/pull/155370#event-29349898002
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Release and Deferred blockers 🚫https://github.com/orgs/python/projects/2
Aug 12, 2026https://github.com/python/cpython/pull/155370#event-29349785375
naschemehttps://github.com/nascheme
August 12, 2026 08:45https://github.com/python/cpython/pull/155370#commits-pushed-8037758
https://github.com/nascheme
Remove confusing comment.https://github.com/python/cpython/pull/155370/commits/80377583d888d5d086cbd41f4dfc2366f510524e
8037758https://github.com/python/cpython/pull/155370/commits/80377583d888d5d086cbd41f4dfc2366f510524e
https://github.com/nascheme
Revert unneed code change.https://github.com/python/cpython/pull/155370/commits/b0988849983e92d8a49a93c8b11a5e33a3f0b603
b098884https://github.com/python/cpython/pull/155370/commits/b0988849983e92d8a49a93c8b11a5e33a3f0b603
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Aug 13, 2026 https://github.com/python/cpython/pull/155370#pullrequestreview-4923441816
View reviewed changes https://github.com/python/cpython/pull/155370/files/b0988849983e92d8a49a93c8b11a5e33a3f0b603
Objects/typeobject.chttps://github.com/python/cpython/pull/155370/files/b0988849983e92d8a49a93c8b11a5e33a3f0b603#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/nascheme
Remove 'initial' arg from type_ready_publish().https://github.com/python/cpython/pull/155370/commits/8b79946f980d0633dd40544448e6774323c2b39f
8b79946https://github.com/python/cpython/pull/155370/commits/8b79946f980d0633dd40544448e6774323c2b39f
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Aug 13, 2026 https://github.com/python/cpython/pull/155370#pullrequestreview-4929403243
View reviewed changes https://github.com/python/cpython/pull/155370/files/8b79946f980d0633dd40544448e6774323c2b39f
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 13, 2026https://github.com/python/cpython/pull/155370#event-29412442383
https://github.com/nascheme
Refactor type_ready_publish().https://github.com/python/cpython/pull/155370/commits/4b9793432be1d7130d43bd51023fec7258908b61
4b97934https://github.com/python/cpython/pull/155370/commits/4b9793432be1d7130d43bd51023fec7258908b61
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Aug 14, 2026 https://github.com/python/cpython/pull/155370#pullrequestreview-4939632008
View reviewed changes https://github.com/python/cpython/pull/155370/files/4b9793432be1d7130d43bd51023fec7258908b61
Objects/typeobject.chttps://github.com/python/cpython/pull/155370/files/4b9793432be1d7130d43bd51023fec7258908b61#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/155370
naschemehttps://github.com/nascheme
August 14, 2026 12:19https://github.com/python/cpython/pull/155370#commits-pushed-c9995d3
https://github.com/nascheme
Suppress warning about unused 'rv'.https://github.com/python/cpython/pull/155370/commits/c9995d364787048079c00cc361a59423790f04e3
c9995d3https://github.com/python/cpython/pull/155370/commits/c9995d364787048079c00cc361a59423790f04e3
https://github.com/nascheme
Merge remote-tracking branch 'origin/main' intohttps://github.com/python/cpython/pull/155370/commits/c14b94d23bc6c79e8d9de13c3334382766283805
pythongh-151377https://github.com/python/cpython/issues/151377
-type-…https://github.com/python/cpython/pull/155370/commits/c14b94d23bc6c79e8d9de13c3334382766283805
c14b94dhttps://github.com/python/cpython/pull/155370/commits/c14b94d23bc6c79e8d9de13c3334382766283805
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
07624efhttps://github.com/python/cpython/commit/07624ef11b924b39da97e978536f34f740e39575
Aug 15, 2026https://github.com/python/cpython/pull/155370#event-29490421049
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 15, 2026https://github.com/python/cpython/pull/155370#event-29490422038
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Release and Deferred blockers 🚫https://github.com/orgs/python/projects/2
Aug 15, 2026https://github.com/python/cpython/pull/155370#event-29490427834
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Aug 15, 2026https://github.com/python/cpython/pull/155370#issuecomment-5300397588
@naschemehttps://github.com/nascheme
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 15, 2026https://github.com/python/cpython/pull/155370#issuecomment-5300398596
GH-155821https://github.com/python/cpython/pull/155821
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Aug 15, 2026https://github.com/python/cpython/pull/155370#event-29490426934
hugovkhttps://github.com/hugovk
Aug 19, 2026 https://github.com/python/cpython/pull/155370#ref-commit-59c1e09
https://github.com/miss-islington
https://github.com/nascheme
[3.15]https://github.com/python/cpython/commit/59c1e09eecd91f41329f8fbd5f2d9f941e686c1e
gh-151377https://github.com/python/cpython/issues/151377
: Fix races updating type slots and subclasses (https://github.com/python/cpython/commit/59c1e09eecd91f41329f8fbd5f2d9f941e686c1e
GH-15…https://github.com/python/cpython/pull/155370
59c1e09https://github.com/python/cpython/commit/59c1e09eecd91f41329f8fbd5f2d9f941e686c1e
…5370https://github.com/python/cpython/pull/155370
#155821https://github.com/python/cpython/pull/155821
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155370
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/155370/files/4b9793432be1d7130d43bd51023fec7258908b61
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/155370
release-blocker https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Arelease-blocker
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Release and Deferred blockers 🚫 https://github.com/orgs/python/projects/2
Please reload this pagehttps://github.com/python/cpython/pull/155370
https://github.com/nascheme
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.