René's URL Explorer Experiment


Title: gh-154997: Guard stale self->raw access in bufferedio.c after reentrant detach() by BHUVANSH855 · Pull Request #155017 · python/cpython · GitHub

Open Graph Title: gh-154997: Guard stale self->raw access in bufferedio.c after reentrant detach() by BHUVANSH855 · Pull Request #155017 · python/cpython

X Title: gh-154997: Guard stale self->raw access in bufferedio.c after reentrant detach() by BHUVANSH855 · Pull Request #155017 · python/cpython

Description: Summary Fix stale self->raw accesses in buffered I/O objects after a reentrant detach(). Introduce a shared raw_access_safe() helper and use it before dispatching to the underlying raw stream from the remaining affected buffered I/O paths. This preserves the existing detached and uninitialized error semantics while avoiding dereferences of a stale self->raw pointer. The guarded call sites include: _io__Buffered_close_impl() _buffered_raw_tell() _buffered_raw_seek() _io__Buffered_truncate_impl() _bufferedreader_raw_read() _bufferedreader_read_all() _bufferedwriter_raw_write() Tests Added regression tests covering reentrant detach() during: close() raw read read_all() raw write truncate() post-truncate raw_tell() These tests verify that the affected operations raise the expected exception (or preserve the intended behavior for raw_tell()) instead of accessing a stale raw stream. The reproducer from the issue was also used to verify the patched code paths. Notes raw_seek() was intentionally left unchanged from a testing perspective. While it now benefits from the shared guard, it was not one of the original SIGSEGV cases and is outside the scope of this change. During testing, test_read1_error_does_not_cause_reentrant_failure was found to abort under ASan even on an unmodified main checkout due to unrelated allocator behavior, so it is not treated as a regression introduced by this patch. Issue: gh-154997

Open Graph Description: Summary Fix stale self->raw accesses in buffered I/O objects after a reentrant detach(). Introduce a shared raw_access_safe() helper and use it before dispatching to the underlying raw stream fr...

X Description: Summary Fix stale self->raw accesses in buffered I/O objects after a reentrant detach(). Introduce a shared raw_access_safe() helper and use it before dispatching to the underlying raw strea...

Opengraph URL: https://github.com/python/cpython/pull/155017

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3dc3e355-b78f-d4f5-2483-dfc296b343c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC2A:3E4205:3214447:42E89A1:6B01F816
html-safe-noncef0339e34108d0b2549ee8bf36012f7dcfb199857e5b6ae63d69d660fa16ddf28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzJBOjNFNDIwNTozMjE0NDQ3OjQyRTg5QTE6NkIwMUY4MTYiLCJ2aXNpdG9yX2lkIjoiMjg1NjMwNjU5MjU1NzY5Mjk1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf93e802a0bb2b0e3d6ee68139f39e6672b5b4df579959442bcb4ce9f9bab8824
hovercard-subject-tagpull_request:4183404846
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/155017/files
twitter:imagehttps://avatars.githubusercontent.com/u/185269030?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/185269030?s=400&v=4
og:image:altSummary Fix stale self->raw accesses in buffered I/O objects after a reentrant detach(). Introduce a shared raw_access_safe() helper and use it before dispatching to the underlying raw stream fr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/155017/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155017%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F155017%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/155017/files
Reloadhttps://github.com/python/cpython/pull/155017/files
Reloadhttps://github.com/python/cpython/pull/155017/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
BHUVANSH855https://github.com/BHUVANSH855
python:mainhttps://github.com/python/cpython/tree/main
BHUVANSH855:investigate-bufferedio-raw-detachhttps://github.com/BHUVANSH855/cpython/tree/investigate-bufferedio-raw-detach
Conversation 1 https://github.com/python/cpython/pull/155017
Commits 7 https://github.com/python/cpython/pull/155017/commits
Checks 49 https://github.com/python/cpython/pull/155017/checks
Files changed https://github.com/python/cpython/pull/155017/files
Please reload this pagehttps://github.com/python/cpython/pull/155017/files
gh-154997: Guard stale self->raw access in bufferedio.c after reentrant detach() https://github.com/python/cpython/pull/155017/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/155017/files
ebf6fa2 gh-154997: Guard stale raw access after reentrant detach BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/ebf6fa2aee9c4a428f28fa098a0d190573058c8f
fe6b706 gh-154997: Add NEWS entry BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/fe6b7066f9175be40bfd553733a5854925cd63fd
dff7ede gh-154997: Declare raw_access_safe before use BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/dff7edea4dab7ba2c858d6ab564660b55996731f
559722f gh-154997: Remove redundant raw_access_safe declaration BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/559722f712f47f1755fab7a568f3a631100225b8
406f674 gh-154997: Move raw_access_safe outside Clinic block BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/406f674413c8c0f79d04a6bbd255cec4d3d50a23
b49ff0b gh-154997: Regenerate Argument Clinic output BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/b49ff0bb44c4e8bbb3678443fc4fa8676749e4e6
7f2600d gh-154997: Protect buffered raw access from reentrant detach BHUVANSH855 Aug 1, 2026 https://github.com/python/cpython/pull/155017/commits/7f2600d87f0a1235907970f6546ac9c51a5fcc1d
Clear filters https://github.com/python/cpython/pull/155017/files
Please reload this pagehttps://github.com/python/cpython/pull/155017/files
Please reload this pagehttps://github.com/python/cpython/pull/155017/files
test_bufferedio.py https://github.com/python/cpython/pull/155017/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
2026-08-01-09-52-23.gh-issue-154997.wcYpao.rst https://github.com/python/cpython/pull/155017/files#diff-c97e0d5b2ea82b409082d41df2518b5e8e11cffed801686e7977344ad6613314
bufferedio.c https://github.com/python/cpython/pull/155017/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/test/test_io/test_bufferedio.pyhttps://github.com/python/cpython/pull/155017/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
View file https://github.com/python/cpython/blob/7f2600d87f0a1235907970f6546ac9c51a5fcc1d/Lib/test/test_io/test_bufferedio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155017/{{ revealButtonHref }}
https://github.com/python/cpython/pull/155017/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/python/cpython/pull/155017/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/python/cpython/pull/155017/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/python/cpython/pull/155017/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
Misc/NEWS.d/next/Library/2026-08-01-09-52-23.gh-issue-154997.wcYpao.rsthttps://github.com/python/cpython/pull/155017/files#diff-c97e0d5b2ea82b409082d41df2518b5e8e11cffed801686e7977344ad6613314
View file https://github.com/python/cpython/blob/7f2600d87f0a1235907970f6546ac9c51a5fcc1d/Misc/NEWS.d/next/Library/2026-08-01-09-52-23.gh-issue-154997.wcYpao.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/155017/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/155017/files
Please reload this pagehttps://github.com/python/cpython/pull/155017/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.