René's URL Explorer Experiment


Title: gh-154987: Handle ValueError for drive-relative paths in tarfile filters by zainnadeem786 · Pull Request #154993 · python/cpython · GitHub

Open Graph Title: gh-154987: Handle ValueError for drive-relative paths in tarfile filters by zainnadeem786 · Pull Request #154993 · python/cpython

X Title: gh-154987: Handle ValueError for drive-relative paths in tarfile filters by zainnadeem786 · Pull Request #154993 · python/cpython

Description: Summary Fixes gh-154987. On Windows, tarfile extraction filters use os.path.commonpath() to verify that extracted members remain inside the destination directory. For drive-relative paths (for example Z:evil), ntpath.commonpath() raises ValueError because the paths are considered to be on different drives. That exception currently escapes instead of being translated into tarfile's existing structured extraction filter errors. This PR catches that ValueError and treats those paths as outside the destination, preserving the existing extraction filter semantics. Changes Handle ValueError raised by os.path.commonpath() during destination containment checks. Raise the existing: OutsideDestinationError LinkOutsideDestinationError instead of allowing a raw ValueError to escape. Add regression tests covering: drive-relative member paths drive-relative symlink targets drive-relative hardlink targets errorlevel=0 continuation behaviour Testing Executed: PCbuild\amd64\python.exe -m test test_tarfile -m "*drive_relative*" -v PCbuild\amd64\python.exe -m test test_tarfile \ -m "*drive_relative*" \ -m test_absolute \ -m test_absolute_symlink \ -m test_absolute_hardlink \ -m test_link_at_destination \ -m test_normpath_realpath_mismatch \ -m test_errorlevel -v All targeted regression tests passed successfully.

Open Graph Description: Summary Fixes gh-154987. On Windows, tarfile extraction filters use os.path.commonpath() to verify that extracted members remain inside the destination directory. For drive-relative paths (for exam...

X Description: Summary Fixes gh-154987. On Windows, tarfile extraction filters use os.path.commonpath() to verify that extracted members remain inside the destination directory. For drive-relative paths (for exam...

Opengraph URL: https://github.com/python/cpython/pull/154993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fc67f220-017d-9dd4-05de-fc994c86a4f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE750:E0ADF:1AA4CB5:2190417:6B022F8B
html-safe-nonceeaf7e6b9611c2391f79afbfc36ea9c67fd60dfe7915a2098d3a121a48dfeaebf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzUwOkUwQURGOjFBQTRDQjU6MjE5MDQxNzo2QjAyMkY4QiIsInZpc2l0b3JfaWQiOiI2MDQyODMzMTI2ODUyNTM4MjUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4bafbf0edb0fb51c71d5bba6c8c8366180426b8c8a900e617c8ba847826c44a5
hovercard-subject-tagpull_request:4177347089
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154993/files
twitter:imagehttps://avatars.githubusercontent.com/u/165761530?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/165761530?s=400&v=4
og:image:altSummary Fixes gh-154987. On Windows, tarfile extraction filters use os.path.commonpath() to verify that extracted members remain inside the destination directory. For drive-relative paths (for exam...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154993/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154993%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154993%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154993/files
Reloadhttps://github.com/python/cpython/pull/154993/files
Reloadhttps://github.com/python/cpython/pull/154993/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zainnadeem786https://github.com/zainnadeem786
python:mainhttps://github.com/python/cpython/tree/main
zainnadeem786:bugfix/tarfile-drive-relative-filter-errorshttps://github.com/zainnadeem786/cpython/tree/bugfix/tarfile-drive-relative-filter-errors
Conversation 0 https://github.com/python/cpython/pull/154993
Commits 2 https://github.com/python/cpython/pull/154993/commits
Checks 50 https://github.com/python/cpython/pull/154993/checks
Files changed https://github.com/python/cpython/pull/154993/files
Please reload this pagehttps://github.com/python/cpython/pull/154993/files
gh-154987: Handle ValueError for drive-relative paths in tarfile filters https://github.com/python/cpython/pull/154993/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/154993/files
0ecbc5e gh-154987: Handle drive-relative paths in tarfile filters zainnadeem786 Jul 31, 2026 https://github.com/python/cpython/pull/154993/commits/0ecbc5ef1e7887e1185e1e8fd4c5e464823f054b
516c346 Merge branch 'main' into bugfix/tarfile-drive-relative-filter-errors zainnadeem786 Sep 16, 2026 https://github.com/python/cpython/pull/154993/commits/516c34609d410ef9669d33d931384b27f62d6b8d
Clear filters https://github.com/python/cpython/pull/154993/files
Please reload this pagehttps://github.com/python/cpython/pull/154993/files
Please reload this pagehttps://github.com/python/cpython/pull/154993/files
tarfile.py https://github.com/python/cpython/pull/154993/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
test_tarfile.py https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
2026-07-31-16-30-00.bpo-0.xz7oaj.rst https://github.com/python/cpython/pull/154993/files#diff-5caec0f6eb2a8a70a4613d4995eb2c11d4b2f9f6116b6deb1040e8433664b7b3
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L611
Lib/tarfile.pyhttps://github.com/python/cpython/pull/154993/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
View file https://github.com/python/cpython/blob/516c34609d410ef9669d33d931384b27f62d6b8d/Lib/tarfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154993/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154993/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
https://github.com/python/cpython/pull/154993/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
https://github.com/python/cpython/pull/154993/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
https://github.com/python/cpython/pull/154993/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L612
Lib/test/test_tarfile.pyhttps://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
View file https://github.com/python/cpython/blob/516c34609d410ef9669d33d931384b27f62d6b8d/Lib/test/test_tarfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154993/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/154993/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
Misc/NEWS.d/next/Library/2026-07-31-16-30-00.bpo-0.xz7oaj.rsthttps://github.com/python/cpython/pull/154993/files#diff-5caec0f6eb2a8a70a4613d4995eb2c11d4b2f9f6116b6deb1040e8433664b7b3
View file https://github.com/python/cpython/blob/516c34609d410ef9669d33d931384b27f62d6b8d/Misc/NEWS.d/next/Library/2026-07-31-16-30-00.bpo-0.xz7oaj.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154993/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/154993/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.