René's URL Explorer Experiment


Title: gh-154916: Fix data race in ga_iter_reduce under free-threading by tekinertekin · Pull Request #154944 · python/cpython · GitHub

Open Graph Title: gh-154916: Fix data race in ga_iter_reduce under free-threading by tekinertekin · Pull Request #154944 · python/cpython

X Title: gh-154916: Fix data race in ga_iter_reduce under free-threading by tekinertekin · Pull Request #154944 · python/cpython

Description: Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi->obj) return Py_BuildValue("N(O)", iter, gi->obj); The two reads can straddle that exchange, so the guard can observe a non-NULL pointer that is then passed to Py_BuildValue after the owning thread has already called Py_DECREF on it. That makes this a potential use-after-free rather than only a torn read. ThreadSanitizer trips on the guard read first, which is what the issue reports. The fix takes a single strong reference instead: _Py_XGetRef in the free-threaded build, plain Py_XNewRef otherwise, with "N(N)" so Py_BuildValue consumes the reference we now own. _Py_XGetRef documents that the writer must set maybe-weakref on the stored object, otherwise its try-incref can never succeed from another thread and it spins. ga_iter stores with a plain Py_NewRef, so the writer side needs _PyObject_SetMaybeWeakref. Racing with next() may legitimately observe either the object or the exhausted iterator; both reductions are correct and that does not change here. Verification Built on arm64 macOS with --disable-gil --with-thread-sanitizer --with-pydebug. Reproducer: 4 threads calling next() and 4 calling __reduce__() on one shared iter(list[int]). TSAN warnings result before 2 — ga_iternext:946 ↔ ga_iter_reduce:1000, both orderings SIGABRT after 0 clean test_genericalias, test_types, test_typing: 913 tests pass. test_genericalias test_types -R 3:3: no leaks. The O → N change moves ownership of the reference, so this seemed worth checking explicitly. __reduce__ output and pickle round-trip are unchanged for both a live and an exhausted iterator. One open question I kept this lock-free to stay symmetric with ga_iternext as gh-154108 left it. The alternative is the list_item_impl pattern — a critical section plus _Py_NewRefWithLock — but that only synchronises if ga_iternext takes the lock too, which would mean revising the design just merged in gh-154108. _Py_XGetRef has no other call site in the tree, so if you would rather have the critical-section version, I am happy to redo it that way. Issue: gh-154916

Open Graph Description: Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi->obj) ...

X Description: Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi-&g...

Opengraph URL: https://github.com/python/cpython/pull/154944

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1ddb9080-2d40-89fc-553b-9c78d15bc855
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE954:27E5CD:420187A:5446B1C:6B021F6D
html-safe-noncece09721eaa837724cca2252e09850261855daee93a6d773a65685ce539e7721a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTU0OjI3RTVDRDo0MjAxODdBOjU0NDZCMUM6NkIwMjFGNkQiLCJ2aXNpdG9yX2lkIjoiMjUzNTUwNzc4ODYzODA2ODU4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4e4c4de5e92e6db3631094be1c33dd4ea46c79445444c07ba1c4eec58f90a1d
hovercard-subject-tagpull_request:4170728235
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154944/files
twitter:imagehttps://avatars.githubusercontent.com/u/6604295?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6604295?s=400&v=4
og:image:altIssue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi->obj) ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154944/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154944%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154944%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154944/files
Reloadhttps://github.com/python/cpython/pull/154944/files
Reloadhttps://github.com/python/cpython/pull/154944/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tekinertekinhttps://github.com/tekinertekin
python:mainhttps://github.com/python/cpython/tree/main
tekinertekin:fix-ga-iter-reduce-racehttps://github.com/tekinertekin/cpython/tree/fix-ga-iter-reduce-race
Conversation 4 https://github.com/python/cpython/pull/154944
Commits 2 https://github.com/python/cpython/pull/154944/commits
Checks 49 https://github.com/python/cpython/pull/154944/checks
Files changed https://github.com/python/cpython/pull/154944/files
Please reload this pagehttps://github.com/python/cpython/pull/154944/files
gh-154916: Fix data race in ga_iter_reduce under free-threading https://github.com/python/cpython/pull/154944/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/154944/files
a9cd1ff gh-154916: Fix data race in ga_iter_reduce under free-threading tekinertekin Jul 30, 2026 https://github.com/python/cpython/pull/154944/commits/a9cd1ff958a9f80d9730c7d98533169fdf636f72
284f50b Merge branch 'main' into fix-ga-iter-reduce-race tekinertekin Jul 30, 2026 https://github.com/python/cpython/pull/154944/commits/284f50b40412f5ec850614f161625ae92325f83c
Clear filters https://github.com/python/cpython/pull/154944/files
Please reload this pagehttps://github.com/python/cpython/pull/154944/files
Please reload this pagehttps://github.com/python/cpython/pull/154944/files
2026-07-30-15-10-00.gh-issue-154916.Kp3nQz.rst https://github.com/python/cpython/pull/154944/files#diff-2626857066f68cc7b96a89719f53d0c5278035510c1bd3541cdbc8d3cda2c2b5
genericaliasobject.c https://github.com/python/cpython/pull/154944/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-15-10-00.gh-issue-154916.Kp3nQz.rsthttps://github.com/python/cpython/pull/154944/files#diff-2626857066f68cc7b96a89719f53d0c5278035510c1bd3541cdbc8d3cda2c2b5
View file https://github.com/tekinertekin/cpython/blob/284f50b40412f5ec850614f161625ae92325f83c/Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-15-10-00.gh-issue-154916.Kp3nQz.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154944/{{ revealButtonHref }}
Objects/genericaliasobject.chttps://github.com/python/cpython/pull/154944/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
View file https://github.com/tekinertekin/cpython/blob/284f50b40412f5ec850614f161625ae92325f83c/Objects/genericaliasobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154944/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154944/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/154944/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/154944/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/154944/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
Please reload this pagehttps://github.com/python/cpython/pull/154944/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.