Title: gh-154916: Fix data race in ga_iter_reduce under free-threading by tekinertekin · Pull Request #154944 · python/cpython · GitHub
Open Graph Title: gh-154916: Fix data race in ga_iter_reduce under free-threading by tekinertekin · Pull Request #154944 · python/cpython
X Title: gh-154916: Fix data race in ga_iter_reduce under free-threading by tekinertekin · Pull Request #154944 · python/cpython
Description: Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi->obj) return Py_BuildValue("N(O)", iter, gi->obj); The two reads can straddle that exchange, so the guard can observe a non-NULL pointer that is then passed to Py_BuildValue after the owning thread has already called Py_DECREF on it. That makes this a potential use-after-free rather than only a torn read. ThreadSanitizer trips on the guard read first, which is what the issue reports. The fix takes a single strong reference instead: _Py_XGetRef in the free-threaded build, plain Py_XNewRef otherwise, with "N(N)" so Py_BuildValue consumes the reference we now own. _Py_XGetRef documents that the writer must set maybe-weakref on the stored object, otherwise its try-incref can never succeed from another thread and it spins. ga_iter stores with a plain Py_NewRef, so the writer side needs _PyObject_SetMaybeWeakref. Racing with next() may legitimately observe either the object or the exhausted iterator; both reductions are correct and that does not change here. Verification Built on arm64 macOS with --disable-gil --with-thread-sanitizer --with-pydebug. Reproducer: 4 threads calling next() and 4 calling __reduce__() on one shared iter(list[int]). TSAN warnings result before 2 — ga_iternext:946 ↔ ga_iter_reduce:1000, both orderings SIGABRT after 0 clean test_genericalias, test_types, test_typing: 913 tests pass. test_genericalias test_types -R 3:3: no leaks. The O → N change moves ownership of the reference, so this seemed worth checking explicitly. __reduce__ output and pickle round-trip are unchanged for both a live and an exhausted iterator. One open question I kept this lock-free to stay symmetric with ga_iternext as gh-154108 left it. The alternative is the list_item_impl pattern — a critical section plus _Py_NewRefWithLock — but that only synchronises if ga_iternext takes the lock too, which would mean revising the design just merged in gh-154108. _Py_XGetRef has no other call site in the tree, so if you would rather have the critical-section version, I am happy to redo it that way. Issue: gh-154916
Open Graph Description: Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi->obj) ...
X Description: Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi-&g...
Opengraph URL: https://github.com/python/cpython/pull/154944
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1ddb9080-2d40-89fc-553b-9c78d15bc855 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E954:27E5CD:420187A:5446B1C:6B021F6D |
| html-safe-nonce | ce09721eaa837724cca2252e09850261855daee93a6d773a65685ce539e7721a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTU0OjI3RTVDRDo0MjAxODdBOjU0NDZCMUM6NkIwMjFGNkQiLCJ2aXNpdG9yX2lkIjoiMjUzNTUwNzc4ODYzODA2ODU4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b4e4c4de5e92e6db3631094be1c33dd4ea46c79445444c07ba1c4eec58f90a1d |
| hovercard-subject-tag | pull_request:4170728235 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/154944/files |
| twitter:image | https://avatars.githubusercontent.com/u/6604295?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6604295?s=400&v=4 |
| og:image:alt | Issue: #154916 ga_iternext takes gi->obj out with _Py_atomic_exchange_ptr and then drops the reference, while ga_iter_reduce reads the same field twice without synchronisation: if (gi->obj) ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width