René's URL Explorer Experiment


Title: gh-127337: Fix importlib.resources for legacy ResourceReader loaders by pikammmmm · Pull Request #154919 · python/cpython · GitHub

Open Graph Title: gh-127337: Fix importlib.resources for legacy ResourceReader loaders by pikammmmm · Pull Request #154919 · python/cpython

X Title: gh-127337: Fix importlib.resources for legacy ResourceReader loaders by pikammmmm · Pull Request #154919 · python/cpython

Description: CompatibilityFiles.SpecPath, .ChildPath and .OrphanPath each defined joinpath() with a single required argument, but importlib.resources.abc.Traversable declares joinpath(*descendants) and documents that passing no descendants returns self. Since 3.13 the functional API is implemented on top of files(anchor).joinpath(*path_names), so any call that passes no path names reaches joinpath() with no arguments and raises TypeError for a package whose loader provides only a legacy ResourceReader: 3.12.13 3.13.13 / 3.14.4 / 3.15.0b1 this PR contents(FakeModule) ['NAME'] TypeError ['NAME'] is_resource(FakeModule) n/a — required a name TypeError False (measured with the reproducer from the issue; 3.12 predates _functional.py, whose one-name-per-call predecessor never routed through joinpath()) This is the fix @jaraco sketched in the issue, extended to ChildPath and OrphanPath as he suggested it might need to be. It also fixes the latent multi-argument case, broken ever since the protocol gained *descendants in 3.11 without _adapters.py being updated — as @FFY00 diagnosed, "the CompatibilityFiles implementation is bad, it can only ever take one argument, and now it needs to be able to take any number of arguments." One deviation from the sketch: it used '/'.join(descendants) for SpecPath, which would make files.joinpath('a', 'b') a single ChildPath named a/b, while files / 'a' / 'b' is an OrphanPath('a', 'b'). The Traversable.joinpath docs present the chained single-argument form as the compatibility equivalent of the multi-argument form for implementations that predate it, so this PR applies descendants one at a time and the two forms agree. That also avoids '/'.join raising TypeError on a PathLike segment which single-argument joinpath() accepts today. CompatibilityFiles still does not meaningfully support os.PathLike segments; that is unchanged here and out of scope. Tests Seven new tests in test_compatibilty_files.py: zero-argument joinpath() on all three path classes (with and without a reader), the multi-argument/chained equivalence, and contents()/is_resource() through the functional API. Negative control: with _adapters.py reverted, all seven new tests fail and the 16 pre-existing tests in the file still pass. All 221 tests in test_importlib.resources pass (1 skipped). I test without a local C build — checkout Lib/ on a matching installed interpreter — which yields 88 unrelated pre-existing failures in test_importlib.metadata/frozen/extension. That set is identical with and without this patch, and none of them are in resources. Sibling fix for the same protocol violation in simple.py: #145263. @FFY00 — @jaraco assigned this to you in December 2024; happy to close this if you would rather take it yourself. Issue: gh-127337

Open Graph Description: CompatibilityFiles.SpecPath, .ChildPath and .OrphanPath each defined joinpath() with a single required argument, but importlib.resources.abc.Traversable declares joinpath(*descendants) and document...

X Description: CompatibilityFiles.SpecPath, .ChildPath and .OrphanPath each defined joinpath() with a single required argument, but importlib.resources.abc.Traversable declares joinpath(*descendants) and document...

Opengraph URL: https://github.com/python/cpython/pull/154919

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b1e541a-4d79-2f7f-9632-5fb6dacb0168
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1D8:395E6B:EF46:146E8:6B004CDF
html-safe-noncec59fa05b3dffd51c5d67f711fb79e37795e6dd2e57c714bb65eb6abb0c1ff2fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUQ4OjM5NUU2QjpFRjQ2OjE0NkU4OjZCMDA0Q0RGIiwidmlzaXRvcl9pZCI6IjQ5NzkzNTk3MjM1NDg1OTMzNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5009b33ac54b62ddd0240ce24a68d1b686a79ffdbc7c4fb528b9e1a002458482
hovercard-subject-tagpull_request:4169031435
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154919/files
twitter:imagehttps://avatars.githubusercontent.com/u/124257101?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/124257101?s=400&v=4
og:image:altCompatibilityFiles.SpecPath, .ChildPath and .OrphanPath each defined joinpath() with a single required argument, but importlib.resources.abc.Traversable declares joinpath(*descendants) and document...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154919/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154919%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154919%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154919/files
Reloadhttps://github.com/python/cpython/pull/154919/files
Reloadhttps://github.com/python/cpython/pull/154919/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pikammmmmhttps://github.com/pikammmmm
python:mainhttps://github.com/python/cpython/tree/main
pikammmmm:gh-127337-compatibilityfiles-joinpathhttps://github.com/pikammmmm/cpython/tree/gh-127337-compatibilityfiles-joinpath
Conversation 3 https://github.com/python/cpython/pull/154919
Commits 4 https://github.com/python/cpython/pull/154919/commits
Checks 49 https://github.com/python/cpython/pull/154919/checks
Files changed https://github.com/python/cpython/pull/154919/files
Please reload this pagehttps://github.com/python/cpython/pull/154919/files
gh-127337: Fix importlib.resources for legacy ResourceReader loaders https://github.com/python/cpython/pull/154919/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/154919/files
2779e80 gh-127337: Fix importlib.resources for legacy ResourceReader loaders pikammmmm Jul 30, 2026 https://github.com/python/cpython/pull/154919/commits/2779e806b8846c40ab32f91cea068e6aec0211b0
c37c21f Split multi-level descendants in CompatibilityFiles joinpath() pikammmmm Nov 11, 2026 https://github.com/python/cpython/pull/154919/commits/c37c21f1228ebd9c0e3750421e82afa62e24b1b6
9043f9f Revert "Split multi-level descendants in CompatibilityFiles joinpath()" pikammmmm Nov 11, 2026 https://github.com/python/cpython/pull/154919/commits/9043f9fe210d621756bebf34d9231ac69ccd670a
3e6bc1e Merge remote-tracking branch 'upstream/main' into gh-127337-compatibi… pikammmmm Nov 11, 2026 https://github.com/python/cpython/pull/154919/commits/3e6bc1ea1f20083a92ad056cb3b26b59c2f3f02a
Clear filters https://github.com/python/cpython/pull/154919/files
Please reload this pagehttps://github.com/python/cpython/pull/154919/files
Please reload this pagehttps://github.com/python/cpython/pull/154919/files
_adapters.py https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
test_compatibilty_files.py https://github.com/python/cpython/pull/154919/files#diff-99e7eba264f26365ba966ec92e71420eb5e2276186c2d115fcc44e87337446ca
2026-07-30-13-36-06.gh-issue-127337.ahcvtH.rst https://github.com/python/cpython/pull/154919/files#diff-7f732fbbeeeba043262bcac4638dc183e0231a456bd6b14b8005184f220d72d7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L519
Lib/importlib/resources/_adapters.pyhttps://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
View file https://github.com/python/cpython/blob/3e6bc1ea1f20083a92ad056cb3b26b59c2f3f02a/Lib/importlib/resources/_adapters.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154919/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
https://github.com/python/cpython/pull/154919/files#diff-d6475cb0cc1e294e7bf28219a14438dc98a810ee09feefe49402b24fdacd7849
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L520
Lib/test/test_importlib/resources/test_compatibilty_files.pyhttps://github.com/python/cpython/pull/154919/files#diff-99e7eba264f26365ba966ec92e71420eb5e2276186c2d115fcc44e87337446ca
View file https://github.com/python/cpython/blob/3e6bc1ea1f20083a92ad056cb3b26b59c2f3f02a/Lib/test/test_importlib/resources/test_compatibilty_files.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154919/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154919/files#diff-99e7eba264f26365ba966ec92e71420eb5e2276186c2d115fcc44e87337446ca
https://github.com/python/cpython/pull/154919/files#diff-99e7eba264f26365ba966ec92e71420eb5e2276186c2d115fcc44e87337446ca
https://github.com/python/cpython/pull/154919/files#diff-99e7eba264f26365ba966ec92e71420eb5e2276186c2d115fcc44e87337446ca
https://github.com/python/cpython/pull/154919/files#diff-99e7eba264f26365ba966ec92e71420eb5e2276186c2d115fcc44e87337446ca
Misc/NEWS.d/next/Library/2026-07-30-13-36-06.gh-issue-127337.ahcvtH.rsthttps://github.com/python/cpython/pull/154919/files#diff-7f732fbbeeeba043262bcac4638dc183e0231a456bd6b14b8005184f220d72d7
View file https://github.com/python/cpython/blob/3e6bc1ea1f20083a92ad056cb3b26b59c2f3f02a/Misc/NEWS.d/next/Library/2026-07-30-13-36-06.gh-issue-127337.ahcvtH.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154919/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/154919/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.