René's URL Explorer Experiment


Title: gh-148286: Fix undefined behaviour in per-thread refcount merging by matthiasgoergens · Pull Request #154915 · python/cpython · GitHub

Open Graph Title: gh-148286: Fix undefined behaviour in per-thread refcount merging by matthiasgoergens · Pull Request #154915 · python/cpython

X Title: gh-148286: Fix undefined behaviour in per-thread refcount merging by matthiasgoergens · Pull Request #154915 · python/cpython

Description: _PyObject_MergePerThreadRefcounts() merges each thread's local reference count deltas into the shared count: _Py_atomic_add_ssize(&obj->ob_ref_shared, refcnt << _Py_REF_SHARED_SHIFT); refcnt is a delta, so it is routinely negative — in practice almost always -1 — and shifting a negative value left is undefined behaviour. This does the shift in the unsigned domain and converts back. This is not reachable from the UBSan CI job today. The sanitizer matrix in .github/workflows/build.yml pairs UBSan only with free-threading: false, so Python/uniqueid.c is never built under UBSan at all. Building --disable-gil together with --with-undefined-behavior-sanitizer shows how load-bearing it is: the first line of output from ./python -c pass is the UBSan report, raised during interpreter startup via _PyImport_InitExternal, and it recurs from gc_collect_main on every collection. Measured over the full test suite on that configuration, with every entry in Tools/ubsan/suppressions.txt disabled: UB reports test failures failing files before 1762 529 61 after 0 0 0 Most of those failures are tests asserting that a subprocess produced no stderr, which the UBSan diagnostic breaks. I have not touched the CI matrix here, since adding a job is a maintainer's call and this fix stands on its own. But the reason this went unnoticed is structural rather than accidental, and I would like to follow up separately with a proposal to add free-threading: true to the UBSan matrix — with this fix in, that configuration is green, so it would be a regression guard rather than a source of new work. The same appears to be true of --enable-experimental-jit, which CI builds but never sanitizes: I ran the full suite against a machine-code JIT build under UBSan and it is clean today, while gh-139269 (an unaligned uint64_t store in Python/jit.c, which segfaulted release builds) was originally found by exactly that combination. I will write that up with the measurements rather than expand the scope of this PR. Issue: gh-148286

Open Graph Description: _PyObject_MergePerThreadRefcounts() merges each thread's local reference count deltas into the shared count: _Py_atomic_add_ssize(&obj->ob_ref_shared, refcnt << _Py_REF_SHARED_SHIF...

X Description: _PyObject_MergePerThreadRefcounts() merges each thread&#39;s local reference count deltas into the shared count: _Py_atomic_add_ssize(&amp;obj-&gt;ob_ref_shared, refcnt &lt;&lt;...

Opengraph URL: https://github.com/python/cpython/pull/154915

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4476c5d4-c606-83b1-e657-9deac0c0c2cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id954E:2F543F:238F142:2ECC640:6B024F43
html-safe-nonce1b6fbb7fcfadd71f329a272332292e775c1be2e2266730f0f5d27e66354c82fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTRFOjJGNTQzRjoyMzhGMTQyOjJFQ0M2NDA6NkIwMjRGNDMiLCJ2aXNpdG9yX2lkIjoiMjA1MDA2ODY1OTAzNjExNDc1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac806ce50c910633fb3f62b2535d68a33128dfaff2049a44b98aa599e6b05c4362
hovercard-subject-tagpull_request:4168107916
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154915/files
twitter:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
og:image:alt_PyObject_MergePerThreadRefcounts() merges each thread's local reference count deltas into the shared count: _Py_atomic_add_ssize(&obj->ob_ref_shared, refcnt << _Py_REF_SHARED_SHIF...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154915/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154915%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154915%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154915/files
Reloadhttps://github.com/python/cpython/pull/154915/files
Reloadhttps://github.com/python/cpython/pull/154915/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
matthiasgoergenshttps://github.com/matthiasgoergens
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:freethreaded-refcount-ubhttps://github.com/matthiasgoergens/cpython/tree/freethreaded-refcount-ub
Conversation 1 https://github.com/python/cpython/pull/154915
Commits 1 https://github.com/python/cpython/pull/154915/commits
Checks 49 https://github.com/python/cpython/pull/154915/checks
Files changed 2 https://github.com/python/cpython/pull/154915/files
gh-148286: Fix undefined behaviour in per-thread refcount merging https://github.com/python/cpython/pull/154915/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/154915/files
d94417e gh-148286: Fix undefined behaviour in per-thread refcount merging (fr… matthiasgoergens Jul 30, 2026 https://github.com/python/cpython/pull/154915/commits/d94417e52078bc5f07c609362fc52ca8f0bc68fc
Clear filters https://github.com/python/cpython/pull/154915/files
Please reload this pagehttps://github.com/python/cpython/pull/154915/files
Please reload this pagehttps://github.com/python/cpython/pull/154915/files
2026-07-30-14-30-00.gh-issue-148286.Wn5Tz4.rst https://github.com/python/cpython/pull/154915/files#diff-782e98bf76650b1fdff7f05598362e7f37fd92a91e7553e8c58eeb75ed096572
uniqueid.c https://github.com/python/cpython/pull/154915/files#diff-200305e4f88d9e3778a0867a2d66d965d0d894e6c86118b00b7f440376d517d8
Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-14-30-00.gh-issue-148286.Wn5Tz4.rsthttps://github.com/python/cpython/pull/154915/files#diff-782e98bf76650b1fdff7f05598362e7f37fd92a91e7553e8c58eeb75ed096572
View file https://github.com/python/cpython/blob/d94417e52078bc5f07c609362fc52ca8f0bc68fc/Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-14-30-00.gh-issue-148286.Wn5Tz4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154915/{{ revealButtonHref }}
Python/uniqueid.chttps://github.com/python/cpython/pull/154915/files#diff-200305e4f88d9e3778a0867a2d66d965d0d894e6c86118b00b7f440376d517d8
View file https://github.com/python/cpython/blob/d94417e52078bc5f07c609362fc52ca8f0bc68fc/Python/uniqueid.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154915/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154915/files#diff-200305e4f88d9e3778a0867a2d66d965d0d894e6c86118b00b7f440376d517d8
https://github.com/python/cpython/pull/154915/files#diff-200305e4f88d9e3778a0867a2d66d965d0d894e6c86118b00b7f440376d517d8
Please reload this pagehttps://github.com/python/cpython/pull/154915/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.