René's URL Explorer Experiment


Title: [3.13] gh-154711: Strip comments after escaped quotes in f-string debug text by ArneshBanerjee · Pull Request #154914 · python/cpython · GitHub

Open Graph Title: [3.13] gh-154711: Strip comments after escaped quotes in f-string debug text by ArneshBanerjee · Pull Request #154914 · python/cpython

X Title: [3.13] gh-154711: Strip comments after escaped quotes in f-string debug text by ArneshBanerjee · Pull Request #154914 · python/cpython

Description: When a replacement field ended with a string that had an escaped quote and was followed by a comment, the comment leaked into the debug f-string output. The comment detection loop in set_fstring_expr skips escaped characters, but the comment stripping loop did not. So an escaped quote left the scanner thinking it was still inside a string, and the comment was never removed. This makes the stripping loop skip escaped characters the same way the detection loop does. 3.14 and 3.15 already have the same fix from the gh-154719 backports, and main is not affected after gh-153569, so this is 3.13 only. Issue: gh-154711

Open Graph Description: When a replacement field ended with a string that had an escaped quote and was followed by a comment, the comment leaked into the debug f-string output. The comment detection loop in set_fstring_ex...

X Description: When a replacement field ended with a string that had an escaped quote and was followed by a comment, the comment leaked into the debug f-string output. The comment detection loop in set_fstring_ex...

Opengraph URL: https://github.com/python/cpython/pull/154914

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ddab2edb-f38b-3b1d-c0f5-0104a423e17a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAFE:38EE04:1AFC86E:2397AF7:6B021AF3
html-safe-noncecd771701f56e2e963706569dc68ba1f54b8f29403a30b15c5179bf39ff57c4a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUZFOjM4RUUwNDoxQUZDODZFOjIzOTdBRjc6NkIwMjFBRjMiLCJ2aXNpdG9yX2lkIjoiMzM0MTY2NTg5MTYwMjUzNzIwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4bbdf6e6b14791197b28b40f80e0ae48e8ad7032b3d433358c66f5b000ba40f3
hovercard-subject-tagpull_request:4167879066
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154914/files
twitter:imagehttps://avatars.githubusercontent.com/u/177954836?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/177954836?s=400&v=4
og:image:altWhen a replacement field ended with a string that had an escaped quote and was followed by a comment, the comment leaked into the debug f-string output. The comment detection loop in set_fstring_ex...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154914/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154914%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154914%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154914/files
Reloadhttps://github.com/python/cpython/pull/154914/files
Reloadhttps://github.com/python/cpython/pull/154914/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ArneshBanerjeehttps://github.com/ArneshBanerjee
python:3.13https://github.com/python/cpython/tree/3.13
ArneshBanerjee:fix-gh-154711-fstring-comment-leakhttps://github.com/ArneshBanerjee/cpython/tree/fix-gh-154711-fstring-comment-leak
Conversation 12 https://github.com/python/cpython/pull/154914
Commits 1 https://github.com/python/cpython/pull/154914/commits
Checks 0 https://github.com/python/cpython/pull/154914/checks
Files changed https://github.com/python/cpython/pull/154914/files
Please reload this pagehttps://github.com/python/cpython/pull/154914/files
[3.13] gh-154711: Strip comments after escaped quotes in f-string debug text https://github.com/python/cpython/pull/154914/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/154914/files
2877218 [3.13] gh-154711: Strip comments after escaped quotes in f-string deb… ArneshBanerjee Sep 26, 2026 https://github.com/python/cpython/pull/154914/commits/2877218adf4fd29bbfb8bae2b9617483de56ffbb
Clear filters https://github.com/python/cpython/pull/154914/files
Please reload this pagehttps://github.com/python/cpython/pull/154914/files
Please reload this pagehttps://github.com/python/cpython/pull/154914/files
test_fstring.py https://github.com/python/cpython/pull/154914/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
2026-07-30-14-40-00.gh-issue-154711.nUxYXc.rst https://github.com/python/cpython/pull/154914/files#diff-dde24de4dd1a56979c9ff6c59a1d7f352aa5d144213cb2d6045b205a9b6794ea
lexer.c https://github.com/python/cpython/pull/154914/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
Lib/test/test_fstring.pyhttps://github.com/python/cpython/pull/154914/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
View file https://github.com/ArneshBanerjee/cpython/blob/2877218adf4fd29bbfb8bae2b9617483de56ffbb/Lib/test/test_fstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154914/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154914/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
https://github.com/python/cpython/pull/154914/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-14-40-00.gh-issue-154711.nUxYXc.rsthttps://github.com/python/cpython/pull/154914/files#diff-dde24de4dd1a56979c9ff6c59a1d7f352aa5d144213cb2d6045b205a9b6794ea
View file https://github.com/ArneshBanerjee/cpython/blob/2877218adf4fd29bbfb8bae2b9617483de56ffbb/Misc/NEWS.d/next/Core_and_Builtins/2026-07-30-14-40-00.gh-issue-154711.nUxYXc.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154914/{{ revealButtonHref }}
pablogsalhttps://github.com/pablogsal
Aug 10, 2026https://github.com/python/cpython/pull/154914/files#r3749160326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
gh-112243https://github.com/python/cpython/issues/112243
Please reload this pagehttps://github.com/python/cpython/pull/154914/files
ArneshBanerjeehttps://github.com/ArneshBanerjee
Aug 10, 2026https://github.com/python/cpython/pull/154914/files#r3752795571
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/154914/files
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L150
Parser/lexer/lexer.chttps://github.com/python/cpython/pull/154914/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
View file https://github.com/ArneshBanerjee/cpython/blob/2877218adf4fd29bbfb8bae2b9617483de56ffbb/Parser/lexer/lexer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154914/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154914/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/154914/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.