René's URL Explorer Experiment


Title: gh-148286: Fix undefined behaviour in io.StringIO.read() after an overseek by matthiasgoergens · Pull Request #154913 · python/cpython · GitHub

Open Graph Title: gh-148286: Fix undefined behaviour in io.StringIO.read() after an overseek by matthiasgoergens · Pull Request #154913 · python/cpython

X Title: gh-148286: Fix undefined behaviour in io.StringIO.read() after an overseek by matthiasgoergens · Pull Request #154913 · python/cpython

Description: _io_StringIO_read_impl() clamps the read size to zero when the position is past the end of the buffer, but still forms the pointer self->buf + self->pos before returning. Nothing is read through it, but forming it is undefined behaviour on its own, and since self->buf is a Py_UCS4 * the byte offset is self->pos * 4 — so for self->pos == 2**62 - 1 the multiplication wraps and yields a pointer four bytes below self->buf. io.StringIO("abc").seek(2**62 - 1) # then .read() stringio.c:352: addition of unsigned offset to 0x... overflowed to 0x... _stringio_readline() already guards exactly this condition a few lines below, with the comment "In case of overseek, return the empty string", so this applies the same guard on the read path. self->pos += size is a no-op here because size is zero, and ENSURE_REALIZED() is deliberately left ahead of the guard so the state transition and its error path are unchanged. The existing test_io suite already covers this path — that is how UBSan found it — so no new test is needed. With the Modules/_io/stringio.c entry removed from Tools/ubsan/suppressions.txt, test_io passes under UBSAN_OPTIONS=halt_on_error=1, where before it aborts at stringio.c:352. Issue: gh-148286

Open Graph Description: _io_StringIO_read_impl() clamps the read size to zero when the position is past the end of the buffer, but still forms the pointer self->buf + self->pos before returning. Nothing is read thro...

X Description: _io_StringIO_read_impl() clamps the read size to zero when the position is past the end of the buffer, but still forms the pointer self->buf + self->pos before returning. Nothing is r...

Opengraph URL: https://github.com/python/cpython/pull/154913

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0dda0785-ac62-0e89-1e1f-f4097a73f4b6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FCA:2C69FC:22802B6:2D939A8:6B024F3E
html-safe-nonceac85f142e3e01a6d7a8af412663522805d8ca9cad6dca4306722fb9599294e78
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkNBOjJDNjlGQzoyMjgwMkI2OjJEOTM5QTg6NkIwMjRGM0UiLCJ2aXNpdG9yX2lkIjoiODAzODY2MDE1Njc4MDg1OTE5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfb75f5250e0b00d78e4043ec991149bd4aa109ff1701e7971f521038ec800d9c
hovercard-subject-tagpull_request:4167686241
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154913/files
twitter:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
og:image:alt_io_StringIO_read_impl() clamps the read size to zero when the position is past the end of the buffer, but still forms the pointer self->buf + self->pos before returning. Nothing is read thro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154913/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154913%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154913%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154913/files
Reloadhttps://github.com/python/cpython/pull/154913/files
Reloadhttps://github.com/python/cpython/pull/154913/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
matthiasgoergenshttps://github.com/matthiasgoergens
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:stringio-overseek-ubhttps://github.com/matthiasgoergens/cpython/tree/stringio-overseek-ub
Conversation 11 https://github.com/python/cpython/pull/154913
Commits 4 https://github.com/python/cpython/pull/154913/commits
Checks 49 https://github.com/python/cpython/pull/154913/checks
Files changed https://github.com/python/cpython/pull/154913/files
Please reload this pagehttps://github.com/python/cpython/pull/154913/files
gh-148286: Fix undefined behaviour in io.StringIO.read() after an overseek https://github.com/python/cpython/pull/154913/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/154913/files
addc87f gh-148286: Fix undefined behaviour in io.StringIO.read() after an ove… matthiasgoergens Jul 30, 2026 https://github.com/python/cpython/pull/154913/commits/addc87f58c13d53290064d71638492f669580815
0d659fa Add a regression test for large overseeks; trim the NEWS entry matthiasgoergens Aug 1, 2026 https://github.com/python/cpython/pull/154913/commits/0d659fac09ddfac7a7f73507484729d93dd0fdc3
9d3ba83 Drop the added test; the existing testSeek already covers this matthiasgoergens Aug 1, 2026 https://github.com/python/cpython/pull/154913/commits/9d3ba83929666a0f21bbe06fccd3de757155ee08
047e967 Restore the suppressed reference in the NEWS entry matthiasgoergens Aug 1, 2026 https://github.com/python/cpython/pull/154913/commits/047e967405b4e3371592944aa452a24efb52e8c1
Clear filters https://github.com/python/cpython/pull/154913/files
Please reload this pagehttps://github.com/python/cpython/pull/154913/files
Please reload this pagehttps://github.com/python/cpython/pull/154913/files
test_memoryio.py https://github.com/python/cpython/pull/154913/files#diff-437d27266beabfc02bcd01a41b6d3f9f82c4242087c0be99caad811a6b296776
2026-07-30-12-05-00.gh-issue-148286.Bv3Nq8.rst https://github.com/python/cpython/pull/154913/files#diff-bb998abd3db1d958659a7fdc856319e8b8454ae44973b3c60f74a0714c052177
stringio.c https://github.com/python/cpython/pull/154913/files#diff-216e14277a43aeac4f2fcbb183e3898c54abbd90bc8e822e9e7460bc2af69667
suppressions.txt https://github.com/python/cpython/pull/154913/files#diff-702de60c74ca92f35f0fd6824405a53ef373113035944c92f2f9596e5a8b99e7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/test/test_io/test_memoryio.pyhttps://github.com/python/cpython/pull/154913/files#diff-437d27266beabfc02bcd01a41b6d3f9f82c4242087c0be99caad811a6b296776
View file https://github.com/python/cpython/blob/047e967405b4e3371592944aa452a24efb52e8c1/Lib/test/test_io/test_memoryio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154913/files#diff-437d27266beabfc02bcd01a41b6d3f9f82c4242087c0be99caad811a6b296776
https://github.com/python/cpython/pull/154913/files#diff-437d27266beabfc02bcd01a41b6d3f9f82c4242087c0be99caad811a6b296776
Misc/NEWS.d/next/Library/2026-07-30-12-05-00.gh-issue-148286.Bv3Nq8.rsthttps://github.com/python/cpython/pull/154913/files#diff-bb998abd3db1d958659a7fdc856319e8b8454ae44973b3c60f74a0714c052177
View file https://github.com/python/cpython/blob/047e967405b4e3371592944aa452a24efb52e8c1/Misc/NEWS.d/next/Library/2026-07-30-12-05-00.gh-issue-148286.Bv3Nq8.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154913/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L527
Modules/_io/stringio.chttps://github.com/python/cpython/pull/154913/files#diff-216e14277a43aeac4f2fcbb183e3898c54abbd90bc8e822e9e7460bc2af69667
View file https://github.com/python/cpython/blob/047e967405b4e3371592944aa452a24efb52e8c1/Modules/_io/stringio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154913/files#diff-216e14277a43aeac4f2fcbb183e3898c54abbd90bc8e822e9e7460bc2af69667
https://github.com/python/cpython/pull/154913/files#diff-216e14277a43aeac4f2fcbb183e3898c54abbd90bc8e822e9e7460bc2af69667
Tools/ubsan/suppressions.txthttps://github.com/python/cpython/pull/154913/files#diff-702de60c74ca92f35f0fd6824405a53ef373113035944c92f2f9596e5a8b99e7
View file https://github.com/python/cpython/blob/047e967405b4e3371592944aa452a24efb52e8c1/Tools/ubsan/suppressions.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154913/files#diff-702de60c74ca92f35f0fd6824405a53ef373113035944c92f2f9596e5a8b99e7
Please reload this pagehttps://github.com/python/cpython/pull/154913/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.