René's URL Explorer Experiment


Title: gh-150942: Speed up pyexpat attribute parsing by Punisheroot · Pull Request #154860 · python/cpython · GitHub

Open Graph Title: gh-150942: Speed up pyexpat attribute parsing by Punisheroot · Pull Request #154860 · python/cpython

X Title: gh-150942: Speed up pyexpat attribute parsing by Punisheroot · Pull Request #154860 · python/cpython

Description: Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value directly, removing the matching Py_DECREF() calls on both the success and error paths. This keeps the existing behavior and error handling while doing less reference count work. Benchmark Benchmarks used pyperf 2.10.0 on CPython main 3.16.0a0 at revision 8b048eb35e, built for Windows x64 with the official PCbuild PGO/PGUpdate configuration and link-time code generation. Baseline and patched runs used the same interpreter and PGO profile; only the pyexpat extension binary was swapped. Each worker used CPU 1 affinity and high process priority. The workloads parse complete XML documents with: 2,000 elements and 16 attributes per element 20,000 elements and 2 attributes per element 200 elements and 64 attributes per element Regular build: Benchmark Baseline Patched Change many attributes per element 3.42 ms 3.35 ms 1.02x faster few attributes, many elements 6.22 ms 6.02 ms 1.03x faster wide attribute dictionaries 1.33 ms 1.31 ms 1.02x faster geometric mean reference 1.02x faster Free-threaded build (Py_GIL_DISABLED=1, sys._is_gil_enabled() == False): Benchmark Baseline Patched Change many attributes per element 3.59 ms 3.49 ms 1.03x faster few attributes, many elements 6.68 ms 6.48 ms 1.03x faster wide attribute dictionaries 1.42 ms 1.39 ms 1.03x faster geometric mean reference 1.03x faster pyperf check reported both free-threaded result files as stable. The benchmark is single-threaded, including on the free-threaded interpreter, so it measures the direct parsing cost rather than concurrent scalability. Validation PCbuild\amd64\python.exe -m test test_pyexpat: passed (86 tests, 1 skipped) PCbuild\amd64t\python.exe -m test test_pyexpat: passed (86 tests, 1 skipped) PCbuild\amd64\python_d.exe -m test -R 3:3 test_pyexpat: passed python.bat -m patchcheck: passed git diff --check: passed regular and free-threaded PGO training: passed (10,501 tests in each build) Issue: gh-150942

Open Graph Description: Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value dir...

X Description: Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value dir...

Opengraph URL: https://github.com/python/cpython/pull/154860

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e212350d-207f-44e3-1d02-7d85120cdcad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEA6:4279A:33F0456:45D3A92:6B0216AA
html-safe-nonce09484f774b0c2152620c9d62888cbd0c2b83aa21c92eb16635b38f716f378746
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE2OjQyNzlBOjMzRjA0NTY6NDVEM0E5Mjo2QjAyMTZBQSIsInZpc2l0b3JfaWQiOiI4NzcxMjMxMzkxMDYyMDM4MTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacad7c1834c7e56fbaa3d481e3c6d221f5c43ce36bdd6112e1eb2ae000f1a28fea
hovercard-subject-tagpull_request:4158724473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154860/files
twitter:imagehttps://avatars.githubusercontent.com/u/44579963?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/44579963?s=400&v=4
og:image:altSummary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value dir...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154860/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154860%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154860%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154860/files
Reloadhttps://github.com/python/cpython/pull/154860/files
Reloadhttps://github.com/python/cpython/pull/154860/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Punisheroothttps://github.com/Punisheroot
python:mainhttps://github.com/python/cpython/tree/main
Punisheroot:perf/js/optimize-pyexpat-attributeshttps://github.com/Punisheroot/cpython/tree/perf/js/optimize-pyexpat-attributes
Conversation 2 https://github.com/python/cpython/pull/154860
Commits 1 https://github.com/python/cpython/pull/154860/commits
Checks 51 https://github.com/python/cpython/pull/154860/checks
Files changed 1 https://github.com/python/cpython/pull/154860/files
gh-150942: Speed up pyexpat attribute parsing https://github.com/python/cpython/pull/154860/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/154860/files
11e4a58 gh-150942: Speed up pyexpat attribute parsing Punisheroot Jul 29, 2026 https://github.com/python/cpython/pull/154860/commits/11e4a58fe03c8988c4001dad0dc0c875b5da69b6
Clear filters https://github.com/python/cpython/pull/154860/files
Please reload this pagehttps://github.com/python/cpython/pull/154860/files
Please reload this pagehttps://github.com/python/cpython/pull/154860/files
Modules/pyexpat.chttps://github.com/python/cpython/pull/154860/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
View file https://github.com/python/cpython/blob/11e4a58fe03c8988c4001dad0dc0c875b5da69b6/Modules/pyexpat.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154860/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154860/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
https://github.com/python/cpython/pull/154860/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
https://github.com/python/cpython/pull/154860/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
https://github.com/python/cpython/pull/154860/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
Please reload this pagehttps://github.com/python/cpython/pull/154860/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.