Title: gh-150942: Speed up pyexpat attribute parsing by Punisheroot · Pull Request #154860 · python/cpython · GitHub
Open Graph Title: gh-150942: Speed up pyexpat attribute parsing by Punisheroot · Pull Request #154860 · python/cpython
X Title: gh-150942: Speed up pyexpat attribute parsing by Punisheroot · Pull Request #154860 · python/cpython
Description: Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value directly, removing the matching Py_DECREF() calls on both the success and error paths. This keeps the existing behavior and error handling while doing less reference count work. Benchmark Benchmarks used pyperf 2.10.0 on CPython main 3.16.0a0 at revision 8b048eb35e, built for Windows x64 with the official PCbuild PGO/PGUpdate configuration and link-time code generation. Baseline and patched runs used the same interpreter and PGO profile; only the pyexpat extension binary was swapped. Each worker used CPU 1 affinity and high process priority. The workloads parse complete XML documents with: 2,000 elements and 16 attributes per element 20,000 elements and 2 attributes per element 200 elements and 64 attributes per element Regular build: Benchmark Baseline Patched Change many attributes per element 3.42 ms 3.35 ms 1.02x faster few attributes, many elements 6.22 ms 6.02 ms 1.03x faster wide attribute dictionaries 1.33 ms 1.31 ms 1.02x faster geometric mean reference 1.02x faster Free-threaded build (Py_GIL_DISABLED=1, sys._is_gil_enabled() == False): Benchmark Baseline Patched Change many attributes per element 3.59 ms 3.49 ms 1.03x faster few attributes, many elements 6.68 ms 6.48 ms 1.03x faster wide attribute dictionaries 1.42 ms 1.39 ms 1.03x faster geometric mean reference 1.03x faster pyperf check reported both free-threaded result files as stable. The benchmark is single-threaded, including on the free-threaded interpreter, so it measures the direct parsing cost rather than concurrent scalability. Validation PCbuild\amd64\python.exe -m test test_pyexpat: passed (86 tests, 1 skipped) PCbuild\amd64t\python.exe -m test test_pyexpat: passed (86 tests, 1 skipped) PCbuild\amd64\python_d.exe -m test -R 3:3 test_pyexpat: passed python.bat -m patchcheck: passed git diff --check: passed regular and free-threaded PGO training: passed (10,501 tests in each build) Issue: gh-150942
Open Graph Description: Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value dir...
X Description: Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value dir...
Opengraph URL: https://github.com/python/cpython/pull/154860
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e212350d-207f-44e3-1d02-7d85120cdcad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEA6:4279A:33F0456:45D3A92:6B0216AA |
| html-safe-nonce | 09484f774b0c2152620c9d62888cbd0c2b83aa21c92eb16635b38f716f378746 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE2OjQyNzlBOjMzRjA0NTY6NDVEM0E5Mjo2QjAyMTZBQSIsInZpc2l0b3JfaWQiOiI4NzcxMjMxMzkxMDYyMDM4MTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ad7c1834c7e56fbaa3d481e3c6d221f5c43ce36bdd6112e1eb2ae000f1a28fea |
| hovercard-subject-tag | pull_request:4158724473 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/154860/files |
| twitter:image | https://avatars.githubusercontent.com/u/44579963?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/44579963?s=400&v=4 |
| og:image:alt | Summary my_StartElementHandler() builds a new dictionary for unordered element attributes. Use _PyDict_SetItem_Take2() there so the dictionary insertion consumes the newly created key and value dir... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width