René's URL Explorer Experiment


Title: gh-154719: Preserve trailing whitespace in t-string interpolation expressions by lpyu001 · Pull Request #154762 · python/cpython · GitHub

Open Graph Title: gh-154719: Preserve trailing whitespace in t-string interpolation expressions by lpyu001 · Pull Request #154762 · python/cpython

X Title: gh-154719: Preserve trailing whitespace in t-string interpolation expressions by lpyu001 · Pull Request #154762 · python/cpython

Description: 1. Interpolation.expression did not match its documented contract Doc/library/string.templatelib.rst states that, for interpolations created by t-string literals, expression is the expression text found inside the curly brackets ({ & }), including any whitespace, excluding the curly brackets themselves, and ending before the first !, :, or = if any is present. Whitespace after { was preserved, but whitespace before }, !, : or a debug = was removed: >>> t"{ x }".interpolations[0].expression ' x' # expected ' x ' >>> t"{ x }".interpolations[0].expression ' x' # expected ' x ' >>> t"""{ ... x ... }""".interpolations[0].expression '\n x' # expected '\n x\n' The asymmetry is not documented anywhere: leading whitespace was kept, trailing whitespace was dropped. 2. ast.unparse() could emit code that no longer parses When the interpolation ended with an explicit line continuation, stripping the trailing whitespace also removed the newline that terminated it, leaving a dangling backslash in Interpolation.str: >>> src = 't"""{x \\\n}"""' >>> ast.parse(src).body[0].value.values[0].str 'x \\' # the line continuation lost its newline >>> ast.unparse(ast.parse(src)) "t'{x \\}'" >>> ast.parse(ast.unparse(ast.parse(src))) SyntaxError: unexpected character after line continuation character Root cause _strip_interpolation_expr() in Parser/action_helpers.c was applied to every interpolation, not just debug ones. It walked backwards over the lexer metadata removing every trailing whitespace character and =, which is only correct for the debug (=) form, where the trailing = and the text after it belong to the debug text rather than to the expression. Solution Regular interpolations now use the lexer metadata verbatim. Debug interpolations keep the text that precedes the debug = and discard only the = itself plus the whitespace and explicit line continuations that follow it. Per the documentation the expression ends before the =, so t"""{value =\}""" yields 'value ', and the \ stays in the debug text. If the debug marker turns out to be absent, the metadata is returned unchanged instead of silently dropping source text. Issue: gh-154719

Open Graph Description: 1. Interpolation.expression did not match its documented contract Doc/library/string.templatelib.rst states that, for interpolations created by t-string literals, expression is the expression text...

X Description: 1. Interpolation.expression did not match its documented contract Doc/library/string.templatelib.rst states that, for interpolations created by t-string literals, expression is the expression text...

Opengraph URL: https://github.com/python/cpython/pull/154762

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0a775aeb-e38b-9b72-9152-749392237478
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE6A:2E3FEE:405469C:51646A2:6B021679
html-safe-nonce6ba9f1492e694a2245dc221566c09b907d7ff5f8314a05d59add59a3580e0105
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTZBOjJFM0ZFRTo0MDU0NjlDOjUxNjQ2QTI6NkIwMjE2NzkiLCJ2aXNpdG9yX2lkIjoiODM5MDg1NzY4NDE5MDEwNzI1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca775fb1eec5e08e4ae68249f34756c2eb69fc0aadf9bbe41fed0c4769bfaa8be
hovercard-subject-tagpull_request:4141181453
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154762/files
twitter:imagehttps://avatars.githubusercontent.com/u/189712014?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/189712014?s=400&v=4
og:image:alt1. Interpolation.expression did not match its documented contract Doc/library/string.templatelib.rst states that, for interpolations created by t-string literals, expression is the expression text...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154762/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154762%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154762%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154762/files
Reloadhttps://github.com/python/cpython/pull/154762/files
Reloadhttps://github.com/python/cpython/pull/154762/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
lpyu001:fix-tstringhttps://github.com/lpyu001/cpython/tree/fix-tstring
Conversation 14 https://github.com/python/cpython/pull/154762
Commits 6 https://github.com/python/cpython/pull/154762/commits
Checks 68 https://github.com/python/cpython/pull/154762/checks
Files changed https://github.com/python/cpython/pull/154762/files
Please reload this pagehttps://github.com/python/cpython/pull/154762/files
gh-154719: Preserve trailing whitespace in t-string interpolation expressions https://github.com/python/cpython/pull/154762/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/154762/files
f54fc47 Preserve trailing whitespace in t-string interpolation expressions lpyu001 Jul 27, 2026 https://github.com/python/cpython/pull/154762/commits/f54fc473881b4be599e4223c092d20f360b816d3
9f5a8e0 address review lpyu001 Jul 28, 2026 https://github.com/python/cpython/pull/154762/commits/9f5a8e022886c88cd9607331ef185ecc8ebd188c
0cdcfbd Update 2026-07-27-17-20-49.gh-issue-154719.eI88Gs.rst lpyu001 Jul 29, 2026 https://github.com/python/cpython/pull/154762/commits/0cdcfbd920a5d8750ecc6a2867663a30e360e40a
41260d8 Merge upstream/main into fix-tstring lpyu001 Sep 11, 2026 https://github.com/python/cpython/pull/154762/commits/41260d8548a22d787bc07053711881af1d02ebc6
93b80cc update news lpyu001 Sep 12, 2026 https://github.com/python/cpython/pull/154762/commits/93b80cc91a0fc3bd43e60370c7ae8a3b1e4b2bbc
115e397 Merge branch 'main' into fix-tstring lpyu001 Sep 12, 2026 https://github.com/python/cpython/pull/154762/commits/115e39740249bb10103846a593f8a9453ac95200
Clear filters https://github.com/python/cpython/pull/154762/files
Please reload this pagehttps://github.com/python/cpython/pull/154762/files
Please reload this pagehttps://github.com/python/cpython/pull/154762/files
test_annotationlib.py https://github.com/python/cpython/pull/154762/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
test_fstring.py https://github.com/python/cpython/pull/154762/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
test_tstring.py https://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
test_unparse.py https://github.com/python/cpython/pull/154762/files#diff-1393034a674edcc67802941e0e8cfa4966c9927ba9bde2cace103593140e3f89
2026-07-27-17-20-49.gh-issue-154719.eI88Gs.rst https://github.com/python/cpython/pull/154762/files#diff-6bbb3f62adca845b33658918e8ffbb60610dd6b938b315005a96cde03b4fb4fb
action_helpers.c https://github.com/python/cpython/pull/154762/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L366
Lib/test/test_annotationlib.pyhttps://github.com/python/cpython/pull/154762/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
View file https://github.com/lpyu001/cpython/blob/115e39740249bb10103846a593f8a9453ac95200/Lib/test/test_annotationlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154762/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154762/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/154762/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
Lib/test/test_fstring.pyhttps://github.com/python/cpython/pull/154762/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
View file https://github.com/lpyu001/cpython/blob/115e39740249bb10103846a593f8a9453ac95200/Lib/test/test_fstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154762/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154762/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
https://github.com/python/cpython/pull/154762/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L349
Lib/test/test_tstring.pyhttps://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
View file https://github.com/lpyu001/cpython/blob/115e39740249bb10103846a593f8a9453ac95200/Lib/test/test_tstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154762/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
https://github.com/python/cpython/pull/154762/files#diff-8ec218d660fe515f0fe91bca85302204ea791b710cbba8985aaa30f2ff5fafdb
Lib/test/test_unparse.pyhttps://github.com/python/cpython/pull/154762/files#diff-1393034a674edcc67802941e0e8cfa4966c9927ba9bde2cace103593140e3f89
View file https://github.com/lpyu001/cpython/blob/115e39740249bb10103846a593f8a9453ac95200/Lib/test/test_unparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154762/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154762/files#diff-1393034a674edcc67802941e0e8cfa4966c9927ba9bde2cace103593140e3f89
https://github.com/python/cpython/pull/154762/files#diff-1393034a674edcc67802941e0e8cfa4966c9927ba9bde2cace103593140e3f89
Misc/NEWS.d/next/Core_and_Builtins/2026-07-27-17-20-49.gh-issue-154719.eI88Gs.rsthttps://github.com/python/cpython/pull/154762/files#diff-6bbb3f62adca845b33658918e8ffbb60610dd6b938b315005a96cde03b4fb4fb
View file https://github.com/lpyu001/cpython/blob/115e39740249bb10103846a593f8a9453ac95200/Misc/NEWS.d/next/Core_and_Builtins/2026-07-27-17-20-49.gh-issue-154719.eI88Gs.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154762/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/action_helpers.chttps://github.com/python/cpython/pull/154762/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
View file https://github.com/lpyu001/cpython/blob/115e39740249bb10103846a593f8a9453ac95200/Parser/action_helpers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154762/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154762/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/154762/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/154762/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/154762/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
Please reload this pagehttps://github.com/python/cpython/pull/154762/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.