René's URL Explorer Experiment


Title: gh-154561: Check module dict after trying to load submodule by johnslavik · Pull Request #154742 · python/cpython · GitHub

Open Graph Title: gh-154561: Check module dict after trying to load submodule by johnslavik · Pull Request #154742 · python/cpython

X Title: gh-154561: Check module dict after trying to load submodule by johnslavik · Pull Request #154742 · python/cpython

Description: Locally I bumped the test to use 100 threads for higher failure reproducibility: diff --git a/Lib/test/test_lazy_import/__init__.py b/Lib/test/test_lazy_import/__init__.py index 899ecec1ba2..3d44d2d04c9 100644 --- a/Lib/test/test_lazy_import/__init__.py +++ b/Lib/test/test_lazy_import/__init__.py @@ -1794,7 +1794,7 @@ def test_concurrent_lazy_import_reification(self): """Multiple threads racing to reify the same lazy import should succeed.""" from test.test_lazy_import.data import basic_unused - num_threads = 10 + num_threads = 100 results = [None] * num_threads errors = [] barrier = threading.Barrier(num_threads) I cannot reproduce failures after the proposed change: after trying to load the submodule, we re-check the module dict in case a different thread beat us to it, in which case the attribute can be returned directly. Issue: gh-154561

Open Graph Description: Locally I bumped the test to use 100 threads for higher failure reproducibility: diff --git a/Lib/test/test_lazy_import/__init__.py b/Lib/test/test_lazy_import/__init__.py index 899ecec1ba2..3d44d2...

X Description: Locally I bumped the test to use 100 threads for higher failure reproducibility: diff --git a/Lib/test/test_lazy_import/__init__.py b/Lib/test/test_lazy_import/__init__.py index 899ecec1ba2..3d44d2...

Opengraph URL: https://github.com/python/cpython/pull/154742

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1d551934-feb7-0aab-9131-5a1d7495bd83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD020:1F87:5AB7CF:71D7AF:6B02140C
html-safe-nonce997ff3bcc3476043dea5446869b01346ac68a3d5581e8188fb5f04cbff94619e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDIwOjFGODc6NUFCN0NGOjcxRDdBRjo2QjAyMTQwQyIsInZpc2l0b3JfaWQiOiI2ODk2MjA0ODAwMjc5NTgxNzA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd6f138b27cfb04df3d485481a7aa69ecd625cda89a40ff741812ed0f4897f830
hovercard-subject-tagpull_request:4137014731
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154742/files
twitter:imagehttps://avatars.githubusercontent.com/u/64036239?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/64036239?s=400&v=4
og:image:altLocally I bumped the test to use 100 threads for higher failure reproducibility: diff --git a/Lib/test/test_lazy_import/__init__.py b/Lib/test/test_lazy_import/__init__.py index 899ecec1ba2..3d44d2...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154742/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154742%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154742%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154742/files
Reloadhttps://github.com/python/cpython/pull/154742/files
Reloadhttps://github.com/python/cpython/pull/154742/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
johnslavikhttps://github.com/johnslavik
python:mainhttps://github.com/python/cpython/tree/main
johnslavik:gh-154561https://github.com/johnslavik/cpython/tree/gh-154561
Conversation 2 https://github.com/python/cpython/pull/154742
Commits 2 https://github.com/python/cpython/pull/154742/commits
Checks 57 https://github.com/python/cpython/pull/154742/checks
Files changed https://github.com/python/cpython/pull/154742/files
Please reload this pagehttps://github.com/python/cpython/pull/154742/files
gh-154561: Check module dict after trying to load submodule https://github.com/python/cpython/pull/154742/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/154742/files
c4c0e46 Check module dict after trying to load submodule johnslavik Jul 26, 2026 https://github.com/python/cpython/pull/154742/commits/c4c0e46eef7c25db5c1a23d783e260916428801f
05ce6ef Add news entry johnslavik Jul 26, 2026 https://github.com/python/cpython/pull/154742/commits/05ce6ef1e9993c2037ecbe850b2689f6c9917a45
Clear filters https://github.com/python/cpython/pull/154742/files
Please reload this pagehttps://github.com/python/cpython/pull/154742/files
Please reload this pagehttps://github.com/python/cpython/pull/154742/files
2026-07-26-18-34-45.gh-issue-154561.vuDLtN.rst https://github.com/python/cpython/pull/154742/files#diff-eb518a36a2f7ed6f09e775b758a9f37e5b8224c7c0db3dac2ba9eadefaf00361
moduleobject.c https://github.com/python/cpython/pull/154742/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
Misc/NEWS.d/next/Core_and_Builtins/2026-07-26-18-34-45.gh-issue-154561.vuDLtN.rsthttps://github.com/python/cpython/pull/154742/files#diff-eb518a36a2f7ed6f09e775b758a9f37e5b8224c7c0db3dac2ba9eadefaf00361
View file https://github.com/johnslavik/cpython/blob/05ce6ef1e9993c2037ecbe850b2689f6c9917a45/Misc/NEWS.d/next/Core_and_Builtins/2026-07-26-18-34-45.gh-issue-154561.vuDLtN.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154742/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L267
Objects/moduleobject.chttps://github.com/python/cpython/pull/154742/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
View file https://github.com/johnslavik/cpython/blob/05ce6ef1e9993c2037ecbe850b2689f6c9917a45/Objects/moduleobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154742/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154742/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
https://github.com/python/cpython/pull/154742/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
Please reload this pagehttps://github.com/python/cpython/pull/154742/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.