René's URL Explorer Experiment


Title: gh-154387: validate `PyStructSequence_Desc` field invariants by XuehaiPan · Pull Request #154684 · python/cpython · GitHub

Open Graph Title: gh-154387: validate `PyStructSequence_Desc` field invariants by XuehaiPan · Pull Request #154684 · python/cpython

X Title: gh-154387: validate `PyStructSequence_Desc` field invariants by XuehaiPan · Pull Request #154684 · python/cpython

Description: The current PyStructSequence related code is heavily under the assumptions: {every unnamed field} in {visible range} n_unnamed <= n_in_sequence and n_in_sequence <= n_fields n_in_sequence >= 0 but we never validate these constraints. Data can be silently lost (unaccessible) if an unnamed field is defined out of the visible range, i.e., the data cannot be accessed either from slicing seq[i] or member lookup seq.name. This PR enforces the constraints mentioned above. count_members() now raises SystemError (returning -1) when a struct sequence descriptor places an unnamed field outside the visible sequence fields, or when n_in_sequence exceeds the total number of fields; such descriptors previously built a malformed type. The failure is propagated by PyStructSequence_NewType(), PyStructSequence_InitType() and PyStructSequence_InitType2(). Add _testcapi helpers and regression tests for both rejected cases, and document the invariants in the C API reference. Issue: gh-154387

Open Graph Description: The current PyStructSequence related code is heavily under the assumptions: {every unnamed field} in {visible range} n_unnamed <= n_in_sequence and n_in_sequence <= n_fields n_in_sequence &g...

X Description: The current PyStructSequence related code is heavily under the assumptions: {every unnamed field} in {visible range} n_unnamed &lt;= n_in_sequence and n_in_sequence &lt;= n_fields n_in_seq...

Opengraph URL: https://github.com/python/cpython/pull/154684

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63b54ed2-5f43-1850-d699-c790a173d59f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC5E:2E7EBB:42E72C3:549B0E5:6B021BD7
html-safe-nonceb5342941ea5936ae856337b0fd4ac4090f84af14da8754b8a5ba13d4f3427001
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzVFOjJFN0VCQjo0MkU3MkMzOjU0OUIwRTU6NkIwMjFCRDciLCJ2aXNpdG9yX2lkIjoiNDI3MTY5NDUxNDk5MDc1MDY3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac76f9bae4dded77446c7acffd1de44b4cf65b389a3c9ee7873133a11b3193950b
hovercard-subject-tagpull_request:4131829658
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154684/files
twitter:imagehttps://avatars.githubusercontent.com/u/16078332?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16078332?s=400&v=4
og:image:altThe current PyStructSequence related code is heavily under the assumptions: {every unnamed field} in {visible range} n_unnamed <= n_in_sequence and n_in_sequence <= n_fields n_in_sequence &g...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154684/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154684%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154684%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154684/files
Reloadhttps://github.com/python/cpython/pull/154684/files
Reloadhttps://github.com/python/cpython/pull/154684/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
XuehaiPanhttps://github.com/XuehaiPan
python:mainhttps://github.com/python/cpython/tree/main
XuehaiPan:fix-structseq-validate-deschttps://github.com/XuehaiPan/cpython/tree/fix-structseq-validate-desc
Conversation 3 https://github.com/python/cpython/pull/154684
Commits 17 https://github.com/python/cpython/pull/154684/commits
Checks 53 https://github.com/python/cpython/pull/154684/checks
Files changed https://github.com/python/cpython/pull/154684/files
Please reload this pagehttps://github.com/python/cpython/pull/154684/files
gh-154387: validate PyStructSequence_Desc field invariants https://github.com/python/cpython/pull/154684/files#top
Show all changes 17 commits https://github.com/python/cpython/pull/154684/files
4260f76 fix(structseq): validate PyStructSequence_Desc field invariants XuehaiPan Jul 25, 2026 https://github.com/python/cpython/pull/154684/commits/4260f7632519e27e9f0f2b9599823355c6111693
a06b349 fix(structseq): reject negative n_in_sequence and fix int format spec… XuehaiPan Jul 25, 2026 https://github.com/python/cpython/pull/154684/commits/a06b34929dd636fa5a1397d6d88c2e117d1efc13
29c4c2e fix: remove `test_` prefix for functions in `_testcapi` XuehaiPan Jul 25, 2026 https://github.com/python/cpython/pull/154684/commits/29c4c2e77de7b80c04e2adc966a6dd6f8cf910e5
34ae4ba Merge remote-tracking branch 'origin/main' into fix-structseq-validat… XuehaiPan Jul 25, 2026 https://github.com/python/cpython/pull/154684/commits/34ae4bac43b07fc3ab62757df359f2a7db91a18f
b49a073 Merge branch 'main' into fix-structseq-validate-desc XuehaiPan Jul 25, 2026 https://github.com/python/cpython/pull/154684/commits/b49a073db2571ed8fe5b2e9089ce258f868d9f2b
de1210f Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Jul 26, 2026 https://github.com/python/cpython/pull/154684/commits/de1210f88c118d3538a4692e8376e69c9fb7cb78
0d573e9 Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Jul 26, 2026 https://github.com/python/cpython/pull/154684/commits/0d573e948940b46b74834be3d97bc648306039a0
57095f0 ci: try fix ci XuehaiPan Jul 26, 2026 https://github.com/python/cpython/pull/154684/commits/57095f02ba8a115d370bf009ba848d9d3847487f
7f8b035 Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Aug 4, 2026 https://github.com/python/cpython/pull/154684/commits/7f8b0356f7cfe0ebd4309c47780e8179e5665e52
d5771c0 ci: try fix ci XuehaiPan Aug 4, 2026 https://github.com/python/cpython/pull/154684/commits/d5771c07b488be88a5268fc1af9d66802df71626
7508a14 Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Aug 4, 2026 https://github.com/python/cpython/pull/154684/commits/7508a14052d484ae866ea9cde9f46ca6efaef980
c1c5795 Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Aug 13, 2026 https://github.com/python/cpython/pull/154684/commits/c1c57956cc32dee51195515596a3831e5394cf42
9ba8e7c Merge branch 'main' into fix-structseq-validate-desc XuehaiPan Sep 1, 2026 https://github.com/python/cpython/pull/154684/commits/9ba8e7c82eb62398176ea90ff4f387bc19fbeb4d
245642f Merge branch 'main' into fix-structseq-validate-desc XuehaiPan Sep 27, 2026 https://github.com/python/cpython/pull/154684/commits/245642f077398e9bbf81569923774da1980480d3
54a1721 Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Oct 29, 2026 https://github.com/python/cpython/pull/154684/commits/54a1721495ab1c7cd218262a959d6425534b5432
ba9b93e Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Nov 2, 2026 https://github.com/python/cpython/pull/154684/commits/ba9b93e7d2fe83f6288eddfce4c48f46168922e6
eaae786 Merge remote-tracking branch 'upstream/main' into fix-structseq-valid… XuehaiPan Nov 17, 2026 https://github.com/python/cpython/pull/154684/commits/eaae786f8d8db38c3711e4154e7b9ace2d5f91aa
Clear filters https://github.com/python/cpython/pull/154684/files
Please reload this pagehttps://github.com/python/cpython/pull/154684/files
Please reload this pagehttps://github.com/python/cpython/pull/154684/files
tuple.rst https://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
test_structseq.py https://github.com/python/cpython/pull/154684/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
2026-07-25-15-28-37.gh-issue-154387.cR09uA.rst https://github.com/python/cpython/pull/154684/files#diff-2f0d7110e43d2c7c954ab0da8e4056bd084605218231fe990db31edf4da25d0c
_testcapimodule.c https://github.com/python/cpython/pull/154684/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
structseq.c https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L114
Doc/c-api/tuple.rsthttps://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
View file https://github.com/python/cpython/blob/eaae786f8d8db38c3711e4154e7b9ace2d5f91aa/Doc/c-api/tuple.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154684/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
https://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
https://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
https://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
https://github.com/python/cpython/pull/154684/files#diff-1f9f4a69af6c7b0136a95e38b6e38fcc89564d912327acd8d0b9ba3047bd8b58
Lib/test/test_structseq.pyhttps://github.com/python/cpython/pull/154684/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
View file https://github.com/python/cpython/blob/eaae786f8d8db38c3711e4154e7b9ace2d5f91aa/Lib/test/test_structseq.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154684/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154684/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
https://github.com/python/cpython/pull/154684/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
Misc/NEWS.d/next/C_API/2026-07-25-15-28-37.gh-issue-154387.cR09uA.rsthttps://github.com/python/cpython/pull/154684/files#diff-2f0d7110e43d2c7c954ab0da8e4056bd084605218231fe990db31edf4da25d0c
View file https://github.com/python/cpython/blob/eaae786f8d8db38c3711e4154e7b9ace2d5f91aa/Misc/NEWS.d/next/C_API/2026-07-25-15-28-37.gh-issue-154387.cR09uA.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154684/{{ revealButtonHref }}
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/154684/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/python/cpython/blob/eaae786f8d8db38c3711e4154e7b9ace2d5f91aa/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154684/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154684/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/154684/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/154684/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/154684/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
Objects/structseq.chttps://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
View file https://github.com/python/cpython/blob/eaae786f8d8db38c3711e4154e7b9ace2d5f91aa/Objects/structseq.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154684/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/154684/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
Please reload this pagehttps://github.com/python/cpython/pull/154684/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.