| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5d08ccc6-c9a3-2013-2d15-8f4387cc04ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7A8:31D532:1A535DF:22E6417:6B021CAE |
| html-safe-nonce | 9d5688f61007d36abff48e8b21b784f3c7123db01bd17faf64cd6d840221232e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0E4OjMxRDUzMjoxQTUzNURGOjIyRTY0MTc6NkIwMjFDQUUiLCJ2aXNpdG9yX2lkIjoiMTEzNzI2OTE1MDkyNjkwNDQ5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c6038abd2e1df3c28c7a70e6ebf6e5a01a3430558d09dbf711fba6beaf92c9c0 |
| hovercard-subject-tag | pull_request:4100736506 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/154370/files |
| twitter:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| og:image:alt | The window manager can take the focus from the application, ignore lift() and resize a toplevel on its own. Tk delivers generated keyboard events to the window which has the focus, so a test which ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/154370/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154370%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154370%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/154370/files |
| Reload | https://github.com/python/cpython/pull/154370/files |
| Reload | https://github.com/python/cpython/pull/154370/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
| serhiy-storchaka:gh-154357-dialog-focus-race | https://github.com/serhiy-storchaka/cpython/tree/gh-154357-dialog-focus-race |
|
Conversation
18
| https://github.com/python/cpython/pull/154370 |
|
Commits
7
| https://github.com/python/cpython/pull/154370/commits |
|
Checks
58
| https://github.com/python/cpython/pull/154370/checks |
|
Files changed
| https://github.com/python/cpython/pull/154370/files |
| Please reload this page | https://github.com/python/cpython/pull/154370/files |
|
gh-154357: Fix tkinter, ttk and IDLE tests depending on the window manager
| https://github.com/python/cpython/pull/154370/files#top |
|
Show all changes
7 commits
| https://github.com/python/cpython/pull/154370/files |
|
bf74908
gh-154357: Hide the root window in the tkinter dialog tests
serhiy-storchaka Jul 21, 2026
| https://github.com/python/cpython/pull/154370/commits/bf749089ebda53eb440efeaa400be989df8f9f4c |
|
5f7b036
gh-154357: Fix more flaky tkinter and ttk tests
serhiy-storchaka Jul 21, 2026
| https://github.com/python/cpython/pull/154370/commits/5f7b0362daf74d0bf1052d8373b84c0dc58a8980 |
|
94c32f1
gh-154357: Fix more flaky tkinter focus and stacking tests
serhiy-storchaka Sep 2, 2026
| https://github.com/python/cpython/pull/154370/commits/94c32f101861679cc2bb5a17ae036e1ad9b227c0 |
|
c2748c6
Merge branch 'main' into gh-154357-dialog-focus-race
serhiy-storchaka Sep 2, 2026
| https://github.com/python/cpython/pull/154370/commits/c2748c6a294234a22a6a6308c975817c0c6eaf4d |
|
76301d0
gh-154357: Tolerate additional focus events in test_focus
serhiy-storchaka Sep 7, 2026
| https://github.com/python/cpython/pull/154370/commits/76301d00ca90c6eec5f3c4048b01944fad0de9a9 |
|
06ee0ea
gh-154357: Fix flaky wait_until_mapped(full_size=True)
serhiy-storchaka Sep 7, 2026
| https://github.com/python/cpython/pull/154370/commits/06ee0ea328c51655055748d4c3bbfb82f8bf3085 |
|
3693d82
gh-154357: Take the focus right before generating a key event
serhiy-storchaka Sep 7, 2026
| https://github.com/python/cpython/pull/154370/commits/3693d822848a8404d4f2b4fd8bc5b797705dfc43 |
|
Clear filters
| https://github.com/python/cpython/pull/154370/files |
| Please reload this page | https://github.com/python/cpython/pull/154370/files |
| Please reload this page | https://github.com/python/cpython/pull/154370/files |
|
test_configdialog.py
| https://github.com/python/cpython/pull/154370/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839 |
|
support.py
| https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
|
test_filedialog.py
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
test_misc.py
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
test_simpledialog.py
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
test_widgets.py
| https://github.com/python/cpython/pull/154370/files#diff-f6a457ab81906f14719d086f9fec225d1810824da6b0b406d35dcb47262495a9 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508 |
| Lib/idlelib/idle_test/test_configdialog.py | https://github.com/python/cpython/pull/154370/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839 |
|
View file
| https://github.com/serhiy-storchaka/cpython/blob/3693d822848a8404d4f2b4fd8bc5b797705dfc43/Lib/idlelib/idle_test/test_configdialog.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/154370/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/154370/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839 |
|
| https://github.com/python/cpython/pull/154370/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839 |
|
| https://github.com/python/cpython/pull/154370/files#diff-34af67c34e8040e8d03842eed91604a2487f7dcbfd52d6a75d61d1a002ae2839 |
| Lib/test/test_tkinter/support.py | https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
|
View file
| https://github.com/serhiy-storchaka/cpython/blob/3693d822848a8404d4f2b4fd8bc5b797705dfc43/Lib/test/test_tkinter/support.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/154370/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
|
| https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
|
| https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
|
| https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
|
| https://github.com/python/cpython/pull/154370/files#diff-b483f2888642cfc241403650a4fabb51406285137ec531a12edda7772e789838 |
| Lib/test/test_tkinter/test_filedialog.py | https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
View file
| https://github.com/serhiy-storchaka/cpython/blob/3693d822848a8404d4f2b4fd8bc5b797705dfc43/Lib/test/test_tkinter/test_filedialog.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/154370/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
|
| https://github.com/python/cpython/pull/154370/files#diff-83746e6a81dcc2c4c89892d30ca532c3dc574613e1b87e3b10e2b80ea58c337b |
| Lib/test/test_tkinter/test_misc.py | https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
View file
| https://github.com/serhiy-storchaka/cpython/blob/3693d822848a8404d4f2b4fd8bc5b797705dfc43/Lib/test/test_tkinter/test_misc.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/154370/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
|
| https://github.com/python/cpython/pull/154370/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea |
| Lib/test/test_tkinter/test_simpledialog.py | https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
View file
| https://github.com/serhiy-storchaka/cpython/blob/3693d822848a8404d4f2b4fd8bc5b797705dfc43/Lib/test/test_tkinter/test_simpledialog.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/154370/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/154370/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
| Lib/test/test_ttk/test_widgets.py | https://github.com/python/cpython/pull/154370/files#diff-f6a457ab81906f14719d086f9fec225d1810824da6b0b406d35dcb47262495a9 |
|
View file
| https://github.com/serhiy-storchaka/cpython/blob/3693d822848a8404d4f2b4fd8bc5b797705dfc43/Lib/test/test_ttk/test_widgets.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/154370/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/154370/files#diff-f6a457ab81906f14719d086f9fec225d1810824da6b0b406d35dcb47262495a9 |
|
| https://github.com/python/cpython/pull/154370/files#diff-f6a457ab81906f14719d086f9fec225d1810824da6b0b406d35dcb47262495a9 |
| Please reload this page | https://github.com/python/cpython/pull/154370/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |