René's URL Explorer Experiment


Title: gh-154335: Allow disabling terminal colors in Tachyon's `pstats_collector` module by pfackeldey · Pull Request #154344 · python/cpython · GitHub

Open Graph Title: gh-154335: Allow disabling terminal colors in Tachyon's `pstats_collector` module by pfackeldey · Pull Request #154344 · python/cpython

X Title: gh-154335: Allow disabling terminal colors in Tachyon's `pstats_collector` module by pfackeldey · Pull Request #154344 · python/cpython

Description: This PR uses _colorize.get_colors() instead of the _colorize.ANSIColors enum. That way, one can disable terminal coloring through ANSI escape codes with e.g. setting certain env vars, such as NO_COLOR=1. I couldn't find an appropriate place for a test (and also I wasn't sure what's the best way to test this). Please let me know what your preference is regarding a test, and I'm happy to add it. Issue: gh-154335

Open Graph Description: This PR uses _colorize.get_colors() instead of the _colorize.ANSIColors enum. That way, one can disable terminal coloring through ANSI escape codes with e.g. setting certain env vars, such as NO_CO...

X Description: This PR uses _colorize.get_colors() instead of the _colorize.ANSIColors enum. That way, one can disable terminal coloring through ANSI escape codes with e.g. setting certain env vars, such as NO_CO...

Opengraph URL: https://github.com/python/cpython/pull/154344

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:164be779-7a84-00b6-5173-c697c8884d02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA526:1C94F:2FECCD8:3D66CC8:6B02127A
html-safe-nonce1db1ccdc843cd08cd8df4337c1ec88c5b59eec1667fa90738e7d6947cc899cfa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTI2OjFDOTRGOjJGRUNDRDg6M0Q2NkNDODo2QjAyMTI3QSIsInZpc2l0b3JfaWQiOiIxNzUxNDg5NzM5NTczMzAxODgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac872dfe2a75c7d5e6e562ffd4e37395acf439d92689f8cc8a384e7be335e8071b
hovercard-subject-tagpull_request:4098685811
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154344/files
twitter:imagehttps://avatars.githubusercontent.com/u/18463582?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18463582?s=400&v=4
og:image:altThis PR uses _colorize.get_colors() instead of the _colorize.ANSIColors enum. That way, one can disable terminal coloring through ANSI escape codes with e.g. setting certain env vars, such as NO_CO...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154344/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154344%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154344%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154344/files
Reloadhttps://github.com/python/cpython/pull/154344/files
Reloadhttps://github.com/python/cpython/pull/154344/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pfackeldey:tachyon/fix_pstats_coloringhttps://github.com/pfackeldey/cpython/tree/tachyon/fix_pstats_coloring
Conversation 15 https://github.com/python/cpython/pull/154344
Commits 6 https://github.com/python/cpython/pull/154344/commits
Checks 54 https://github.com/python/cpython/pull/154344/checks
Files changed https://github.com/python/cpython/pull/154344/files
Please reload this pagehttps://github.com/python/cpython/pull/154344/files
gh-154335: Allow disabling terminal colors in Tachyon's pstats_collector module https://github.com/python/cpython/pull/154344/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/154344/files
4e767b5 Use _colorize.get_colors() to allow disabling ANSI escape codes throu… pfackeldey Jul 21, 2026 https://github.com/python/cpython/pull/154344/commits/4e767b5406651da45fea95e09b75d5f4dca4a4e7
d5d629f add news entry pfackeldey Jul 21, 2026 https://github.com/python/cpython/pull/154344/commits/d5d629f1dcecc465be3ec1d7fe420d248bfd6806
1be0172 use get_colors() instead of ANSIColors enum also in Lib/profiling/sam… pfackeldey Jul 23, 2026 https://github.com/python/cpython/pull/154344/commits/1be0172048a362598ab43e26626c996c3d1e554c
f0d9823 fix data_lines collection of pstats lines for no-color mode pfackeldey Jul 23, 2026 https://github.com/python/cpython/pull/154344/commits/f0d9823a9f09b030ded928186971006a6a8b3a09
7d8e13f preserve lazy import of _colorize pfackeldey Jul 23, 2026 https://github.com/python/cpython/pull/154344/commits/7d8e13f2a015fcc8ff8b4a178ddaec7549d88731
43dd7fe gh-154335: Cover profiler color policy and update NEWS pablogsal Sep 24, 2026 https://github.com/python/cpython/pull/154344/commits/43dd7fee1841aaaf338b757a7c4e3af4613607b0
Clear filters https://github.com/python/cpython/pull/154344/files
Please reload this pagehttps://github.com/python/cpython/pull/154344/files
Please reload this pagehttps://github.com/python/cpython/pull/154344/files
pstats_collector.py https://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
sample.py https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
test_profiler.py https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
2026-07-21-12-23-48.gh-issue-154335.SRf8Gr.rst https://github.com/python/cpython/pull/154344/files#diff-aaa69e96066de3988a7455a0fb7b0650437da5ab759a6cbf5f15c4ad98d42491
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L567
Lib/profiling/sampling/pstats_collector.pyhttps://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
View file https://github.com/pfackeldey/cpython/blob/43dd7fee1841aaaf338b757a7c4e3af4613607b0/Lib/profiling/sampling/pstats_collector.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154344/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
https://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
https://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
https://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
https://github.com/python/cpython/pull/154344/files#diff-6f7b5859d8fbc9ad9c44b6e7d8d32841125505ffc946a8e01a9f2a911dcd7712
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L567
Lib/profiling/sampling/sample.pyhttps://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
View file https://github.com/pfackeldey/cpython/blob/43dd7fee1841aaaf338b757a7c4e3af4613607b0/Lib/profiling/sampling/sample.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154344/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/pull/154344/files#diff-c8bfacf5f7619a6d4ed5ace017d3c4baca18851fcdaf93f8a3814ca69f5b7a06
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L568
Lib/test/test_profiling/test_sampling_profiler/test_profiler.pyhttps://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
View file https://github.com/pfackeldey/cpython/blob/43dd7fee1841aaaf338b757a7c4e3af4613607b0/Lib/test/test_profiling/test_sampling_profiler/test_profiler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154344/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
maurycyhttps://github.com/maurycy
Sep 2, 2026https://github.com/python/cpython/pull/154344/files#r3915127729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/154344/files
https://github.com/python/cpython/pull/154344/files#diff-0c1150dee866f7b43a080b3e07d174a2dcb74a06e12945fbbe4fedec0d2b14c3
Misc/NEWS.d/next/Library/2026-07-21-12-23-48.gh-issue-154335.SRf8Gr.rsthttps://github.com/python/cpython/pull/154344/files#diff-aaa69e96066de3988a7455a0fb7b0650437da5ab759a6cbf5f15c4ad98d42491
View file https://github.com/pfackeldey/cpython/blob/43dd7fee1841aaaf338b757a7c4e3af4613607b0/Misc/NEWS.d/next/Library/2026-07-21-12-23-48.gh-issue-154335.SRf8Gr.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154344/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/154344/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.