René's URL Explorer Experiment


Title: gh-154275: Fix cleanup code in `_Py_make_parameters` by sobolevn · Pull Request #154341 · python/cpython · GitHub

Open Graph Title: gh-154275: Fix cleanup code in `_Py_make_parameters` by sobolevn · Pull Request #154341 · python/cpython

X Title: gh-154275: Fix cleanup code in `_Py_make_parameters` by sobolevn · Pull Request #154341 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is a correct version of #154277 I missed two cleanup cases 🙈 Issue: _Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #...

X Description: This is a correct version of #154277 I missed two cleanup cases 🙈 Issue: _Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #...

Opengraph URL: https://github.com/python/cpython/pull/154341

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b4ae6a3-e2a0-8b10-a0d2-eeebf10685dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECB8:158DF1:19B52E9:21EAC25:6B0212D3
html-safe-nonce82d3fc390ae6aa9be7b2f2e80bcf8e1e32aba364805cd777f21e03f67a4f6318
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0I4OjE1OERGMToxOUI1MkU5OjIxRUFDMjU6NkIwMjEyRDMiLCJ2aXNpdG9yX2lkIjoiNDI0MTUwMzQyNDYzNTYwNTcxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0ea50b7a98cb11fa7c2facb79c8d46e07e6c3875292fe200f64e68afac52828f
hovercard-subject-tagpull_request:4098406516
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/154341/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/483c559e23c86990865590db67248f935b7e08ab8cb752b09cd3afeb80c19b20/python/cpython/pull/154341
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/483c559e23c86990865590db67248f935b7e08ab8cb752b09cd3afeb80c19b20/python/cpython/pull/154341
og:image:altThis is a correct version of #154277 I missed two cleanup cases 🙈 Issue: _Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/154341#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154341
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154341
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154341
Reloadhttps://github.com/python/cpython/pull/154341
Reloadhttps://github.com/python/cpython/pull/154341
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:gh-154275https://github.com/sobolevn/cpython/tree/gh-154275
Conversationhttps://github.com/python/cpython/pull/154341
Commits1 (1)https://github.com/python/cpython/pull/154341/commits
Checkshttps://github.com/python/cpython/pull/154341/checks
Files changedhttps://github.com/python/cpython/pull/154341/files
gh-154275: Fix cleanup code in _Py_make_parametershttps://github.com/python/cpython/pull/154341#top
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:gh-154275https://github.com/sobolevn/cpython/tree/gh-154275
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jul 21, 2026https://github.com/python/cpython/pull/154341#issue-4937555148
Please reload this pagehttps://github.com/python/cpython/pull/154341
#154277https://github.com/python/cpython/pull/154277
_Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #154275https://github.com/python/cpython/issues/154275
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/sobolevn
pythongh-154275https://github.com/python/cpython/issues/154275
: Fix cleanup code inhttps://github.com/python/cpython/pull/154341/commits/d8ded0e59c4ce92b610c3525cab62e9352b91939
_Py_make_parametershttps://github.com/python/cpython/pull/154341/commits/d8ded0e59c4ce92b610c3525cab62e9352b91939
d8ded0ehttps://github.com/python/cpython/pull/154341/commits/d8ded0e59c4ce92b610c3525cab62e9352b91939
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 21, 2026 https://github.com/python/cpython/pull/154341#ref-issue-4930973473
_Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #154275 https://github.com/python/cpython/issues/154275
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 21, 2026https://github.com/python/cpython/pull/154341#event-28260954586
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jul 21, 2026https://github.com/python/cpython/pull/154341#event-28260962573
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jul 21, 2026https://github.com/python/cpython/pull/154341#issuecomment-5032544434
#154340https://github.com/python/cpython/pull/154340
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
July 21, 2026 10:19https://github.com/python/cpython/pull/154341#event-28262253675
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
196e16dhttps://github.com/python/cpython/commit/196e16d54f9f06f566c52e7bca3b5213a8a64223
Jul 21, 2026https://github.com/python/cpython/pull/154341#event-28262506870
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 21, 2026https://github.com/python/cpython/pull/154341#issuecomment-5032842755
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 21, 2026https://github.com/python/cpython/pull/154341#event-28262509042
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 21, 2026https://github.com/python/cpython/pull/154341#issuecomment-5032845670
GH-154342https://github.com/python/cpython/pull/154342
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jul 21, 2026https://github.com/python/cpython/pull/154341#event-28262523079
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 21, 2026https://github.com/python/cpython/pull/154341#issuecomment-5032846605
GH-154343https://github.com/python/cpython/pull/154343
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jul 21, 2026https://github.com/python/cpython/pull/154341#event-28262527279
sobolevnhttps://github.com/sobolevn
Jul 21, 2026 https://github.com/python/cpython/pull/154341#ref-commit-e1eb9e8
https://github.com/miss-islington
https://github.com/sobolevn
[3.14]https://github.com/python/cpython/commit/e1eb9e882edf65341689ca4cfca7f31c4038d03d
gh-154275https://github.com/python/cpython/issues/154275
: Fix cleanup code inhttps://github.com/python/cpython/commit/e1eb9e882edf65341689ca4cfca7f31c4038d03d
_Py_make_parametershttps://github.com/python/cpython/commit/e1eb9e882edf65341689ca4cfca7f31c4038d03d
(https://github.com/python/cpython/commit/e1eb9e882edf65341689ca4cfca7f31c4038d03d
GH-154341https://github.com/python/cpython/pull/154341
)…https://github.com/python/cpython/commit/e1eb9e882edf65341689ca4cfca7f31c4038d03d
e1eb9e8https://github.com/python/cpython/commit/e1eb9e882edf65341689ca4cfca7f31c4038d03d
#154343https://github.com/python/cpython/pull/154343
gh-154275https://github.com/python/cpython/issues/154275
GH-154341https://github.com/python/cpython/pull/154341
196e16dhttps://github.com/python/cpython/commit/196e16d54f9f06f566c52e7bca3b5213a8a64223
sobolevnhttps://github.com/sobolevn
Jul 21, 2026 https://github.com/python/cpython/pull/154341#ref-commit-b3e046c
https://github.com/miss-islington
https://github.com/sobolevn
[3.15]https://github.com/python/cpython/commit/b3e046cdb4e9ac869b77022579d47ddb848c4fda
gh-154275https://github.com/python/cpython/issues/154275
: Fix cleanup code inhttps://github.com/python/cpython/commit/b3e046cdb4e9ac869b77022579d47ddb848c4fda
_Py_make_parametershttps://github.com/python/cpython/commit/b3e046cdb4e9ac869b77022579d47ddb848c4fda
(https://github.com/python/cpython/commit/b3e046cdb4e9ac869b77022579d47ddb848c4fda
GH-154341https://github.com/python/cpython/pull/154341
)…https://github.com/python/cpython/commit/b3e046cdb4e9ac869b77022579d47ddb848c4fda
b3e046chttps://github.com/python/cpython/commit/b3e046cdb4e9ac869b77022579d47ddb848c4fda
#154342https://github.com/python/cpython/pull/154342
gh-154275https://github.com/python/cpython/issues/154275
GH-154341https://github.com/python/cpython/pull/154341
196e16dhttps://github.com/python/cpython/commit/196e16d54f9f06f566c52e7bca3b5213a8a64223
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154341
Please reload this pagehttps://github.com/python/cpython/pull/154341
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/154341
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.