René's URL Explorer Experiment


Title: gh-153772: Make abc isinstance() tolerate instances without __class__ by fedonman · Pull Request #154149 · python/cpython · GitHub

Open Graph Title: gh-153772: Make abc isinstance() tolerate instances without __class__ by fedonman · Pull Request #154149 · python/cpython

X Title: gh-153772: Make abc isinstance() tolerate instances without __class__ by fedonman · Pull Request #154149 · python/cpython

Description: The built-in isinstance() reads an instance's __class__ with a lookup that suppresses AttributeError and falls back to the object's type, so a value whose __class__ access raises still checks cleanly: >>> class NoClass: ... def __getattribute__(self, name): ... if name == "__class__": ... raise AttributeError(name) ... return super().__getattribute__(name) ... >>> isinstance(NoClass(), int) False ABCMeta.__instancecheck__ read __class__ directly instead, so the same object leaked the AttributeError when checked against a collections.abc class: >>> from collections.abc import Mapping >>> isinstance(NoClass(), Mapping) AttributeError: __class__ This makes the abstract base class machinery fall back to type(instance) when __class__ is unavailable, in both the C (Modules/_abc.c) and the pure-Python (Lib/_py_abc.py) implementations, so it matches the built-in isinstance(): >>> isinstance(NoClass(), Mapping) False Objects without a __class__ are unusual, but they do turn up in the wild (for example some Qt widgets, as noted in the issue). Issue: gh-153772

Open Graph Description: The built-in isinstance() reads an instance's __class__ with a lookup that suppresses AttributeError and falls back to the object's type, so a value whose __class__ access raises still chec...

X Description: The built-in isinstance() reads an instance's __class__ with a lookup that suppresses AttributeError and falls back to the object's type, so a value whose __class__ access raises st...

Opengraph URL: https://github.com/python/cpython/pull/154149

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:087062b9-b578-0ccd-7863-a9a8b06981da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA714:11EACE:360B076:4820D0E:6B0207A7
html-safe-nonce76128bc53adca97b546dba8fe8ca4832de8c48d58c9441e746fcb536c4c1ab04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzE0OjExRUFDRTozNjBCMDc2OjQ4MjBEMEU6NkIwMjA3QTciLCJ2aXNpdG9yX2lkIjoiNjI1MjI4NDM3OTYzNzM1MjM2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf3e2d379960ac72a2198f01961f0cd1ff1f1bca8c641225ad841332f741f541e
hovercard-subject-tagpull_request:4086150610
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/154149/files
twitter:imagehttps://avatars.githubusercontent.com/u/3442573?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3442573?s=400&v=4
og:image:altThe built-in isinstance() reads an instance's __class__ with a lookup that suppresses AttributeError and falls back to the object's type, so a value whose __class__ access raises still chec...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/154149/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154149%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154149%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/154149/files
Reloadhttps://github.com/python/cpython/pull/154149/files
Reloadhttps://github.com/python/cpython/pull/154149/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
fedonman:fix-gh-153772-abc-instancecheck-no-classhttps://github.com/fedonman/cpython/tree/fix-gh-153772-abc-instancecheck-no-class
Conversation 7 https://github.com/python/cpython/pull/154149
Commits 1 https://github.com/python/cpython/pull/154149/commits
Checks 70 https://github.com/python/cpython/pull/154149/checks
Files changed https://github.com/python/cpython/pull/154149/files
Please reload this pagehttps://github.com/python/cpython/pull/154149/files
gh-153772: Make abc isinstance() tolerate instances without __class__ https://github.com/python/cpython/pull/154149/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/154149/files
eb940c0 gh-153772: Make abc isinstance() tolerate instances without __class__ fedonman Jul 19, 2026 https://github.com/python/cpython/pull/154149/commits/eb940c016321c36f448667c12e3cc14c1a55d6b9
Clear filters https://github.com/python/cpython/pull/154149/files
Please reload this pagehttps://github.com/python/cpython/pull/154149/files
Please reload this pagehttps://github.com/python/cpython/pull/154149/files
_py_abc.py https://github.com/python/cpython/pull/154149/files#diff-3178d3e96fe6ef5531e7c1510815852772107bf2a222f4d94a1b3b85e4c13b0f
test_abc.py https://github.com/python/cpython/pull/154149/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
2026-07-19-17-05-00.gh-issue-153772.cobjTK.rst https://github.com/python/cpython/pull/154149/files#diff-299f196bedd54f050c423dc0164553cacd624cb66142999de4b7ffad04261f47
_abc.c https://github.com/python/cpython/pull/154149/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
Lib/_py_abc.pyhttps://github.com/python/cpython/pull/154149/files#diff-3178d3e96fe6ef5531e7c1510815852772107bf2a222f4d94a1b3b85e4c13b0f
View file https://github.com/fedonman/cpython/blob/eb940c016321c36f448667c12e3cc14c1a55d6b9/Lib/_py_abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154149/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154149/files#diff-3178d3e96fe6ef5531e7c1510815852772107bf2a222f4d94a1b3b85e4c13b0f
https://github.com/python/cpython/pull/154149/files#diff-3178d3e96fe6ef5531e7c1510815852772107bf2a222f4d94a1b3b85e4c13b0f
Lib/test/test_abc.pyhttps://github.com/python/cpython/pull/154149/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
View file https://github.com/fedonman/cpython/blob/eb940c016321c36f448667c12e3cc14c1a55d6b9/Lib/test/test_abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154149/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154149/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
https://github.com/python/cpython/pull/154149/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
Misc/NEWS.d/next/Library/2026-07-19-17-05-00.gh-issue-153772.cobjTK.rsthttps://github.com/python/cpython/pull/154149/files#diff-299f196bedd54f050c423dc0164553cacd624cb66142999de4b7ffad04261f47
View file https://github.com/fedonman/cpython/blob/eb940c016321c36f448667c12e3cc14c1a55d6b9/Misc/NEWS.d/next/Library/2026-07-19-17-05-00.gh-issue-153772.cobjTK.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154149/{{ revealButtonHref }}
Modules/_abc.chttps://github.com/python/cpython/pull/154149/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
View file https://github.com/fedonman/cpython/blob/eb940c016321c36f448667c12e3cc14c1a55d6b9/Modules/_abc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/154149/{{ revealButtonHref }}
https://github.com/python/cpython/pull/154149/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
https://github.com/python/cpython/pull/154149/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
Please reload this pagehttps://github.com/python/cpython/pull/154149/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.