| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:41209cad-e614-2ded-1277-545f7d7aa3bf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 934E:213839:44CE498:57B5F6F:6B022C59 |
| html-safe-nonce | 8d074789126fc294187492448011ccbdfa99149da14991aecb633fe3e3716fc6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzRFOjIxMzgzOTo0NENFNDk4OjU3QjVGNkY6NkIwMjJDNTkiLCJ2aXNpdG9yX2lkIjoiOTc3NTA5MjM0MjE1NTk4OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c646bb9943f2a6eccdb12f3b5d57d66c1b3ded54021014037e894935889003bf |
| hovercard-subject-tag | pull_request:4085585358 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/154105/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3d7a88e73cbebc92d80fa273f49569fc508cb5c83d3dc575ac7a23448ee90f8e/python/cpython/pull/154105 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d7a88e73cbebc92d80fa273f49569fc508cb5c83d3dc575ac7a23448ee90f8e/python/cpython/pull/154105 |
| og:image:alt | Closes #154090.
Issue: Sampling binary profiles do not record the profiling mode #154090 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pablogsal |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/154105#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154105 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154105 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/154105 |
| Reload | https://github.com/python/cpython/pull/154105 |
| Reload | https://github.com/python/cpython/pull/154105 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| pablogsal | https://github.com/pablogsal |
| python:main | https://github.com/python/cpython/tree/main |
| pablogsal:agent/gh-154090-binary-mode | https://github.com/pablogsal/cpython/tree/agent/gh-154090-binary-mode |
| Conversation | https://github.com/python/cpython/pull/154105 |
| Commits4 (4) | https://github.com/python/cpython/pull/154105/commits |
| Checks | https://github.com/python/cpython/pull/154105/checks |
| Files changed | https://github.com/python/cpython/pull/154105/files |
| gh-154090: Store profiling mode in binary files | https://github.com/python/cpython/pull/154105#top |
| pablogsal | https://github.com/pablogsal |
| python:main | https://github.com/python/cpython/tree/main |
| pablogsal:agent/gh-154090-binary-mode | https://github.com/pablogsal/cpython/tree/agent/gh-154090-binary-mode |
|
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Jul 19, 2026 | https://github.com/python/cpython/pull/154105#issue-4922379541 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| #154090 | https://github.com/python/cpython/issues/154090 |
| Sampling binary profiles do not record the profiling mode #154090 | https://github.com/python/cpython/issues/154090 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Jul 19, 2026
| https://github.com/python/cpython/pull/154105#ref-issue-4922276839 |
|
Sampling binary profiles do not record the profiling mode
#154090
| https://github.com/python/cpython/issues/154090 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
needs backport to 3.15
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22 |
| Jul 19, 2026 | https://github.com/python/cpython/pull/154105#event-28180649384 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| ivonastojanovic | https://github.com/ivonastojanovic |
| July 19, 2026 13:58 | https://github.com/python/cpython/pull/154105#event-28180746785 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Jul 19, 2026 | https://github.com/python/cpython/pull/154105#issuecomment-5015991583 |
| @lkollar | https://github.com/lkollar |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| July 19, 2026 14:08 | https://github.com/python/cpython/pull/154105#event-28180912823 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| AA-Turner | https://github.com/AA-Turner |
| code owner | https://github.com/python/cpython/blob/1604043caf0a00fe4ea9f6e31e389c4cf8b8baab/.github/CODEOWNERS#L100 |
| July 19, 2026 14:08 | https://github.com/python/cpython/pull/154105#event-28180912985 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jul 19, 2026 | https://github.com/python/cpython/pull/154105#event-28180913701 |
| https://github.com/maurycy |
| maurycy | https://github.com/maurycy |
|
Jul 20, 2026
| https://github.com/python/cpython/pull/154105#pullrequestreview-4733813929 |
|
View reviewed changes
| https://github.com/python/cpython/pull/154105/files |
| maurycy | https://github.com/maurycy |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/python/cpython/pull/154105#pullrequestreview-4733813929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #154092 | https://github.com/python/cpython/pull/154092 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| InternalDocs/profiling_binary_format.md | https://github.com/python/cpython/pull/154105/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30 |
| maurycy | https://github.com/maurycy |
| Jul 20, 2026 | https://github.com/python/cpython/pull/154105#discussion_r3613357017 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| InternalDocs/profiling_binary_format.md | https://github.com/python/cpython/pull/154105/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30 |
| maurycy | https://github.com/maurycy |
| Jul 20, 2026 | https://github.com/python/cpython/pull/154105#discussion_r3613359222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #153425 | https://github.com/python/cpython/pull/153425 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
|
gh-154060: Preserve replay duration and rate
#154101
| https://github.com/python/cpython/pull/154101 |
|
Add Perfetto trace output to profiling.sampling
#150327
| https://github.com/python/cpython/issues/150327 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/b931bc3ca7c8473ebaa8e29218adb5a80d5055a6..5a9fbe7dd39e145f6fb268a4370e9c1d90413c25 |
| b931bc3 | https://github.com/python/cpython/commit/b931bc3ca7c8473ebaa8e29218adb5a80d5055a6 |
| 5a9fbe7 | https://github.com/python/cpython/commit/5a9fbe7dd39e145f6fb268a4370e9c1d90413c25 |
|
Compare
| https://github.com/python/cpython/compare/b931bc3ca7c8473ebaa8e29218adb5a80d5055a6..5a9fbe7dd39e145f6fb268a4370e9c1d90413c25 |
| August 25, 2026 23:53 | https://github.com/python/cpython/pull/154105#event-30012843550 |
| pablogsal | https://github.com/pablogsal |
| September 24, 2026 20:51 | https://github.com/python/cpython/pull/154105#commits-pushed-626a08a |
|
| https://github.com/pablogsal |
| pythongh-154090 | https://github.com/python/cpython/issues/154090 |
| : Store profiling mode in binary files | https://github.com/python/cpython/pull/154105/commits/626a08ab2f6fe0fd68f0f2db5e6f8b17ecc7eca1 |
| 626a08a | https://github.com/python/cpython/pull/154105/commits/626a08ab2f6fe0fd68f0f2db5e6f8b17ecc7eca1 |
|
| https://github.com/pablogsal |
| pythongh-154090 | https://github.com/python/cpython/issues/154090 |
| : Preserve modes across replay outputs | https://github.com/python/cpython/pull/154105/commits/1097e5399f2474bc25f53821ce7c09ed0a12f10a |
| 1097e53 | https://github.com/python/cpython/pull/154105/commits/1097e5399f2474bc25f53821ce7c09ed0a12f10a |
|
| https://github.com/pablogsal |
| pythongh-154090 | https://github.com/python/cpython/issues/154090 |
| : Preserve binary capture configuration | https://github.com/python/cpython/pull/154105/commits/45cce24330f852576e76464ac880028a8b9034b1 |
| 45cce24 | https://github.com/python/cpython/pull/154105/commits/45cce24330f852576e76464ac880028a8b9034b1 |
|
| https://github.com/pablogsal |
| pythongh-154090 | https://github.com/python/cpython/issues/154090 |
| : Regenerate global identifiers | https://github.com/python/cpython/pull/154105/commits/e33d34f35a48292e24f528df172154bc8777c773 |
| e33d34f | https://github.com/python/cpython/pull/154105/commits/e33d34f35a48292e24f528df172154bc8777c773 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/b92658886c8361617456e7e21db76a2b46916b5e..e33d34f35a48292e24f528df172154bc8777c773 |
| b926588 | https://github.com/python/cpython/commit/b92658886c8361617456e7e21db76a2b46916b5e |
| e33d34f | https://github.com/python/cpython/commit/e33d34f35a48292e24f528df172154bc8777c773 |
|
Compare
| https://github.com/python/cpython/compare/b92658886c8361617456e7e21db76a2b46916b5e..e33d34f35a48292e24f528df172154bc8777c773 |
| September 24, 2026 19:54 | https://github.com/python/cpython/pull/154105#event-31786396267 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| September 24, 2026 22:56 | https://github.com/python/cpython/pull/154105#event-31796446301 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| September 24, 2026 22:56 | https://github.com/python/cpython/pull/154105#event-31796461950 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| September 24, 2026 22:56 | https://github.com/python/cpython/pull/154105#event-31796463768 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| d3663ef | https://github.com/python/cpython/commit/d3663ef943d984f4c8e349d705b61f393385d817 |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#event-31797403895 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| September 24, 2026 23:17 | https://github.com/python/cpython/pull/154105#event-31797405518 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#issuecomment-5823853429 |
| @pablogsal | https://github.com/pablogsal |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#event-31797407387 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#issuecomment-5823854184 |
| @pablogsal | https://github.com/pablogsal |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| pablogsal | https://github.com/pablogsal |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#event-31797411323 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
Sep 24, 2026
| https://github.com/python/cpython/pull/154105#ref-pullrequest-5575786557 |
|
[3.15] gh-154090: Store profiling mode and capture settings in binary profiles (GH-154105)
#158144
| https://github.com/python/cpython/pull/158144 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#issuecomment-5823867806 |
| GH-158144 | https://github.com/python/cpython/pull/158144 |
| 3.15 branch | https://github.com/python/cpython/tree/3.15 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.15
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22 |
| Sep 24, 2026 | https://github.com/python/cpython/pull/154105#event-31797461222 |
| pablogsal | https://github.com/pablogsal |
|
Sep 24, 2026
| https://github.com/python/cpython/pull/154105#ref-commit-13b1659 |
|
| https://github.com/pablogsal |
| [3.15] | https://github.com/python/cpython/commit/13b1659d6e8cb39436bf6b772725f61f33e6ec47 |
| gh-154090 | https://github.com/python/cpython/issues/154090 |
| : Store profiling mode and capture settings in binary… | https://github.com/python/cpython/commit/13b1659d6e8cb39436bf6b772725f61f33e6ec47 |
| 13b1659 | https://github.com/python/cpython/commit/13b1659d6e8cb39436bf6b772725f61f33e6ec47 |
| GH-154105 | https://github.com/python/cpython/pull/154105 |
| #158144 | https://github.com/python/cpython/pull/158144 |
| d3663ef | https://github.com/python/cpython/commit/d3663ef943d984f4c8e349d705b61f393385d817 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F154105 |
|
| https://github.com/ivonastojanovic |
|
ivonastojanovic
| https://github.com/ivonastojanovic |
|
| https://github.com/AA-Turner |
|
AA-Turner
| https://github.com/AA-Turner |
|
| https://github.com/maurycy |
|
maurycy
| https://github.com/maurycy |
|
| https://github.com/python/cpython/pull/154105/files/b931bc3ca7c8473ebaa8e29218adb5a80d5055a6 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
|
| https://github.com/pablogsal |
|
pablogsal
| https://github.com/pablogsal |
|
Sampling binary profiles do not record the profiling mode
| https://github.com/python/cpython/issues/154090 |
| Please reload this page | https://github.com/python/cpython/pull/154105 |
|
| https://github.com/pablogsal |
|
| https://github.com/maurycy |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |