René's URL Explorer Experiment


Title: gh-82102: Better handle symlinks in the zipfile module by zaphodef · Pull Request #15401 · python/cpython · GitHub

Open Graph Title: gh-82102: Better handle symlinks in the zipfile module by zaphodef · Pull Request #15401 · python/cpython

X Title: gh-82102: Better handle symlinks in the zipfile module by zaphodef · Pull Request #15401 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: https://bugs.python.org/issue37921 https://bugs.python.org/issue37921 Issue: Improve zipfile: add support for symlinks #82102

X Description: https://bugs.python.org/issue37921 https://bugs.python.org/issue37921 Issue: Improve zipfile: add support for symlinks #82102

Opengraph URL: https://github.com/python/cpython/pull/15401

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:26de773b-c449-b242-3708-38ebd4b2468b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9082:10F057:2858D2:35177D:6B0230DB
html-safe-nonce6306078f55dc22dc0132bf89d4d2f507ad80c8d03544a7b5266f1ccb6ee229e4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDgyOjEwRjA1NzoyODU4RDI6MzUxNzdEOjZCMDIzMERCIiwidmlzaXRvcl9pZCI6IjQzNDM4MjE3Nzc2OTMxOTI0MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60c3b10df2c9d60f2b4b41bca3c4841b4a8961637db55bf0dc827f8669ee6824
hovercard-subject-tagpull_request:310147921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/15401/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c96065dbc570ba9eacf47c4f8bfbb028d3a7282e088275361b2ece26fd25177/python/cpython/pull/15401
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c96065dbc570ba9eacf47c4f8bfbb028d3a7282e088275361b2ece26fd25177/python/cpython/pull/15401
og:image:althttps://bugs.python.org/issue37921 https://bugs.python.org/issue37921 Issue: Improve zipfile: add support for symlinks #82102
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezaphodef
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/15401#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15401
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15401
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15401
Reloadhttps://github.com/python/cpython/pull/15401
Reloadhttps://github.com/python/cpython/pull/15401
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
zaphodefhttps://github.com/zaphodef
python:mainhttps://github.com/python/cpython/tree/main
zaphodef:feature/zipfile_modeshttps://github.com/zaphodef/cpython/tree/feature/zipfile_modes
Conversationhttps://github.com/python/cpython/pull/15401
Commits4 (4)https://github.com/python/cpython/pull/15401/commits
Checkshttps://github.com/python/cpython/pull/15401/checks
Files changedhttps://github.com/python/cpython/pull/15401/files
gh-82102: Better handle symlinks in the zipfile modulehttps://github.com/python/cpython/pull/15401#top
zaphodefhttps://github.com/zaphodef
python:mainhttps://github.com/python/cpython/tree/main
zaphodef:feature/zipfile_modeshttps://github.com/zaphodef/cpython/tree/feature/zipfile_modes
https://github.com/zaphodef
zaphodefhttps://github.com/zaphodef
Aug 22, 2019https://github.com/python/cpython/pull/15401#issue-484221460
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://bugs.python.org/issue37921https://bugs.python.org/issue37921
https://bugs.python.org/issue37921https://bugs.python.org/issue37921
Improve zipfile: add support for symlinks #82102https://github.com/python/cpython/issues/82102
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/zaphodef
bpo-37921: Better handle symlinks in the zipfile modulehttps://github.com/python/cpython/pull/15401/commits/2f6948c780bf0b92c9af6946a72799817861ca73
2f6948chttps://github.com/python/cpython/pull/15401/commits/2f6948c780bf0b92c9af6946a72799817861ca73
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Aug 22, 2019https://github.com/python/cpython/pull/15401#event-2577883801
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Aug 22, 2019https://github.com/python/cpython/pull/15401#issuecomment-524081079
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
check yourselfhttps://check-python-cla.herokuapp.com/
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 22, 2019https://github.com/python/cpython/pull/15401#event-2577883883
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Aug 23, 2019https://github.com/python/cpython/pull/15401#event-2578939806
https://github.com/raulcd
raulcdhttps://github.com/raulcd
Aug 23, 2019https://github.com/python/cpython/pull/15401#issuecomment-524272982
@zaphodefhttps://github.com/zaphodef
python-ideashttps://mail.python.org/mailman3/lists/python-ideas.python.org/
bpohttps://bugs.python.org/issue37921
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/epicfaace
epicfaacehttps://github.com/epicfaace
Aug 23, 2019 https://github.com/python/cpython/pull/15401#pullrequestreview-279092467
View reviewed changes https://github.com/python/cpython/pull/15401/files/2f6948c780bf0b92c9af6946a72799817861ca73
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/15401/files/2f6948c780bf0b92c9af6946a72799817861ca73#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Please reload this pagehttps://github.com/python/cpython/pull/15401
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/15401/files/2f6948c780bf0b92c9af6946a72799817861ca73#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Please reload this pagehttps://github.com/python/cpython/pull/15401
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/15401/files/2f6948c780bf0b92c9af6946a72799817861ca73#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Please reload this pagehttps://github.com/python/cpython/pull/15401
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/15401/files/2f6948c780bf0b92c9af6946a72799817861ca73#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/zaphodef
fix documentation issuehttps://github.com/python/cpython/pull/15401/commits/c5c5d40a94f487c81d23b74a92308960b7686cae
c5c5d40https://github.com/python/cpython/pull/15401/commits/c5c5d40a94f487c81d23b74a92308960b7686cae
https://github.com/epicfaace
epicfaacehttps://github.com/epicfaace
Aug 23, 2019 https://github.com/python/cpython/pull/15401#pullrequestreview-279119350
View reviewed changes https://github.com/python/cpython/pull/15401/files/c5c5d40a94f487c81d23b74a92308960b7686cae
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/15401/files/2f6948c780bf0b92c9af6946a72799817861ca73#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Please reload this pagehttps://github.com/python/cpython/pull/15401
Lib/test/test_zipfile.pyhttps://github.com/python/cpython/pull/15401/files/c5c5d40a94f487c81d23b74a92308960b7686cae#diff-88215aededc3f81c55ba2432fe67617be9fc3faff9cb10e0c01f710adfcba426
Please reload this pagehttps://github.com/python/cpython/pull/15401
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/15401/files/c5c5d40a94f487c81d23b74a92308960b7686cae#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/zaphodef
Remove is_reg() and add checks for filemode and follow_symlinkshttps://github.com/python/cpython/pull/15401/commits/ca5e302203f7a465529ffe073a40be0a82335619
ca5e302https://github.com/python/cpython/pull/15401/commits/ca5e302203f7a465529ffe073a40be0a82335619
https://github.com/zaphodef
zaphodefhttps://github.com/zaphodef
Aug 26, 2019 https://github.com/python/cpython/pull/15401#pullrequestreview-279439981
View reviewed changes https://github.com/python/cpython/pull/15401/files/ca5e302203f7a465529ffe073a40be0a82335619
zaphodefhttps://github.com/zaphodef
https://github.com/python/cpython/pull/15401#pullrequestreview-279439981
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
ca5e302https://github.com/python/cpython/commit/ca5e302203f7a465529ffe073a40be0a82335619
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/zaphodef
add an entry in Misc/NEWS.dhttps://github.com/python/cpython/pull/15401/commits/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f
2e19dfehttps://github.com/python/cpython/pull/15401/commits/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f
https://github.com/epicfaace
epicfaacehttps://github.com/epicfaace
Aug 26, 2019 https://github.com/python/cpython/pull/15401#pullrequestreview-279670347
View reviewed changes https://github.com/python/cpython/pull/15401/files/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 26, 2019https://github.com/python/cpython/pull/15401#event-2584102055
https://github.com/clopez
clopezhttps://github.com/clopez
Apr 22, 2022 https://github.com/python/cpython/pull/15401#ref-pullrequest-544411557
bpo-15795: Preserve permissions on UNIX (based/like) systems #17790 https://github.com/python/cpython/pull/17790
https://github.com/python/cpython/pull/15401
zaphodefhttps://github.com/python/cpython/pull/15401
Apr 10, 2022 https://github.com/python/cpython/pull/15401#ref-issue-1199018233
Improve zipfile: add support for symlinks #82102 https://github.com/python/cpython/issues/82102
https://github.com/ezio-melotti
ezio-melottihttps://github.com/ezio-melotti
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 13, 2022https://github.com/python/cpython/pull/15401#event-6988864539
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 7, 2026https://github.com/python/cpython/pull/15401#issuecomment-4196989166
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Apr 7, 2026https://github.com/python/cpython/pull/15401#event-24246445751
https://github.com/sharkwouter
sharkwouterhttps://github.com/sharkwouter
Apr 7, 2026https://github.com/python/cpython/pull/15401#issuecomment-4197234749
Please reload this pagehttps://github.com/python/cpython/pull/15401
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
May 10, 2026https://github.com/python/cpython/pull/15401#event-25346620796
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 11, 2026https://github.com/python/cpython/pull/15401#issuecomment-5249689064
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Aug 11, 2026https://github.com/python/cpython/pull/15401#event-29262927427
https://github.com/sharkwouter
sharkwouterhttps://github.com/sharkwouter
Aug 11, 2026 https://github.com/python/cpython/pull/15401#pullrequestreview-4903979194
View reviewed changes https://github.com/python/cpython/pull/15401/files/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f
Lib/zipfile.pyhttps://github.com/python/cpython/pull/15401/files/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851
sharkwouterhttps://github.com/sharkwouter
Aug 11, 2026https://github.com/python/cpython/pull/15401#discussion_r3756101347
Please reload this pagehttps://github.com/python/cpython/pull/15401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/sharkwouter
sharkwouterhttps://github.com/sharkwouter
Aug 11, 2026https://github.com/python/cpython/pull/15401#issuecomment-5250405330
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 12, 2026https://github.com/python/cpython/pull/15401#event-29325613296
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Aug 14, 2026https://github.com/python/cpython/pull/15401#event-29431496355
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 12, 2026https://github.com/python/cpython/pull/15401#issuecomment-6816112676
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Nov 12, 2026https://github.com/python/cpython/pull/15401#event-35879469452
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15401
https://github.com/sharkwouter
sharkwouter https://github.com/sharkwouter
https://github.com/python/cpython/pull/15401/files/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f
https://github.com/epicfaace
epicfaace https://github.com/epicfaace
https://github.com/python/cpython/pull/15401/files/2e19dfeec1e28667c8fd2bf8132e25bc2fc0df9f
Please reload this pagehttps://github.com/python/cpython/pull/15401
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Please reload this pagehttps://github.com/python/cpython/pull/15401
https://github.com/zaphodef
https://github.com/the-knights-who-say-ni
https://github.com/raulcd
https://github.com/sharkwouter
https://github.com/epicfaace
https://github.com/ezio-melotti
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.