René's URL Explorer Experiment


Title: gh-153568: Stop re-walking memo lists when growing left-recursive rules by pablogsal · Pull Request #153574 · python/cpython · GitHub

Open Graph Title: gh-153568: Stop re-walking memo lists when growing left-recursive rules by pablogsal · Pull Request #153574 · python/cpython

X Title: gh-153568: Stop re-walking memo lists when growing left-recursive rules by pablogsal · Pull Request #153574 · python/cpython

Description: The grow-the-seed loop of every left-recursive rule searched the token's memo list on each iteration to update its own entry, even though it inserted that entry itself on the first pass. Keeping a direct reference and writing through it removes the repeated walks. Benchmark (parsing 8 of the largest stdlib files, 1.3 MB, 20 times per run with _PyParser_ASTFromString — parser only, no AST-to-Python conversion; pyperf, interleaved runs): build time per run speedup main 1.74 s ± 0.03 this PR 1.73 s ± 0.03 within noise** (read below) On its own the effect is below measurement noise; combined with the memo filter of #153571 it measured about 3% because the remaining walks there are the long ones this change removes.

Open Graph Description: The grow-the-seed loop of every left-recursive rule searched the token's memo list on each iteration to update its own entry, even though it inserted that entry itself on the first pass. Keepin...

X Description: The grow-the-seed loop of every left-recursive rule searched the token's memo list on each iteration to update its own entry, even though it inserted that entry itself on the first pass. Ke...

Opengraph URL: https://github.com/python/cpython/pull/153574

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7d786885-7770-1d1d-bb04-f23866972c26
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8450:62F48:12D06E6:18C6A6B:6B021E79
html-safe-nonce9f260b5f1f871946f7965098b4a1e482dd6389d56cce4ef94ddd95c7a728bf4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDUwOjYyRjQ4OjEyRDA2RTY6MThDNkE2Qjo2QjAyMUU3OSIsInZpc2l0b3JfaWQiOiIzMzA2NzYwOTE1NzI2MjQ1NDk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc0852250d44913ef783917acc95392827ba8d13952bb4d7f715841cb6b831d14
hovercard-subject-tagpull_request:4035629909
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/153574/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altThe grow-the-seed loop of every left-recursive rule searched the token's memo list on each iteration to update its own entry, even though it inserted that entry itself on the first pass. Keepin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/153574/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153574%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153574%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/153574/files
Reloadhttps://github.com/python/cpython/pull/153574/files
Reloadhttps://github.com/python/cpython/pull/153574/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:gh-153568-leftrec-memohttps://github.com/pablogsal/cpython/tree/gh-153568-leftrec-memo
Conversation 0 https://github.com/python/cpython/pull/153574
Commits 1 https://github.com/python/cpython/pull/153574/commits
Checks 63 https://github.com/python/cpython/pull/153574/checks
Files changed https://github.com/python/cpython/pull/153574/files
Please reload this pagehttps://github.com/python/cpython/pull/153574/files
gh-153568: Stop re-walking memo lists when growing left-recursive rules https://github.com/python/cpython/pull/153574/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/153574/files
678e3a3 gh-153568: Stop re-walking memo lists when growing left-recursive rules pablogsal Jul 11, 2026 https://github.com/python/cpython/pull/153574/commits/678e3a39a1ddab6e817f485a6663cd23114695b8
Clear filters https://github.com/python/cpython/pull/153574/files
Please reload this pagehttps://github.com/python/cpython/pull/153574/files
Please reload this pagehttps://github.com/python/cpython/pull/153574/files
2026-07-11-14-59-17.gh-issue-153568.leftrec.rst https://github.com/python/cpython/pull/153574/files#diff-666202b1984e469eb58179cd49f8c48297dfed458547381e3409f6540f02b5bc
parser.c https://github.com/python/cpython/pull/153574/files#diff-6d39440cedc67d1ce7a0586bfb6ecb8483803448a9c93f3fae3ad0e2260e29f7
pegen.c https://github.com/python/cpython/pull/153574/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7
pegen.h https://github.com/python/cpython/pull/153574/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
c_generator.py https://github.com/python/cpython/pull/153574/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
Misc/NEWS.d/next/Core_and_Builtins/2026-07-11-14-59-17.gh-issue-153568.leftrec.rsthttps://github.com/python/cpython/pull/153574/files#diff-666202b1984e469eb58179cd49f8c48297dfed458547381e3409f6540f02b5bc
View file https://github.com/pablogsal/cpython/blob/678e3a39a1ddab6e817f485a6663cd23114695b8/Misc/NEWS.d/next/Core_and_Builtins/2026-07-11-14-59-17.gh-issue-153568.leftrec.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153574/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/parser.chttps://github.com/python/cpython/pull/153574/files#diff-6d39440cedc67d1ce7a0586bfb6ecb8483803448a9c93f3fae3ad0e2260e29f7
View file https://github.com/pablogsal/cpython/blob/678e3a39a1ddab6e817f485a6663cd23114695b8/Parser/parser.c
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/153574/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/pegen.chttps://github.com/python/cpython/pull/153574/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7
View file https://github.com/pablogsal/cpython/blob/678e3a39a1ddab6e817f485a6663cd23114695b8/Parser/pegen.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153574/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153574/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7
https://github.com/python/cpython/pull/153574/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/pegen.hhttps://github.com/python/cpython/pull/153574/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
View file https://github.com/pablogsal/cpython/blob/678e3a39a1ddab6e817f485a6663cd23114695b8/Parser/pegen.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153574/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153574/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
https://github.com/python/cpython/pull/153574/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L314
Tools/peg_generator/pegen/c_generator.pyhttps://github.com/python/cpython/pull/153574/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
View file https://github.com/pablogsal/cpython/blob/678e3a39a1ddab6e817f485a6663cd23114695b8/Tools/peg_generator/pegen/c_generator.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153574/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153574/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
https://github.com/python/cpython/pull/153574/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
Please reload this pagehttps://github.com/python/cpython/pull/153574/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.