René's URL Explorer Experiment


Title: gh-153568: Make the parser's per-rule stack check an inline comparison by pablogsal · Pull Request #153573 · python/cpython · GitHub

Open Graph Title: gh-153568: Make the parser's per-rule stack check an inline comparison by pablogsal · Pull Request #153573 · python/cpython

X Title: gh-153568: Make the parser's per-rule stack check an inline comparison by pablogsal · Pull Request #153573 · python/cpython

Description: Every rule entry paid a thread-state fetch plus an out-of-line call just to ask whether the C stack is about to overflow. Caching the thread state and soft stack limit in the parser turns that into one inline pointer comparison, and the overflow guard still fires exactly as before. Benchmark (parsing 8 of the largest stdlib files, 1.3 MB, 20 times per run with _PyParser_ASTFromString — parser only, no AST-to-Python conversion; pyperf, interleaved runs): build time per run speedup main 1.86 s this PR 1.65 s 1.13x faster Issue: gh-153568

Open Graph Description: Every rule entry paid a thread-state fetch plus an out-of-line call just to ask whether the C stack is about to overflow. Caching the thread state and soft stack limit in the parser turns that into...

X Description: Every rule entry paid a thread-state fetch plus an out-of-line call just to ask whether the C stack is about to overflow. Caching the thread state and soft stack limit in the parser turns that into...

Opengraph URL: https://github.com/python/cpython/pull/153573

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:212e8154-39f9-dbd7-ba28-a679abe6429b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84FC:215B92:3813D50:4AABF8C:6B0215FA
html-safe-nonce5c25ce8cf250e4c2036bc7ff32303435a9bdc171e44d8981a923316b1c27e7ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEZDOjIxNUI5MjozODEzRDUwOjRBQUJGOEM6NkIwMjE1RkEiLCJ2aXNpdG9yX2lkIjoiMjQwMzA3Mzk5MjQ4NDMyODk1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6a07cf105a57ca32eb7624d29303b2b84fff960d6a042343624acae35ca82c24
hovercard-subject-tagpull_request:4035627076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/153573/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altEvery rule entry paid a thread-state fetch plus an out-of-line call just to ask whether the C stack is about to overflow. Caching the thread state and soft stack limit in the parser turns that into...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/153573/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153573%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153573%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/153573/files
Reloadhttps://github.com/python/cpython/pull/153573/files
Reloadhttps://github.com/python/cpython/pull/153573/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:gh-153568-stack-checkhttps://github.com/pablogsal/cpython/tree/gh-153568-stack-check
Conversation 6 https://github.com/python/cpython/pull/153573
Commits 3 https://github.com/python/cpython/pull/153573/commits
Checks 61 https://github.com/python/cpython/pull/153573/checks
Files changed https://github.com/python/cpython/pull/153573/files
Please reload this pagehttps://github.com/python/cpython/pull/153573/files
gh-153568: Make the parser's per-rule stack check an inline comparison https://github.com/python/cpython/pull/153573/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/153573/files
e0b6d7d gh-153568: Make the parser's per-rule stack check an inline comparison pablogsal Jul 11, 2026 https://github.com/python/cpython/pull/153573/commits/e0b6d7d140ddcc05f80231a571b08c99c88482a2
b78ead8 fixup! gh-153568: Make the parser's per-rule stack check an inline co… pablogsal Jul 18, 2026 https://github.com/python/cpython/pull/153573/commits/b78ead8b0db7642205d582a39fd32160d7b4a9e5
fad63c3 fixup! gh-153568: Make the parser's per-rule stack check an inline co… pablogsal Sep 14, 2026 https://github.com/python/cpython/pull/153573/commits/fad63c348046b019619c256eec17fb39bcb55f4e
Clear filters https://github.com/python/cpython/pull/153573/files
Please reload this pagehttps://github.com/python/cpython/pull/153573/files
Please reload this pagehttps://github.com/python/cpython/pull/153573/files
2026-07-11-14-58-24.gh-issue-153568.stackchk.rst https://github.com/python/cpython/pull/153573/files#diff-b1fbad7690dbcc6c7962f5e2ceedb997220a49e3e6f2e42015c938074542f322
parser.c https://github.com/python/cpython/pull/153573/files#diff-6d39440cedc67d1ce7a0586bfb6ecb8483803448a9c93f3fae3ad0e2260e29f7
pegen.c https://github.com/python/cpython/pull/153573/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7
pegen.h https://github.com/python/cpython/pull/153573/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
c_generator.py https://github.com/python/cpython/pull/153573/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
.../NEWS.d/next/Core_and_Builtins/2026-07-11-14-58-24.gh-issue-153568.stackchk.rsthttps://github.com/python/cpython/pull/153573/files#diff-b1fbad7690dbcc6c7962f5e2ceedb997220a49e3e6f2e42015c938074542f322
View file https://github.com/pablogsal/cpython/blob/fad63c348046b019619c256eec17fb39bcb55f4e/Misc/NEWS.d/next/Core_and_Builtins/2026-07-11-14-58-24.gh-issue-153568.stackchk.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153573/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/153573/files
Please reload this pagehttps://github.com/python/cpython/pull/153573/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.