Title: gh-126877: Fix the configure check for Tcl/Tk with optimizing compilers by serhiy-storchaka · Pull Request #153543 · python/cpython · GitHub
Open Graph Title: gh-126877: Fix the configure check for Tcl/Tk with optimizing compilers by serhiy-storchaka · Pull Request #153543 · python/cpython
X Title: gh-126877: Fix the configure check for Tcl/Tk with optimizing compilers by serhiy-storchaka · Pull Request #153543 · python/cpython
Description: The configure check for Tcl/Tk assigned the addresses of Tcl_Init() and Tk_Init() to unused variables. Optimizing compilers can eliminate these dead stores, dropping the only reference to the symbols, so the check links — and Tcl/Tk is detected as available — even when the libraries are missing. This calls the functions instead, matching the existing __register_frame() probe in the same file. A call to an external function cannot be optimized away, and the check still only links and never runs, so it stays cross-compile safe. Verified with gcc at -O2: the old probe links with the symbols absent, the new one correctly fails, and configure then reports _tkinter... missing instead of a false positive. Issue: gh-126877
Open Graph Description: The configure check for Tcl/Tk assigned the addresses of Tcl_Init() and Tk_Init() to unused variables. Optimizing compilers can eliminate these dead stores, dropping the only reference to the symbo...
X Description: The configure check for Tcl/Tk assigned the addresses of Tcl_Init() and Tk_Init() to unused variables. Optimizing compilers can eliminate these dead stores, dropping the only reference to the symbo...
Opengraph URL: https://github.com/python/cpython/pull/153543
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f134ef20-5e02-c305-d4a8-605c7834d7df |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CAC2:20D7FA:FA750C:14F88E1:6A544052 |
| html-safe-nonce | 227e193bf6ad726081c5b052a044f3e8fa5f75c2d3ab77d65c052fb54932cf4e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUMyOjIwRDdGQTpGQTc1MEM6MTRGODhFMTo2QTU0NDA1MiIsInZpc2l0b3JfaWQiOiI0NDUyOTc4NzE1MTA3MDE2Nzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e21519ad12ac12ff9478b0e801fe8e100b52d55784e4da87aab4719f47f3d92f |
| hovercard-subject-tag | pull_request:4034508951 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/153543/files |
| twitter:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| og:image:alt | The configure check for Tcl/Tk assigned the addresses of Tcl_Init() and Tk_Init() to unused variables. Optimizing compilers can eliminate these dead stores, dropping the only reference to the symbo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width