Title: [3.13] gh-128846: Make tkinter tests robust against Tcl/Tk 9.0 by serhiy-storchaka · Pull Request #153484 · python/cpython · GitHub
Open Graph Title: [3.13] gh-128846: Make tkinter tests robust against Tcl/Tk 9.0 by serhiy-storchaka · Pull Request #153484 · python/cpython
X Title: [3.13] gh-128846: Make tkinter tests robust against Tcl/Tk 9.0 by serhiy-storchaka · Pull Request #153484 · python/cpython
Description: Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so that test_tkinter and test_ttk pass when Python 3.13 is built against Tcl/Tk 9.0 or 9.1 (for example the Homebrew build used on macOS — see gh-128846), while still passing against the Tcl/Tk 8.6 that 3.13 ships. These adaptations were made during 3.14/3.15 development and never backported to 3.13, so building 3.13 against Tk 9.0 currently produces ~90 spurious test_tkinter failures and several test_ttk failures (error-message wording such as doesn't→does not and can't→cannot find busy window, pixel rounding/scaling, clipped negative sizes, identify() returning padding instead of focus, etc.). This combines the test changes from: gh-124111: Update tkinter for compatibility with Tcl/Tk 9.0.0 (GH-124156) gh-124111: test macOS CI with Tk 9 (GH-137424) gh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (GH-145738) The corresponding non-test changes (Modules/_tkinter.c, Lib/tkinter/ttk.py, PCbuild and CI configuration) are not backported. The \z regular-expression escape introduced by gh-133306 is not available in the 3.13 re module, so \Z is kept. The NotebookTest.test_traversal hardening is handled separately by GH-153415 (already merged) and is not part of this PR. Verified locally against Tcl/Tk 8.6, 9.0.4 and 9.1b1 (the affected test_tkinter and test_ttk methods pass on all three); the set of collected test cases is unchanged, so no test coverage is dropped.
Open Graph Description: Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so that test_tkinter and test_ttk pass when Python 3.13 is built against Tcl/Tk 9.0 or 9.1 (for example the Homebrew build us...
X Description: Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so that test_tkinter and test_ttk pass when Python 3.13 is built against Tcl/Tk 9.0 or 9.1 (for example the Homebrew build us...
Opengraph URL: https://github.com/python/cpython/pull/153484
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ce2d7f76-7578-60cf-9fa9-ee23c9bbdc9e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9BE:1F7B4A:6F904:97EC8:6A535EC0 |
| html-safe-nonce | 94d67534603c22630a3a01a2dde97685cd7a3830c6aeea2702e0c75d058c66f2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUJFOjFGN0I0QTo2RjkwNDo5N0VDODo2QTUzNUVDMCIsInZpc2l0b3JfaWQiOiI3MDc2MDAxOTY2NzUzNzk5ODcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d3c7f1059069509eb14318ca8fc1d14635802e9a7b1ea63f65e25cc33e2b1098 |
| hovercard-subject-tag | pull_request:4027188317 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/153484/files |
| twitter:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| og:image:alt | Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so that test_tkinter and test_ttk pass when Python 3.13 is built against Tcl/Tk 9.0 or 9.1 (for example the Homebrew build us... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width