Title: gh-69134: Harden NotebookTest.test_traversal by serhiy-storchaka · Pull Request #153403 · python/cpython · GitHub
Open Graph Title: gh-69134: Harden NotebookTest.test_traversal by serhiy-storchaka · Pull Request #153403 · python/cpython
X Title: gh-69134: Harden NotebookTest.test_traversal by serhiy-storchaka · Pull Request #153403 · python/cpython
Description: Follow-up to GH-152499. NotebookTest.test_traversal wasn't covered there and still fails intermittently on a real X11 display: identify(5, 5) runs before the notebook reaches its requested size, so the pixel lands outside the first tab and returns '' instead of 'padding'. wait_until_mapped() gains an opt-in full_size flag that also waits until the realized size reaches the requested size; both identify(5, 5) assertions now use it. The default path is unchanged, so the other callers are unaffected. The flake doesn't reproduce when test_traversal runs alone (0/40), but running the whole NotebookTest class reliably reproduces it, since the earlier methods leave the shared class root in a state where the notebook maps too small. Measured on a real X11 display: 14/15 failures without the fix, 0/20 with it (and no other assertion starts failing). Issue: gh-69134
Open Graph Description: Follow-up to GH-152499. NotebookTest.test_traversal wasn't covered there and still fails intermittently on a real X11 display: identify(5, 5) runs before the notebook reaches its requested size...
X Description: Follow-up to GH-152499. NotebookTest.test_traversal wasn't covered there and still fails intermittently on a real X11 display: identify(5, 5) runs before the notebook reaches its requested ...
Opengraph URL: https://github.com/python/cpython/pull/153403
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a62814a0-b2aa-a691-9833-5e62162f5455 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A1C6:B0958:26081FF:3256E11:6A520864 |
| html-safe-nonce | ac25d35b558d75d5b133e355bea4bbcd2448f06fb2fbfff487f4a7c9c7387250 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUM2OkIwOTU4OjI2MDgxRkY6MzI1NkUxMTo2QTUyMDg2NCIsInZpc2l0b3JfaWQiOiIxODY3MDg2MzQwNDk3MjEzNTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6b3505458d21e19e990a61a525b9b94942c678f6090e5ff6c068703b7fd4bee2 |
| hovercard-subject-tag | pull_request:4020816653 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/153403/files |
| twitter:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| og:image:alt | Follow-up to GH-152499. NotebookTest.test_traversal wasn't covered there and still fails intermittently on a real X11 display: identify(5, 5) runs before the notebook reaches its requested size... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width