Title: gh-150191: temporarily skip two openssl tests which have internal data races under TSAN by kumaraditya303 · Pull Request #153320 · python/cpython · GitHub
Open Graph Title: gh-150191: temporarily skip two openssl tests which have internal data races under TSAN by kumaraditya303 · Pull Request #153320 · python/cpython
X Title: gh-150191: temporarily skip two openssl tests which have internal data races under TSAN by kumaraditya303 · Pull Request #153320 · python/cpython
Description: See #150191 ContextTests.test_sni_callback_race — 2 reports Default build — setter write vs final_server_name read: WARNING: ThreadSanitizer: data race (pid=36258) Write of size 8 at 0x726c00056c30 by thread T15: # toggler thread #0 ssl3_ctx_callback_ctrl ssl/s3_lib.c:4200 # ctx->ext.servername_cb = fp #1 SSL_CTX_callback_ctrl ssl/ssl_lib.c:3251 #2 _ssl__SSLContext_sni_callback_set_impl Modules/_ssl.c:5319 #4 getset_set → PyObject_SetAttr # server_ctx.sni_callback = ... Previous read of size 8 at 0x726c00056c30 by thread T12: # handshake worker #0 final_server_name ssl/statem/extensions.c:1004 # reads servername_cb #1 tls_parse_all_extensions ssl/statem/extensions.c:816 #2 tls_early_post_process_client_hello ssl/statem/statem_srvr.c:1965 #7 ossl_statem_accept → #8 SSL_do_handshake #9 _ssl__SSLSocket_do_handshake_impl Modules/_ssl.c:1099 # server.do_handshake() Location: heap block of size 1768 (SSL_CTX, allocated in SSL_CTX_new from _ssl__SSLContext_impl, Modules/_ssl.c:3509) Free-threading build — same write, different read site: WARNING: ThreadSanitizer: data race (pid=36449) Read of size 8 at 0x726c00002c30 by thread T12: # handshake worker #0 is_tls13_capable ssl/statem/statem_lib.c:1932 # if (sctx->ext.servername_cb != NULL || s->session_ctx->ext.servername_cb != NULL) #1 ssl_version_supported ssl/statem/statem_lib.c:2011 #2 ssl_choose_server_version ssl/statem/statem_lib.c:2240 #9 SSL_do_handshake → _ssl__SSLSocket_do_handshake_impl Modules/_ssl.c:1099 Previous write of size 8 by thread T15: # toggler thread #0 ssl3_ctx_callback_ctrl ssl/s3_lib.c:4200 #2 _ssl__SSLContext_sni_callback_set_impl Modules/_ssl.c:5319 SUMMARY: data race statem_lib.c:1932 in is_tls13_capable ThreadedTests.test_thread_recv_while_main_thread_sends — 3 reports s->rwstate (both builds, identical stacks): WARNING: ThreadSanitizer: data race Write of size 4 by main thread: # sock.sendall(data) #0 ssl3_write_bytes ssl/record/rec_layer_s3.c:285 # s->rwstate = SSL_NOTHING #3 SSL_write_ex2 → #4 SSL_write_ex #5 _ssl__SSLSocket_write_impl Modules/_ssl.c:2832 Previous write of size 4 by thread T272: # background sock.recv() #0 ssl3_read_bytes ssl/record/rec_layer_s3.c:681 # s->rwstate = SSL_NOTHING #4 SSL_read_ex #5 _ssl__SSLSocket_read_impl Modules/_ssl.c:2989 Location: heap block of size 5560 (the SSL object, allocated in SSL_new from newPySSLSocket, Modules/_ssl.c:959, via context.wrap_socket) SUMMARY: data race rec_layer_s3.c:285 in ssl3_write_bytes Socket BIO flags (free-threading build only): WARNING: ThreadSanitizer: data race (pid=36449) Write of size 4 at 0x72200001d530 by thread T507: # background sock.recv() #0 BIO_clear_flags crypto/bio/bio_lib.c:201 # bio->flags &= ~... #1 sock_read crypto/bio/bss_sock.c:128 #4 BIO_read → tls_default_read_n → tls_get_more_records → tls_read_record #8 ssl3_read_bytes ssl/record/rec_layer_s3.c:696 #12 SSL_read_ex → _ssl__SSLSocket_read_impl Modules/_ssl.c:2989 Previous write of size 4 by main thread: # sock.sendall(data) #0 BIO_clear_flags crypto/bio/bio_lib.c:201 #1 sock_write crypto/bio/bss_sock.c:168 #5 tls_retry_write_records → SSL_write_ex → _ssl__SSLSocket_write_impl Location: heap block of size 128 (the socket BIO, allocated via SSL_set_fd, ssl/ssl_lib.c:1728, from newPySSLSocket) Issue: gh-150191
Open Graph Description: See #150191 ContextTests.test_sni_callback_race — 2 reports Default build — setter write vs final_server_name read: WARNING: ThreadSanitizer: data race (pid=36258) Write of size 8 at 0x726c00056c...
X Description: See #150191 ContextTests.test_sni_callback_race — 2 reports Default build — setter write vs final_server_name read: WARNING: ThreadSanitizer: data race (pid=36258) Write of size 8 at 0x726c00056c...
Opengraph URL: https://github.com/python/cpython/pull/153320
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:869cdf8a-60aa-1fe1-597d-5527faa9c009 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 824A:2C9FC7:11AAC6:16A15D:6A52ECFD |
| html-safe-nonce | 3b4c6e9e89cd4c3e41323ca10c89d8d3db7ba577f6516ba5eab164a0259a1625 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjRBOjJDOUZDNzoxMUFBQzY6MTZBMTVEOjZBNTJFQ0ZEIiwidmlzaXRvcl9pZCI6IjExNzk5Mjg5MjY0Njc4NDUzNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a0bd4a89542fb4c351384dde952e4045e032fe675048f38ebf8c95f183ebd353 |
| hovercard-subject-tag | pull_request:4013944061 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/153320/files |
| twitter:image | https://avatars.githubusercontent.com/u/59607654?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/59607654?s=400&v=4 |
| og:image:alt | See #150191 ContextTests.test_sni_callback_race — 2 reports Default build — setter write vs final_server_name read: WARNING: ThreadSanitizer: data race (pid=36258) Write of size 8 at 0x726c00056c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width