René's URL Explorer Experiment


Title: bpo-32689: Updates shutil.move to allow for Path objects to be used as source arg by maxwellmckinnon · Pull Request #15326 · python/cpython · GitHub

Open Graph Title: bpo-32689: Updates shutil.move to allow for Path objects to be used as source arg by maxwellmckinnon · Pull Request #15326 · python/cpython

X Title: bpo-32689: Updates shutil.move to allow for Path objects to be used as source arg by maxwellmckinnon · Pull Request #15326 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Important work originally done by @emilyemorehouse two years ago and nearly ready to go in. This bug has affected many people and in some cases has been a dealbreaker to the adoption of the otherwi...

X Description: Important work originally done by @emilyemorehouse two years ago and nearly ready to go in. This bug has affected many people and in some cases has been a dealbreaker to the adoption of the otherwi...

Opengraph URL: https://github.com/python/cpython/pull/15326

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:40d86c0e-5db2-0f14-051f-5dd98dc50208
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECF2:30C16C:76AEF5:9F88B1:6B00B156
html-safe-nonce899ab61247a02715f543ef0775f5f5cce9910e7eeccb87eb7ae076b75ca93a13
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0YyOjMwQzE2Qzo3NkFFRjU6OUY4OEIxOjZCMDBCMTU2IiwidmlzaXRvcl9pZCI6IjQyNDk0Mjk0MTc0MTMwOTU3NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacea75a40718a9c41d270024d431d4da8dc1416307167299f1bb598e4a8270a7ed
hovercard-subject-tagpull_request:308363292
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15326/commits
twitter:imagehttps://opengraph.githubassets.com/99ec5131a443ebfaf5b0e98d0dbc23ee0cd8001545f96f995d98ccc857d37e24/python/cpython/pull/15326
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99ec5131a443ebfaf5b0e98d0dbc23ee0cd8001545f96f995d98ccc857d37e24/python/cpython/pull/15326
og:image:altImportant work originally done by @emilyemorehouse two years ago and nearly ready to go in. This bug has affected many people and in some cases has been a dealbreaker to the adoption of the otherwi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaxwellmckinnon
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/15326/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15326%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15326%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15326/commits
Reloadhttps://github.com/python/cpython/pull/15326/commits
Reloadhttps://github.com/python/cpython/pull/15326/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
maxwellmckinnon:fix-issue-32689https://github.com/maxwellmckinnon/cpython/tree/fix-issue-32689
Conversationhttps://github.com/python/cpython/pull/15326
Commits16 (16)https://github.com/python/cpython/pull/15326/commits
Checkshttps://github.com/python/cpython/pull/15326/checks
Files changedhttps://github.com/python/cpython/pull/15326/files
bpo-32689: Updates shutil.move to allow for Path objects to be used as source arghttps://github.com/python/cpython/pull/15326/commits#top
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
maxwellmckinnon:fix-issue-32689https://github.com/maxwellmckinnon/cpython/tree/fix-issue-32689
bpo-32689: Updates shutil.move function to allow for Path objects to be used as source argument by casting to string before performing rstrip. Added documentation on why rstrip needs to be used in …https://github.com/python/cpython/pull/15326/commits/cc5645d899e34936e5c67ddbef90ee56d3065ae3
https://github.com/emilyemorehouse
emilyemorehousehttps://github.com/python/cpython/commits?author=emilyemorehouse
cc5645dhttps://github.com/python/cpython/pull/15326/commits/cc5645d899e34936e5c67ddbef90ee56d3065ae3
https://github.com/python/cpython/tree/cc5645d899e34936e5c67ddbef90ee56d3065ae3
Adding news entryhttps://github.com/python/cpython/pull/15326/commits/61f1019d963343308f112751f6b96d0ad233c3fd
https://github.com/emilyemorehouse
emilyemorehousehttps://github.com/python/cpython/commits?author=emilyemorehouse
61f1019https://github.com/python/cpython/pull/15326/commits/61f1019d963343308f112751f6b96d0ad233c3fd
https://github.com/python/cpython/tree/61f1019d963343308f112751f6b96d0ad233c3fd
Add test to show breakage for shutil.move where destination is a directory in the form of os.PathLike (pathlib.Path(dir)).https://github.com/python/cpython/pull/15326/commits/3f016ab1a04d78754b4b35cc686080aef252d2bc
3f016abhttps://github.com/python/cpython/pull/15326/commits/3f016ab1a04d78754b4b35cc686080aef252d2bc
https://github.com/python/cpython/tree/3f016ab1a04d78754b4b35cc686080aef252d2bc
Taking a guess at what the whitespace issue was.https://github.com/python/cpython/pull/15326/commits/a66757ba4bbcd15c8219cd7af824097177b19619
a66757bhttps://github.com/python/cpython/pull/15326/commits/a66757ba4bbcd15c8219cd7af824097177b19619
https://github.com/python/cpython/tree/a66757ba4bbcd15c8219cd7af824097177b19619
The results of running reindent.check on the file. Hope this fixes the whitespace gating issue.https://github.com/python/cpython/pull/15326/commits/b0716891b685da683aa084bc6b58b69431efd516
b071689https://github.com/python/cpython/pull/15326/commits/b0716891b685da683aa084bc6b58b69431efd516
https://github.com/python/cpython/tree/b0716891b685da683aa084bc6b58b69431efd516
remove whitespacehttps://github.com/python/cpython/pull/15326/commits/0c935fc6d88a93bdc56c8bdcb85a61f4c4f92ad9
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
brandtbucherhttps://github.com/python/cpython/commits?author=brandtbucher
0c935fchttps://github.com/python/cpython/pull/15326/commits/0c935fc6d88a93bdc56c8bdcb85a61f4c4f92ad9
https://github.com/python/cpython/tree/0c935fc6d88a93bdc56c8bdcb85a61f4c4f92ad9
Update doc .rst fileshttps://github.com/python/cpython/pull/15326/commits/538034961b9c367c744da4b183ba237dbde6bbb6
5380349https://github.com/python/cpython/pull/15326/commits/538034961b9c367c744da4b183ba237dbde6bbb6
https://github.com/python/cpython/tree/538034961b9c367c744da4b183ba237dbde6bbb6
Merge branch 'fix-issue-32689' of https://github.com/maxwellmckinnon/cpython into fix-issue-32689https://github.com/python/cpython/pull/15326/commits/caac7fe8c71970901e1a356df4334257828203ae
caac7fehttps://github.com/python/cpython/pull/15326/commits/caac7fe8c71970901e1a356df4334257828203ae
https://github.com/python/cpython/tree/caac7fe8c71970901e1a356df4334257828203ae
Merge branch 'master' into fix-issue-32689https://github.com/python/cpython/pull/15326/commits/090a1bdf5bdca9c3790dca0dbd2e9d5680a92c97
https://github.com/maxwellmckinnon
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
090a1bdhttps://github.com/python/cpython/pull/15326/commits/090a1bdf5bdca9c3790dca0dbd2e9d5680a92c97
https://github.com/python/cpython/tree/090a1bdf5bdca9c3790dca0dbd2e9d5680a92c97
Update shutil.pyhttps://github.com/python/cpython/pull/15326/commits/d1da9e3dc280b83081136da7e8f331d50cb4ad58
https://github.com/maxwellmckinnon
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
d1da9e3https://github.com/python/cpython/pull/15326/commits/d1da9e3dc280b83081136da7e8f331d50cb4ad58
https://github.com/python/cpython/tree/d1da9e3dc280b83081136da7e8f331d50cb4ad58
Update shutil.rsthttps://github.com/python/cpython/pull/15326/commits/4777b4eb8c6623cd68f75e16f32f6c0dc78d90ab
https://github.com/maxwellmckinnon
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
4777b4ehttps://github.com/python/cpython/pull/15326/commits/4777b4eb8c6623cd68f75e16f32f6c0dc78d90ab
https://github.com/python/cpython/tree/4777b4eb8c6623cd68f75e16f32f6c0dc78d90ab
ran python reindent.py -v ~/dev/cpython/Lib/shutil.py to fix whitespace break in CIhttps://github.com/python/cpython/pull/15326/commits/54c752f1ebc5f4cc547c036c8f1e882d3a3513ef
54c752fhttps://github.com/python/cpython/pull/15326/commits/54c752f1ebc5f4cc547c036c8f1e882d3a3513ef
https://github.com/python/cpython/tree/54c752f1ebc5f4cc547c036c8f1e882d3a3513ef
Update Misc/NEWS.d/next/Library/2018-02-13-17-58-30.bpo-32689.a-3SnH.rsthttps://github.com/python/cpython/pull/15326/commits/84832ebc40f4352eaf7f856ee7dd22a77e4defc4
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
84832ebhttps://github.com/python/cpython/pull/15326/commits/84832ebc40f4352eaf7f856ee7dd22a77e4defc4
https://github.com/python/cpython/tree/84832ebc40f4352eaf7f856ee7dd22a77e4defc4
Update shutil.rsthttps://github.com/python/cpython/pull/15326/commits/75f5d1177a90763155528fdb7038f84e27953985
https://github.com/maxwellmckinnon
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
75f5d11https://github.com/python/cpython/pull/15326/commits/75f5d1177a90763155528fdb7038f84e27953985
https://github.com/python/cpython/tree/75f5d1177a90763155528fdb7038f84e27953985
Update test_shutil.pyhttps://github.com/python/cpython/pull/15326/commits/821d5103509088853855a6e6e54feb1e2270c0d5
https://github.com/maxwellmckinnon
maxwellmckinnonhttps://github.com/python/cpython/commits?author=maxwellmckinnon
821d510https://github.com/python/cpython/pull/15326/commits/821d5103509088853855a6e6e54feb1e2270c0d5
https://github.com/python/cpython/tree/821d5103509088853855a6e6e54feb1e2270c0d5
Fixed another whitespace blocker I introduced via online editing -- squash this later -- ran Tools/scripts/reindent.py -v ~/dev/cpython/Lib/test/test_shutil.pyhttps://github.com/python/cpython/pull/15326/commits/446d97153276f5979165d35e8e26c510cd6be138
446d971https://github.com/python/cpython/pull/15326/commits/446d97153276f5979165d35e8e26c510cd6be138
https://github.com/python/cpython/tree/446d97153276f5979165d35e8e26c510cd6be138
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.