| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:40d86c0e-5db2-0f14-051f-5dd98dc50208 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECF2:30C16C:76AEF5:9F88B1:6B00B156 |
| html-safe-nonce | 899ab61247a02715f543ef0775f5f5cce9910e7eeccb87eb7ae076b75ca93a13 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0YyOjMwQzE2Qzo3NkFFRjU6OUY4OEIxOjZCMDBCMTU2IiwidmlzaXRvcl9pZCI6IjQyNDk0Mjk0MTc0MTMwOTU3NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ea75a40718a9c41d270024d431d4da8dc1416307167299f1bb598e4a8270a7ed |
| hovercard-subject-tag | pull_request:308363292 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/15326/commits |
| twitter:image | https://opengraph.githubassets.com/99ec5131a443ebfaf5b0e98d0dbc23ee0cd8001545f96f995d98ccc857d37e24/python/cpython/pull/15326 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/99ec5131a443ebfaf5b0e98d0dbc23ee0cd8001545f96f995d98ccc857d37e24/python/cpython/pull/15326 |
| og:image:alt | Important work originally done by @emilyemorehouse two years ago and nearly ready to go in.
This bug has affected many people and in some cases has been a dealbreaker to the adoption of the otherwi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maxwellmckinnon |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 729d8cda69b3d267995675dfbf89ff27ccf61bf6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/15326/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15326%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15326%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/15326/commits |
| Reload | https://github.com/python/cpython/pull/15326/commits |
| Reload | https://github.com/python/cpython/pull/15326/commits |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| miss-islington | https://github.com/miss-islington |
| python:master | https://github.com/python/cpython/tree/master |
| maxwellmckinnon:fix-issue-32689 | https://github.com/maxwellmckinnon/cpython/tree/fix-issue-32689 |
| Conversation | https://github.com/python/cpython/pull/15326 |
| Commits16 (16) | https://github.com/python/cpython/pull/15326/commits |
| Checks | https://github.com/python/cpython/pull/15326/checks |
| Files changed | https://github.com/python/cpython/pull/15326/files |
| bpo-32689: Updates shutil.move to allow for Path objects to be used as source arg | https://github.com/python/cpython/pull/15326/commits#top |
| miss-islington | https://github.com/miss-islington |
| python:master | https://github.com/python/cpython/tree/master |
| maxwellmckinnon:fix-issue-32689 | https://github.com/maxwellmckinnon/cpython/tree/fix-issue-32689 |
| bpo-32689: Updates shutil.move function to allow for Path objects to be used as source argument by casting to string before performing rstrip. Added documentation on why rstrip needs to be used in … | https://github.com/python/cpython/pull/15326/commits/cc5645d899e34936e5c67ddbef90ee56d3065ae3 |
| https://github.com/emilyemorehouse |
| emilyemorehouse | https://github.com/python/cpython/commits?author=emilyemorehouse |
| cc5645d | https://github.com/python/cpython/pull/15326/commits/cc5645d899e34936e5c67ddbef90ee56d3065ae3 |
| https://github.com/python/cpython/tree/cc5645d899e34936e5c67ddbef90ee56d3065ae3 |
| Adding news entry | https://github.com/python/cpython/pull/15326/commits/61f1019d963343308f112751f6b96d0ad233c3fd |
| https://github.com/emilyemorehouse |
| emilyemorehouse | https://github.com/python/cpython/commits?author=emilyemorehouse |
| 61f1019 | https://github.com/python/cpython/pull/15326/commits/61f1019d963343308f112751f6b96d0ad233c3fd |
| https://github.com/python/cpython/tree/61f1019d963343308f112751f6b96d0ad233c3fd |
| Add test to show breakage for shutil.move where destination is a directory in the form of os.PathLike (pathlib.Path(dir)). | https://github.com/python/cpython/pull/15326/commits/3f016ab1a04d78754b4b35cc686080aef252d2bc |
| 3f016ab | https://github.com/python/cpython/pull/15326/commits/3f016ab1a04d78754b4b35cc686080aef252d2bc |
| https://github.com/python/cpython/tree/3f016ab1a04d78754b4b35cc686080aef252d2bc |
| Taking a guess at what the whitespace issue was. | https://github.com/python/cpython/pull/15326/commits/a66757ba4bbcd15c8219cd7af824097177b19619 |
| a66757b | https://github.com/python/cpython/pull/15326/commits/a66757ba4bbcd15c8219cd7af824097177b19619 |
| https://github.com/python/cpython/tree/a66757ba4bbcd15c8219cd7af824097177b19619 |
| The results of running reindent.check on the file. Hope this fixes the whitespace gating issue. | https://github.com/python/cpython/pull/15326/commits/b0716891b685da683aa084bc6b58b69431efd516 |
| b071689 | https://github.com/python/cpython/pull/15326/commits/b0716891b685da683aa084bc6b58b69431efd516 |
| https://github.com/python/cpython/tree/b0716891b685da683aa084bc6b58b69431efd516 |
| remove whitespace | https://github.com/python/cpython/pull/15326/commits/0c935fc6d88a93bdc56c8bdcb85a61f4c4f92ad9 |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| brandtbucher | https://github.com/python/cpython/commits?author=brandtbucher |
| 0c935fc | https://github.com/python/cpython/pull/15326/commits/0c935fc6d88a93bdc56c8bdcb85a61f4c4f92ad9 |
| https://github.com/python/cpython/tree/0c935fc6d88a93bdc56c8bdcb85a61f4c4f92ad9 |
| Update doc .rst files | https://github.com/python/cpython/pull/15326/commits/538034961b9c367c744da4b183ba237dbde6bbb6 |
| 5380349 | https://github.com/python/cpython/pull/15326/commits/538034961b9c367c744da4b183ba237dbde6bbb6 |
| https://github.com/python/cpython/tree/538034961b9c367c744da4b183ba237dbde6bbb6 |
| Merge branch 'fix-issue-32689' of https://github.com/maxwellmckinnon/cpython into fix-issue-32689 | https://github.com/python/cpython/pull/15326/commits/caac7fe8c71970901e1a356df4334257828203ae |
| caac7fe | https://github.com/python/cpython/pull/15326/commits/caac7fe8c71970901e1a356df4334257828203ae |
| https://github.com/python/cpython/tree/caac7fe8c71970901e1a356df4334257828203ae |
| Merge branch 'master' into fix-issue-32689 | https://github.com/python/cpython/pull/15326/commits/090a1bdf5bdca9c3790dca0dbd2e9d5680a92c97 |
| https://github.com/maxwellmckinnon |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| 090a1bd | https://github.com/python/cpython/pull/15326/commits/090a1bdf5bdca9c3790dca0dbd2e9d5680a92c97 |
| https://github.com/python/cpython/tree/090a1bdf5bdca9c3790dca0dbd2e9d5680a92c97 |
| Update shutil.py | https://github.com/python/cpython/pull/15326/commits/d1da9e3dc280b83081136da7e8f331d50cb4ad58 |
| https://github.com/maxwellmckinnon |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| d1da9e3 | https://github.com/python/cpython/pull/15326/commits/d1da9e3dc280b83081136da7e8f331d50cb4ad58 |
| https://github.com/python/cpython/tree/d1da9e3dc280b83081136da7e8f331d50cb4ad58 |
| Update shutil.rst | https://github.com/python/cpython/pull/15326/commits/4777b4eb8c6623cd68f75e16f32f6c0dc78d90ab |
| https://github.com/maxwellmckinnon |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| 4777b4e | https://github.com/python/cpython/pull/15326/commits/4777b4eb8c6623cd68f75e16f32f6c0dc78d90ab |
| https://github.com/python/cpython/tree/4777b4eb8c6623cd68f75e16f32f6c0dc78d90ab |
| ran python reindent.py -v ~/dev/cpython/Lib/shutil.py to fix whitespace break in CI | https://github.com/python/cpython/pull/15326/commits/54c752f1ebc5f4cc547c036c8f1e882d3a3513ef |
| 54c752f | https://github.com/python/cpython/pull/15326/commits/54c752f1ebc5f4cc547c036c8f1e882d3a3513ef |
| https://github.com/python/cpython/tree/54c752f1ebc5f4cc547c036c8f1e882d3a3513ef |
| Update Misc/NEWS.d/next/Library/2018-02-13-17-58-30.bpo-32689.a-3SnH.rst | https://github.com/python/cpython/pull/15326/commits/84832ebc40f4352eaf7f856ee7dd22a77e4defc4 |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| ammaraskar | https://github.com/python/cpython/commits?author=ammaraskar |
| 84832eb | https://github.com/python/cpython/pull/15326/commits/84832ebc40f4352eaf7f856ee7dd22a77e4defc4 |
| https://github.com/python/cpython/tree/84832ebc40f4352eaf7f856ee7dd22a77e4defc4 |
| Update shutil.rst | https://github.com/python/cpython/pull/15326/commits/75f5d1177a90763155528fdb7038f84e27953985 |
| https://github.com/maxwellmckinnon |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| 75f5d11 | https://github.com/python/cpython/pull/15326/commits/75f5d1177a90763155528fdb7038f84e27953985 |
| https://github.com/python/cpython/tree/75f5d1177a90763155528fdb7038f84e27953985 |
| Update test_shutil.py | https://github.com/python/cpython/pull/15326/commits/821d5103509088853855a6e6e54feb1e2270c0d5 |
| https://github.com/maxwellmckinnon |
| maxwellmckinnon | https://github.com/python/cpython/commits?author=maxwellmckinnon |
| 821d510 | https://github.com/python/cpython/pull/15326/commits/821d5103509088853855a6e6e54feb1e2270c0d5 |
| https://github.com/python/cpython/tree/821d5103509088853855a6e6e54feb1e2270c0d5 |
| Fixed another whitespace blocker I introduced via online editing -- squash this later -- ran Tools/scripts/reindent.py -v ~/dev/cpython/Lib/test/test_shutil.py | https://github.com/python/cpython/pull/15326/commits/446d97153276f5979165d35e8e26c510cd6be138 |
| 446d971 | https://github.com/python/cpython/pull/15326/commits/446d97153276f5979165d35e8e26c510cd6be138 |
| https://github.com/python/cpython/tree/446d97153276f5979165d35e8e26c510cd6be138 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |