René's URL Explorer Experiment


Title: gh-46927: Prevent readline from overriding environment by mbriand · Pull Request #153184 · python/cpython · GitHub

Open Graph Title: gh-46927: Prevent readline from overriding environment by mbriand · Pull Request #153184 · python/cpython

X Title: gh-46927: Prevent readline from overriding environment by mbriand · Pull Request #153184 · python/cpython

Description: Readline library will set the LINES and COLUMNS environment variables during initialization. One might expect these variables to be updated later on SIGWINCH, but this is not the case with cpython. As a consequence, when the readline module is imported, any process launched from cpython with the default environment will have LINES and COLUMNS variables set, potentially to a wrong value. Use the rl_change_environment global variable to disable this initial setup of the environment variables. Issue #46927 -- Sorry, I completely broke the original PR and it got closed: #133585 @ZeroIntensity , @serhiy-storchaka , you did contribute to the discussion of the first PR, so you might have some comments. Issue: gh-46927

Open Graph Description: Readline library will set the LINES and COLUMNS environment variables during initialization. One might expect these variables to be updated later on SIGWINCH, but this is not the case with cpython....

X Description: Readline library will set the LINES and COLUMNS environment variables during initialization. One might expect these variables to be updated later on SIGWINCH, but this is not the case with cpython....

Opengraph URL: https://github.com/python/cpython/pull/153184

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b67d6d54-ee04-23e5-796b-feed150b0953
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8E0:3DCD28:190516C:2121EA3:6B0212E9
html-safe-nonced81752a0111a855bf51d1933d454e6a79cc49764a2bf6a327dc57f8a81f56fcc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEUwOjNEQ0QyODoxOTA1MTZDOjIxMjFFQTM6NkIwMjEyRTkiLCJ2aXNpdG9yX2lkIjoiMzI1NDExODk2NjE2MzAxODQ3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacadec8832fcbe99c4468c5813deda136f786ffccf5d6fa0ed56711981c292acee
hovercard-subject-tagpull_request:3998073006
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/153184/files
twitter:imagehttps://avatars.githubusercontent.com/u/740934?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/740934?s=400&v=4
og:image:altReadline library will set the LINES and COLUMNS environment variables during initialization. One might expect these variables to be updated later on SIGWINCH, but this is not the case with cpython....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/153184/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153184%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153184%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/153184/files
Reloadhttps://github.com/python/cpython/pull/153184/files
Reloadhttps://github.com/python/cpython/pull/153184/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
mbriand:fix-issue-46927https://github.com/mbriand/cpython/tree/fix-issue-46927
Conversation 6 https://github.com/python/cpython/pull/153184
Commits 7 https://github.com/python/cpython/pull/153184/commits
Checks 53 https://github.com/python/cpython/pull/153184/checks
Files changed 6 https://github.com/python/cpython/pull/153184/files
gh-46927: Prevent readline from overriding environment https://github.com/python/cpython/pull/153184/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/153184/files
02d53ae gh-46927: Prevent readline from overriding environment mbriand May 7, 2025 https://github.com/python/cpython/pull/153184/commits/02d53ae3080f7128f49be34acd52d731e8253f58
775ae4a Disable rl_change_environment on apple mbriand May 8, 2025 https://github.com/python/cpython/pull/153184/commits/775ae4a00c55f5ccd3d77119b0591b9a928c0ed6
8bbc1cf Add test mbriand May 12, 2025 https://github.com/python/cpython/pull/153184/commits/8bbc1cf2fc34caa414f9b75d03a913ec3f6927c7
e3bce0d gh-46927: Detect rl_change_environment with a configure probe serhiy-storchaka Jun 27, 2026 https://github.com/python/cpython/pull/153184/commits/e3bce0d1810fda69ce2c50ce91b183825726870e
4e29f03 Merge branch 'main' into fix-issue-46927 serhiy-storchaka Jul 6, 2026 https://github.com/python/cpython/pull/153184/commits/4e29f03d710c4e186833c0cbd69b96798c3525ab
9a98f4f fix typo mbriand Jul 7, 2026 https://github.com/python/cpython/pull/153184/commits/9a98f4fc4e4251e32098a4138cdd241534ab6687
69a639b Fix path of NEWS file mbriand Jul 7, 2026 https://github.com/python/cpython/pull/153184/commits/69a639b2ba1fa3f11099e075041d2cf57378e178
Clear filters https://github.com/python/cpython/pull/153184/files
Please reload this pagehttps://github.com/python/cpython/pull/153184/files
Please reload this pagehttps://github.com/python/cpython/pull/153184/files
test_readline.py https://github.com/python/cpython/pull/153184/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
2025-05-07-18-31-31.gh-issue-46927.sF02gj.rst https://github.com/python/cpython/pull/153184/files#diff-b899fedbb99321ecf000fec34856eb0c38beca035e4fae747adf4ad568541217
readline.c https://github.com/python/cpython/pull/153184/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
configure https://github.com/python/cpython/pull/153184/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/153184/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
pyconfig.h.in https://github.com/python/cpython/pull/153184/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
Lib/test/test_readline.pyhttps://github.com/python/cpython/pull/153184/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
View file https://github.com/mbriand/cpython/blob/69a639b2ba1fa3f11099e075041d2cf57378e178/Lib/test/test_readline.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153184/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153184/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
https://github.com/python/cpython/pull/153184/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
Misc/NEWS.d/next/Library/2025-05-07-18-31-31.gh-issue-46927.sF02gj.rsthttps://github.com/python/cpython/pull/153184/files#diff-b899fedbb99321ecf000fec34856eb0c38beca035e4fae747adf4ad568541217
View file https://github.com/mbriand/cpython/blob/69a639b2ba1fa3f11099e075041d2cf57378e178/Misc/NEWS.d/next/Library/2025-05-07-18-31-31.gh-issue-46927.sF02gj.rst
Open in desktop https://desktop.github.com
StanFromIrelandhttps://github.com/StanFromIreland
Jul 6, 2026https://github.com/python/cpython/pull/153184/files#r3530202399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/153184/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153184/{{ revealButtonHref }}
Modules/readline.chttps://github.com/python/cpython/pull/153184/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
View file https://github.com/mbriand/cpython/blob/69a639b2ba1fa3f11099e075041d2cf57378e178/Modules/readline.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153184/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153184/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/153184/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
configurehttps://github.com/python/cpython/pull/153184/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
View file https://github.com/mbriand/cpython/blob/69a639b2ba1fa3f11099e075041d2cf57378e178/configure
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/153184/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
configure.achttps://github.com/python/cpython/pull/153184/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
View file https://github.com/mbriand/cpython/blob/69a639b2ba1fa3f11099e075041d2cf57378e178/configure.ac
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153184/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153184/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/153184/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
pyconfig.h.inhttps://github.com/python/cpython/pull/153184/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
View file https://github.com/mbriand/cpython/blob/69a639b2ba1fa3f11099e075041d2cf57378e178/pyconfig.h.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/153184/{{ revealButtonHref }}
https://github.com/python/cpython/pull/153184/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com/python/cpython/pull/153184/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
Please reload this pagehttps://github.com/python/cpython/pull/153184/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.