René's URL Explorer Experiment


Title: gh-153133: Fix socket leak in asyncio create_connection by deadlovelll · Pull Request #153134 · python/cpython · GitHub

Open Graph Title: gh-153133: Fix socket leak in asyncio create_connection by deadlovelll · Pull Request #153134 · python/cpython

X Title: gh-153133: Fix socket leak in asyncio create_connection by deadlovelll · Pull Request #153134 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Close the socket in _create_connection_transport() when the transport is never created, not only on await failure For more details see gh-153133

X Description: Close the socket in _create_connection_transport() when the transport is never created, not only on await failure For more details see gh-153133

Opengraph URL: https://github.com/python/cpython/pull/153134

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6802e217-c089-2e68-3648-abe54495bd25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CCE:88BC0:186B78:1E6C80:6B023178
html-safe-nonce7cbf4011aff45e04a0fadcb695a1dcce44754c64b57d0c788951ef745309b6ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NFOjg4QkMwOjE4NkI3ODoxRTZDODA6NkIwMjMxNzgiLCJ2aXNpdG9yX2lkIjoiMzEwOTQ0MzYwNjk3NzU4OTYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb627f7bcc05209ae1cbb2394c2a88650b1d4356fe76ff498ee3cec03cbdd42fc
hovercard-subject-tagpull_request:3993991984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/153134/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f5cc0d1c829f9ec30ddc410b3ae70cd6f98d8239d36e6c893125f20dfe94f777/python/cpython/pull/153134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f5cc0d1c829f9ec30ddc410b3ae70cd6f98d8239d36e6c893125f20dfe94f777/python/cpython/pull/153134
og:image:altClose the socket in _create_connection_transport() when the transport is never created, not only on await failure For more details see gh-153133
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedeadlovelll
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/153134#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153134
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153134
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/153134
Reloadhttps://github.com/python/cpython/pull/153134
Reloadhttps://github.com/python/cpython/pull/153134
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
deadlovelll:gh-153133-socket-leakhttps://github.com/deadlovelll/cpython/tree/gh-153133-socket-leak
Conversationhttps://github.com/python/cpython/pull/153134
Commits2 (2)https://github.com/python/cpython/pull/153134/commits
Checkshttps://github.com/python/cpython/pull/153134/checks
Files changedhttps://github.com/python/cpython/pull/153134/files
gh-153133: Fix socket leak in asyncio create_connectionhttps://github.com/python/cpython/pull/153134#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
deadlovelll:gh-153133-socket-leakhttps://github.com/deadlovelll/cpython/tree/gh-153133-socket-leak
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
Jul 5, 2026https://github.com/python/cpython/pull/153134#issue-4813367059
gh-153133https://github.com/python/cpython/issues/153133
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/deadlovelll
pythongh-153133https://github.com/python/cpython/issues/153133
: Fix socket leak in asyncio create_connectionhttps://github.com/python/cpython/pull/153134/commits/6739735d4e765cc71d0bcb96c822b6c39192f929
6739735https://github.com/python/cpython/pull/153134/commits/6739735d4e765cc71d0bcb96c822b6c39192f929
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/74a2438bf783077cf49460ed0fed8853675fb103/.github/CODEOWNERS#L379
July 5, 2026 15:19https://github.com/python/cpython/pull/153134#event-27575694578
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 5, 2026https://github.com/python/cpython/pull/153134#event-27575695771
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 5, 2026 https://github.com/python/cpython/pull/153134#ref-issue-4813231317
asyncio.create_connection() leaks the socket if the transport cannot be created #153133 https://github.com/python/cpython/issues/153133
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Jul 7, 2026 https://github.com/python/cpython/pull/153134#pullrequestreview-4647317737
View reviewed changes https://github.com/python/cpython/pull/153134/files/6739735d4e765cc71d0bcb96c822b6c39192f929
Lib/asyncio/base_events.pyhttps://github.com/python/cpython/pull/153134/files/6739735d4e765cc71d0bcb96c822b6c39192f929#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/deadlovelll
review changeshttps://github.com/python/cpython/pull/153134/commits/4d9a76e746e030dfaf938c0a59e999a222bb3dc8
4d9a76ehttps://github.com/python/cpython/pull/153134/commits/4d9a76e746e030dfaf938c0a59e999a222bb3dc8
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Jul 7, 2026 https://github.com/python/cpython/pull/153134#pullrequestreview-4648243029
View reviewed changes https://github.com/python/cpython/pull/153134/files/4d9a76e746e030dfaf938c0a59e999a222bb3dc8
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 7, 2026https://github.com/python/cpython/pull/153134#event-27681469487
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
374920ahttps://github.com/python/cpython/commit/374920a23d49130f446fe6369220bc548be57cd2
Jul 7, 2026https://github.com/python/cpython/pull/153134#event-27681598411
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 7, 2026https://github.com/python/cpython/pull/153134#event-27681600546
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jul 24, 2026https://github.com/python/cpython/pull/153134#event-28444984797
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 24, 2026https://github.com/python/cpython/pull/153134#issuecomment-5071749102
@deadlovelllhttps://github.com/deadlovelll
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 24, 2026https://github.com/python/cpython/pull/153134#issuecomment-5071749150
@deadlovelllhttps://github.com/deadlovelll
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 24, 2026https://github.com/python/cpython/pull/153134#issuecomment-5071750515
@deadlovelllhttps://github.com/deadlovelll
@kumaraditya303https://github.com/kumaraditya303
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
kumaraditya303https://github.com/kumaraditya303
Jul 24, 2026https://github.com/python/cpython/pull/153134#event-28444993011
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 24, 2026https://github.com/python/cpython/pull/153134#issuecomment-5071751040
GH-154631https://github.com/python/cpython/pull/154631
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jul 24, 2026https://github.com/python/cpython/pull/153134#event-28444995105
kumaraditya303https://github.com/kumaraditya303
Jul 25, 2026 https://github.com/python/cpython/pull/153134#ref-commit-b4d0b26
https://github.com/miss-islington
https://github.com/deadlovelll
[3.15]https://github.com/python/cpython/commit/b4d0b2621a97f8433e25bb88cbd9c815fff7abe0
gh-153133https://github.com/python/cpython/issues/153133
: Fix socket leak in error path of asyncio create_con…https://github.com/python/cpython/commit/b4d0b2621a97f8433e25bb88cbd9c815fff7abe0
b4d0b26https://github.com/python/cpython/commit/b4d0b2621a97f8433e25bb88cbd9c815fff7abe0
GH-153134https://github.com/python/cpython/pull/153134
#154631https://github.com/python/cpython/pull/154631
gh-153133https://github.com/python/cpython/issues/153133
GH-153134https://github.com/python/cpython/pull/153134
374920ahttps://github.com/python/cpython/commit/374920a23d49130f446fe6369220bc548be57cd2
https://github.com/hugovk
hugovkhttps://github.com/hugovk
Jul 29, 2026https://github.com/python/cpython/pull/153134#issuecomment-5117356887
@deadlovelllhttps://github.com/deadlovelll
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
Jul 29, 2026https://github.com/python/cpython/pull/153134#issuecomment-5117523418
@deadlovelllhttps://github.com/deadlovelll
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
Jul 29, 2026 https://github.com/python/cpython/pull/153134#ref-pullrequest-5013086843
[3.14] gh-153133: Fix socket leak in error path of asyncio create_connection (GH-153134) #154897 https://github.com/python/cpython/pull/154897
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 29, 2026https://github.com/python/cpython/pull/153134#issuecomment-5122720431
GH-154897https://github.com/python/cpython/pull/154897
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jul 29, 2026https://github.com/python/cpython/pull/153134#event-28683042324
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
Jul 29, 2026https://github.com/python/cpython/pull/153134#issuecomment-5122725211
@hugovkhttps://github.com/hugovk
#154897https://github.com/python/cpython/pull/154897
Please reload this pagehttps://github.com/python/cpython/pull/153134
kumaraditya303https://github.com/kumaraditya303
Aug 5, 2026 https://github.com/python/cpython/pull/153134#ref-commit-162bd7e
https://github.com/deadlovelll
[3.14]https://github.com/python/cpython/commit/162bd7ea554c274de94815b75e44e68dbfabcf08
gh-153133https://github.com/python/cpython/issues/153133
: Fix socket leak in error path of asyncio create_con…https://github.com/python/cpython/commit/162bd7ea554c274de94815b75e44e68dbfabcf08
162bd7ehttps://github.com/python/cpython/commit/162bd7ea554c274de94815b75e44e68dbfabcf08
GH-153134https://github.com/python/cpython/pull/153134
#154897https://github.com/python/cpython/pull/154897
asyncio: socket leak and silent error when transport creation fails for an accepted connection #155934 https://github.com/python/cpython/issues/155934
gh-155934: Fix socket leak and silent error for asyncio accepted connections #155936 https://github.com/python/cpython/pull/155936
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153134
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/153134/files/4d9a76e746e030dfaf938c0a59e999a222bb3dc8
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/willingc
willingc https://github.com/willingc
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/153134
https://github.com/deadlovelll
https://github.com/hugovk
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.