René's URL Explorer Experiment


Title: gh-150587: Factor non-negative compact int subscript guards by KRRT7 · Pull Request #153004 · python/cpython · GitHub

Open Graph Title: gh-150587: Factor non-negative compact int subscript guards by KRRT7 · Pull Request #153004 · python/cpython

X Title: gh-150587: Factor non-negative compact int subscript guards by KRRT7 · Pull Request #153004 · python/cpython

Description: This PR is now a refactor/cleanup, not a bug fix. The original version assumed there was a correctness issue around non-compact int indices reaching specialized subscript paths. That turned out to be incorrect: the existing specialization and guard structure already prevents that case from reaching _PyLong_CompactValue() unsafely. What this PR does now is factor the "exact non-negative compact int" check into a shared guard uop and use it in the specialized subscript paths that already rely on that invariant: BINARY_OP_SUBSCR_LIST_INT BINARY_OP_SUBSCR_STR_INT BINARY_OP_SUBSCR_USTR_INT BINARY_OP_SUBSCR_TUPLE_INT STORE_SUBSCR_LIST_INT The refactor keeps the specialized opcode expansions at the same uop counts as before by replacing _GUARD_TOS_INT where appropriate, rather than stacking an additional guard on top. Tests run: env PYTHONPATH=build/lib.macosx-26.5-arm64-3.16 ./python.exe -m test test_opcache -m test_binary_subscr -m test_store_subscr -v env PYTHONPATH=build/lib.macosx-26.5-arm64-3.16 PYTHON_JIT=1 ./python.exe -m test test_opcache -m test_binary_subscr -m test_store_subscr -v Issue: gh-150587

Open Graph Description: This PR is now a refactor/cleanup, not a bug fix. The original version assumed there was a correctness issue around non-compact int indices reaching specialized subscript paths. That turned out to ...

X Description: This PR is now a refactor/cleanup, not a bug fix. The original version assumed there was a correctness issue around non-compact int indices reaching specialized subscript paths. That turned out to ...

Opengraph URL: https://github.com/python/cpython/pull/153004

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:09db7b81-b2d8-da11-6ba5-36657cda5f65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E2A:2C88F2:2BEAD1:3ACC43:6AECC6EE
html-safe-nonce8003dd085c99237fbc5796809b00c6d386d37b4f8c4b1a69972953a1415e0906
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTJBOjJDODhGMjoyQkVBRDE6M0FDQzQzOjZBRUNDNkVFIiwidmlzaXRvcl9pZCI6IjU0NzQ0NTQwODU2NTk1NzYwNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb5295b0b7e430f6acfda12b44eb4356626f54b45d559cb29f60d3083c9077d77
hovercard-subject-tagpull_request:3989893921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/153004/files
twitter:imagehttps://avatars.githubusercontent.com/u/106575910?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/106575910?s=400&v=4
og:image:altThis PR is now a refactor/cleanup, not a bug fix. The original version assumed there was a correctness issue around non-compact int indices reaching specialized subscript paths. That turned out to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedc0b519c5798dc1150b88dc4c06a8b9634d0069218dc04e469970e76aad74016
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb139f0bf57b59bf9a8c4abb0849924d6c6ca559
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/153004/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153004%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F153004%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/153004/files
Reloadhttps://github.com/python/cpython/pull/153004/files
Reloadhttps://github.com/python/cpython/pull/153004/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
KRRT7https://github.com/KRRT7
python:mainhttps://github.com/python/cpython/tree/main
KRRT7:list-int-compact-guardhttps://github.com/KRRT7/cpython/tree/list-int-compact-guard
Conversation 8 https://github.com/python/cpython/pull/153004
Commits 3 https://github.com/python/cpython/pull/153004/commits
Checks 74 https://github.com/python/cpython/pull/153004/checks
Files changed https://github.com/python/cpython/pull/153004/files
Please reload this pagehttps://github.com/python/cpython/pull/153004/files
gh-150587: Factor non-negative compact int subscript guards https://github.com/python/cpython/pull/153004/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/153004/files
f1a230b gh-150587: Guard specialized list-int subscript indices KRRT7 Jul 4, 2026 https://github.com/python/cpython/pull/153004/commits/f1a230bff9c6083b8ae39d7f4981e91ec046256e
a71df5e gh-150587: Use EXIT_IF for store subscript compact guard KRRT7 Jul 5, 2026 https://github.com/python/cpython/pull/153004/commits/a71df5eff4580404b9a542ba2245a82955f74292
2413bac gh-150587: Regenerate opcode metadata KRRT7 Jul 5, 2026 https://github.com/python/cpython/pull/153004/commits/2413bac7166f384eb5f8edba55aa1a01515e28b6
Clear filters https://github.com/python/cpython/pull/153004/files
Please reload this pagehttps://github.com/python/cpython/pull/153004/files
Please reload this pagehttps://github.com/python/cpython/pull/153004/files
pycore_opcode_metadata.h https://github.com/python/cpython/pull/153004/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
pycore_uop_ids.h https://github.com/python/cpython/pull/153004/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
pycore_uop_metadata.h https://github.com/python/cpython/pull/153004/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
test_opcache.py https://github.com/python/cpython/pull/153004/files#diff-dd88a1417bab2a9400460e629e7e43a3f6e798e47b44fe3541f3f804f12430d1
2026-07-04-02-30-00.gh-issue-150587.list-int-compact-guard.rst https://github.com/python/cpython/pull/153004/files#diff-bf4fab8ec8dc5f9593a3550688bcede98bbf1453b210631d1e9ab61dce3962c1
test_cases.c.h https://github.com/python/cpython/pull/153004/files#diff-2852a58ed53ab1473b74dbdc4165885a9b74865b6d71e48fa4813d6289fa1838
bytecodes.c https://github.com/python/cpython/pull/153004/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/153004/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
generated_cases.c.h https://github.com/python/cpython/pull/153004/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
optimizer_cases.c.h https://github.com/python/cpython/pull/153004/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
Include/internal/pycore_opcode_metadata.hhttps://github.com/python/cpython/pull/153004/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
View file https://github.com/KRRT7/cpython/blob/2413bac7166f384eb5f8edba55aa1a01515e28b6/Include/internal/pycore_opcode_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/153004/files
Please reload this pagehttps://github.com/python/cpython/pull/153004/files
Please reload this pagehttps://github.com/python/cpython/pull/153004/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.